[1.12.2] Creative flight in survival not resetting fall distance

[Merthew]

I have made a custom perk system (somewhat) and one of the things is creative flight. However, when using the creative flight the fall distance is not reset to zero. My guess is it is something to do with me not being smart.

 

Relevant file:

PerkHandler,java

 

package merthew.mod.util.handlers;

import merthew.mod.capability.perks.IPerks;
import merthew.mod.capability.perks.PerksProvider;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.MobEffects;
import net.minecraft.potion.PotionEffect;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.gameevent.TickEvent;

public class PerkHandler {
	
	@SubscribeEvent
	public void perkEffects(TickEvent.PlayerTickEvent event) {
		EntityPlayer player = event.player;
		IPerks perks = player.getCapability(PerksProvider.PERKS, null);
		if(perks != null) {
			//Fly========================================================================================\\
			boolean fly = false;
			if(perks.getPerk("fly") >= 1) {
				fly = true;
				event.player.fallDistance = 0.0f;
			}
			else {
				fly = false;
			}
			
			if(fly || event.player.isCreative() || event.player.isSpectator()) {
				event.player.capabilities.allowFlying = true;
				event.player.fallDistance = 0.0f;
			}
			else {
				fly = false;
				event.player.capabilities.allowFlying = false;
				event.player.capabilities.isFlying = false;
			}
			//Strength========================================================================================\\
			if(perks.getPerk("strength") > 0) {
				player.addPotionEffect(new PotionEffect(MobEffects.STRENGTH, 10, perks.getPerk("strength"), false, false));
			}
		}
	}

}

 

[Cadiboo]

Don’t Stringly type your code. How do you know the fall distance isn’t reset to 0? Have you tried stepping through your code with the debugger and seeing what happens?

[Merthew]

I put a sysout statement at the end of the method and it would read 0.0 when the player was either not moving or just moving on the horizontal axis. However, when vertical motion happened it would keep the last value and add to it. That and the player takes fall damage anytime they land if they flew above 3 or 4 blocks.

Edited November 22, 2018 by Merthew

[Merthew]

Still not able to get it working.

[Cadiboo]

Step through the code with the debugger and see why the player gets hurt

[Merthew]

I don't need to know why the player gets hurt, i know that it is from fall damage. I need to know why the value for fall damage is getting saved somewhere and reintroduced after i try and set it to zero.

[Animefan8888]

1 hour ago, Merthew said:

I need to know why the value for fall damage is getting saved somewhere and reintroduced after i try and set it to zero.

The easiest way to do that would be to step through the code in the debugger.

[Merthew]

I am just going to try to do it a different way, i have been looking at this for way too long and finding nothing. Thanks for your help though.