[1.12.2] [SOLVED] Problems With TileEntities and PropertyBools

[Spacejet]

using Forge 1.12.2

 

So I have a couple of problems to do with PropertyBool set on a block with a TileEntity. First problem is that the PropertyBool is not setting to it's default state on block placement, set in setDefaultState()

this.setDefaultState(this.blockState.getBaseState().withProperty(ACTIVATED, Boolean.valueOf(true)));

ACTIVATED is always false on placement, but, after a quick re-log (I don't restart minecraft, just the world) it changes to true.

 

Second Problem is that I don't know how to get and set the value of ACTIVATED from other classes, specifically in this case, the TileEntity class. I have tried everything, searched online, read the documentation but failed to find a mention on how to do it.

Full Block class:

  Reveal hidden contents

package com.spacejet.quantivity.blocks;

import com.spacejet.quantivity.Main;
import com.spacejet.quantivity.tileentity.TileEntityEnergyAccumulator;
import com.spacejet.quantivity.util.handlers.GuiHandler;
import com.spacejet.quantivity.util.handlers.TileEntityHandler;

import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.SoundType;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyBool;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;

public class EnergyAccumulator extends BlockBase implements ITileEntityProvider
{

    public static final PropertyBool ACTIVATED = PropertyBool.create("activated");
    
    public EnergyAccumulator(String name, Material material) 
    {
        super(name, material);
        setHardness(5);
        setHarvestLevel("pickaxe", 2);
        setResistance(30);
        setSoundType(SoundType.METAL);
        setLightLevel(1);
        
        this.setDefaultState(this.blockState.getBaseState().withProperty(ACTIVATED, Boolean.valueOf(true)));
    }
    
    @Override
    public int getMetaFromState(IBlockState state) 
    {
        if(ACTIVATED.getAllowedValues().contains(true)) return 1;
        else return 0;
    }
    
    @Override
    public IBlockState getStateFromMeta(int meta)

    {
        if(meta == 1) return this.getDefaultState().withProperty(ACTIVATED, Boolean.valueOf(true));
        else return this.getDefaultState().withProperty(ACTIVATED, Boolean.valueOf(false));
    }
    
    @Override
    protected BlockStateContainer createBlockState() 
    {
        return new BlockStateContainer(this, new IProperty[] {ACTIVATED}); 
    }
    
    @Override
    public boolean hasTileEntity(IBlockState state) 
    {
        return true;
    }

    @Override
    public TileEntity createNewTileEntity(World worldIn, int meta) 
    {
        return TileEntityHandler.ENERGY_ACCUMULATOR;
    }
    
    @Override
    public boolean onBlockActivated(World world, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, EnumFacing facing, float hitX, float hitY, float hitZ) 
    {
        if(!world.isRemote) 
        {
            playerIn.openGui(Main.instance, GuiHandler.ENERGY_ACCUMULATOR, world, pos.getX(), pos.getY(), pos.getZ());
        }
        
        return true;
    }

}

 

Full TileEntity class (note- I am using the CJCore Library in this mod)

  Reveal hidden contents

package com.spacejet.quantivity.tileentity;

import cjminecraft.core.energy.EnergyUnit;
import cjminecraft.core.energy.EnergyUtils;
import cjminecraft.core.energy.compat.forge.CustomForgeEnergyStorage;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Biomes;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.energy.CapabilityEnergy;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;

public class TileEntityEnergyAccumulator extends TileEntity implements ITickable, ICapabilityProvider
{    
    private ItemStackHandler handler;
    private CustomForgeEnergyStorage storage;
    public static boolean active;
    
    public String name;
    
    private int energy;
    
    public TileEntityEnergyAccumulator(int maxInOut, int maxStore) 
    {
        this.handler = new ItemStackHandler(2);
        this.storage = new CustomForgeEnergyStorage(maxStore, 0);
        this.energy = storage.getEnergyStored();
    }
    
    @Override
    public void update() {
        if(this.world != null) 
        {
            if(!this.world.isRemote) 
            {
                if(this.world.getBiome(this.pos) == Biomes.PLAINS)
                {
                    if(active) {
                        this.storage.receiveEnergyInternal(60, false);
                    }
                }
                this.storage.extractEnergyInternal((int) EnergyUtils.giveEnergyAllFaces(this.world, this.pos, this.storage.getEnergyStored(), EnergyUnit.REDSTONE_FLUX, false, false), false);
            }
        }
    }
    
    @SuppressWarnings("unchecked")
    @Override
    public <T> T getCapability(Capability<T> capability, EnumFacing facing) {
        if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
            return (T) this.handler;
        
        if (capability == CapabilityEnergy.ENERGY)
            return (T) this.storage;
        
        return super.getCapability(capability, facing);
    }
    
    @Override
    public boolean hasCapability(Capability<?> capability, EnumFacing facing) {
        if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY)
            return true;
        
        if(capability == CapabilityEnergy.ENERGY)
            return true;
        
        return super.hasCapability(capability, facing);
    }
    
    @Override
    public void readFromNBT(NBTTagCompound nbt) {
        this.storage.readFromNBT(nbt);
        active = nbt.getBoolean("active");
        super.readFromNBT(nbt);
    }
    
    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound nbt) {
        this.storage.writeToNBT(nbt);
        nbt.setBoolean("active", active);
        return super.writeToNBT(nbt);
    }
    
    @Override
    public ITextComponent getDisplayName() 
    {
        return new TextComponentTranslation("container.energy_accumulator.name");
    }
    
    public void setEnergy(int value)
    {
        this.energy = value;
    }
    
    public int getEnergy()
    {
        return this.energy;
    }
    
    public boolean isUsableByPlayer(EntityPlayer player) 
    {
        return this.world.getTileEntity(this.pos) != this ? false : player.getDistanceSq(this.pos.getX() + 0.5D, this.pos.getY() + 0.5D, this.pos.getZ() + 0.5D) <= 64.0D;
    }
}
 

NOTE- I have not set the value of active(In TE class) as I need to set it equal to ACTIVATED(PropBool in Block class), which I cannot find a way to do

 

Thanks for any help!

 

EDIT - After Reading 

I moved on from using 

ITileEntityProvider

to overriding 

hasTileEntity() and createTileEntity()

 

Edited December 1, 2018 by Spacejet
Marked as Solved

[V0idWa1k3r]

  On 11/29/2018 at 1:20 AM, Spacejet said:

Boolean.valueOf(true)

Expand  

Why are you using boxed values?

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

extends BlockBase

Expand  

BlockBase is an antipattern. There is already a BlockBase, it's called Block.

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

@Override
    public int getMetaFromState(IBlockState state) 
    {
        if(ACTIVATED.getAllowedValues().contains(true)) return 1;
        else return 0;
    }

Expand  

This will always return 1. Serialize the value of the property, not it's property.

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

implements ITickable, ICapabilityProvider

Expand  

TileEntity already implements ICapabilityProvider.

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

public static boolean active;

Expand  

Why is this static?

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

if(this.world != null) 

Expand  

This should never happen in onUpdate, and if it does some mod severely messes up and you should crash the game.

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

active = nbt.getBoolean("active");

Expand  

active is static though. Why are you (de)serializing it for instances?

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

I don't know how to get and set the value of ACTIVATED from other classes, specifically in this case, the TileEntity class.

Expand  

The same way you would do it in your block class. You have the world(TileEntity.world) and the position(TileEntity.pos). Get the blockstate from the world at position and change the value of the property in the same way you would for your block.

[Spacejet]

@V0idWa1k3r the answer to your questions :

 

active is static because I was trying to set it in my block class as ACTIVATED was a part of my block class. I just forgot to change it back. Will do that.

 

I don't really know why I used boxed values when I could have simply used 'true' or 'false' ?. 

 

  On 11/29/2018 at 4:43 AM, V0idWa1k3r said:

  On 11/29/2018 at 1:20 AM, Spacejet said:

mplements ITickable, ICapabilityProvider

Expand  

TileEntity already implements ICapabilityProvider

Expand  

I did not know that. Nice to know!

 

  On 11/29/2018 at 4:43 AM, V0idWa1k3r said:

  On 11/29/2018 at 1:20 AM, Spacejet said:

I don't know how to get and set the value of ACTIVATED from other classes, specifically in this case, the TileEntity class.

Expand  

The same way you would do it in your block class. You have the world(TileEntity.world) and the position(TileEntity.pos). Get the blockstate from the world at position and change the value of the property in the same way you would for your block

Expand  

Is it with setBlockState() cause now I remember that I did not try that. Thanks a ton.

 

  On 11/29/2018 at 4:43 AM, V0idWa1k3r said:

  On 11/29/2018 at 1:20 AM, Spacejet said:

extends BlockBase

Expand  

BlockBase is an antipattern. There is already a BlockBase, it's called Block.

 

Expand  

I call my Registry Handler and register all my blocks in this class.

 

  On 11/29/2018 at 4:43 AM, V0idWa1k3r said:

  On 11/29/2018 at 1:20 AM, Spacejet said:

@Override
    public int getMetaFromState(IBlockState state) 
    {
        if(ACTIVATED.getAllowedValues().contains(true)) return 1;
        else return 0;
    }

Expand  

This will always return 1. Serialize the value of the property, not it's property.

Expand  

I just got to know about an hour ago that .contains() will search every possible output, not the selected. What should I use instead of that?? How do I get the value of the property in the first place?? getBlockState()?? But that returns a BlockStateContainer.

 

EDIT: I want to get its boolean value to set active equal to, but getBlockState() returns the state, not value! Right?

 

  On 11/29/2018 at 4:43 AM, V0idWa1k3r said:

 

  On 11/29/2018 at 1:20 AM, Spacejet said:

if(this.world != null) 

Expand  

This should never happen in onUpdate, and if it does some mod severely messes up and you should crash the game.

Expand  

K. Will crash the game.

 

Thanks a lot for all those improvement tips and answers to some of my questions.

 

P.S: do you know why ACTIVATED returns false when block is first placed into the world? Set default state sets its default state to true!

Edited November 29, 2018 by Spacejet
More detail added

[V0idWa1k3r]

  On 11/29/2018 at 5:23 AM, Spacejet said:

I call my Registry Handler and register all my blocks in this class.

Expand  

That sounds bad. That sound directly accessing the registry levels of bad. And potentially IHasModel levels of bad too.

 

  On 11/29/2018 at 5:23 AM, Spacejet said:

How do I get the value of the property in the first place?? getBlockState()?? But that returns a BlockStateContainer.

Expand  

IBlockState#getValue.

 

  On 11/29/2018 at 5:23 AM, Spacejet said:

do you know why ACTIVATED returns false when block is first placed into the world? Set default state sets its default state to true!

Expand  

I am not sure but you can override Block#getStateForPlacement and return the blockstate with the correct value.

 

  On 11/29/2018 at 5:23 AM, Spacejet said:

Is it with setBlockState()

Expand  

Yes, but you will need to override TileEntity#shouldRefresh in your TE class and make sure it returns false when the value of the property changes, but true otherwise or else the game will recreate your TE when you do that.

[Spacejet]

  On 11/29/2018 at 5:27 AM, V0idWa1k3r said:

  On 11/29/2018 at 5:23 AM, Spacejet said:

do you know why ACTIVATED returns false when block is first placed into the world? Set default state sets its default state to true!

Expand  

I am not sure but you can override Block#getStateForPlacement and return the blockstate with the correct value

Expand  

Ok will try that.....sounds like it will work (hopefully)

 

  On 11/29/2018 at 5:27 AM, V0idWa1k3r said:

  On 11/29/2018 at 5:23 AM, Spacejet said:

How do I get the value of the property in the first place?? getBlockState()?? But that returns a BlockStateContainer.

Expand  

IBlockState#getValue

Expand  

Oh.

  On 11/29/2018 at 5:27 AM, V0idWa1k3r said:

  On 11/29/2018 at 5:23 AM, Spacejet said:

I call my Registry Handler and register all my blocks in this class.

Expand  

That sounds bad. That sound directly accessing the registry levels of bad. And potentially IHasModel levels of bad too

Expand  

 

I regret writing that as I am not on my computer and cannot check to make sure what I wrote was correct as that is what I thought I was doing in blockbase..... what should I do if I was doing the bad thing?

Edited November 29, 2018 by Spacejet
Spelling mistake

[V0idWa1k3r]

  On 11/29/2018 at 5:34 AM, Spacejet said:

what should I do if I was doing the bad thing?

Expand  

Don't directly access the registry, register your things in the appropriate RegistryEvent.Register, in this case it would be Register<Block>.

In case of IHasModel - get rid of it and just register your models directly in the ModelRegistryEvent.

[Spacejet]

Oh then it's fine as I am indeed using registryevents.. phew.. scared me real good.

[Cadiboo]

  On 11/29/2018 at 5:37 AM, Spacejet said:

Oh then it's fine as I am indeed using registryevents.. phew.. scared me real good.

Expand  

Are you instantiating your objects in their registry events?

[Spacejet]

  On 11/29/2018 at 9:21 AM, Cadiboo said:

Are you instantiating your objects in their registry events?

Expand  

Yes. I am just adding the blocks extend blockbase to a list and then that list is passed on to the onBlockRegister() event

BlockBase:

  Reveal hidden contents

package com.spacejet.quantivity.blocks;

import com.spacejet.quantivity.Main;
import com.spacejet.quantivity.init.ModBlocks;
import com.spacejet.quantivity.init.ModItems;
import com.spacejet.quantivity.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;

public class BlockBase extends Block implements IHasModel{
    
    public BlockBase(String name, Material material) {
        
        super(material);
        setUnlocalizedName(name);
        setRegistryName(name);
        
        ModBlocks.BLOCKS.add(this);
        ModItems.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
        
    }

    @Override
    public void registerModels() {
        
        Main.proxy.registerItemRenderer(Item.getItemFromBlock(this), 0, "inventory");
        
    }
}
 

 

RegistryHandler:

  Reveal hidden contents

package com.spacejet.quantivity.util.handlers;

import com.spacejet.quantivity.Main;
import com.spacejet.quantivity.init.ModBiomes;
import com.spacejet.quantivity.init.ModBlocks;
import com.spacejet.quantivity.init.ModItems;
import com.spacejet.quantivity.util.IHasModel;

import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;

@EventBusSubscriber
public class RegistryHandler {

    @SubscribeEvent
    public static void onItemRegister(RegistryEvent.Register<Item> event) {
        
        event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
        
    }
    
    @SubscribeEvent
    public static void onBlockRegister(RegistryEvent.Register<Block> event) {
        
        event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
    }
    
    @SubscribeEvent
    public static void onModelRegister(ModelRegistryEvent event) {
        
        for(Item item : ModItems.ITEMS) {
            
            if(item instanceof IHasModel) {
                ((IHasModel)item).registerModels();
            }    
        }
        
        for(Block block : ModBlocks.BLOCKS) {
            
            if(block instanceof IHasModel) {
                ((IHasModel)block).registerModels();
            }    
        }
    }
    
    public static void preInitRegistries() 
    {
        ModBiomes.registerBiomes();
        TileEntityHandler.RegisterTileEntities();
    }
    
    public static void initRegisteries() 
    {
        NetworkRegistry.INSTANCE.registerGuiHandler(Main.instance, new GuiHandler());
    }
}

 

[Animefan8888]

  On 11/29/2018 at 10:46 PM, Spacejet said:

IHasModel

Expand  

Did you remove this like voidwaker said?

  On 11/29/2018 at 10:46 PM, Spacejet said:

Yes. I am just adding the blocks extend blockbase to a list and then that list is passed on to the onBlockRegister() event

Expand  

Where are you instantiating(calling the constructor) for them? Also you shouldn't have a BlockBase class when you instantiate them add them to the list like so

list.add(new Block(...).set...);

Or even 

RegistryObject registry = event.getRegistry

registry.register(new Block(...).set...);

[Spacejet]

  On 11/29/2018 at 11:16 PM, Animefan8888 said:

  On 11/29/2018 at 10:46 PM, Spacejet said:

Yes. I am just adding the blocks extend blockbase to a list and then that list is passed on to the onBlockRegister() event

Expand  

Where are you instantiating(calling the constructor) for them

Expand  

This is my Mod Blocks class which has the list I am adding the blocks into

  Reveal hidden contents

package com.spacejet.quantivity.init;

import java.util.ArrayList;
import java.util.List;

import com.spacejet.quantivity.blocks.CrystalBlock;
import com.spacejet.quantivity.blocks.EnergyAccumulator;
import com.spacejet.quantivity.blocks.Lantern;
import com.spacejet.quantivity.blocks.TitaniumBlock;
import com.spacejet.quantivity.blocks.TitaniumOre;
import com.spacejet.quantivity.blocks.material.ModMaterial;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;

public class ModBlocks {
    
    public static final List<Block> BLOCKS = new ArrayList<Block>();
    
    public static final Block TITANIUM_BLOCK = new TitaniumBlock("titanium_block", Material.IRON);
    public static final Block BLUE_CRYSTAL_BLOCK = new CrystalBlock("blue_crystal_block", Material.GLASS);
    public static final Block RED_CRYSTAL_BLOCK = new CrystalBlock("red_crystal_block", Material.GLASS);
    public static final Block TITANIUM_ORE = new TitaniumOre("titanium_ore", Material.ROCK);
    public static final Block LANTERN = new Lantern("lantern", ModMaterial.LANTERN);
    
    //Energy Blocks
    public static final Block ENERGY_ACCUMULATOR = new EnergyAccumulator("energy_accumulator", Material.IRON);
}
 

The constructors are called in the class above as you can see..

Edited November 29, 2018 by Spacejet
grammar imperfections

[Animefan8888]

  On 11/29/2018 at 11:26 PM, Spacejet said:

public static final Block TITANIUM_BLOCK = new TitaniumBlock("titanium_block", Material.IRON);

Expand  

Dont do this, this is a static initializer you shouldn't do this with any IForgeRegistryEntry object. Ie anything that has a registry event. They should be initialized in the registryEvent where you register them.

[Spacejet]

  On 11/30/2018 at 12:40 AM, Animefan8888 said:

Dont do this, this is a static initializer you shouldn't do this with any IForgeRegistryEntry object. Ie anything that has a registry event. They should be initialized in the registryEvent where you register them.

Expand  

How would you do that?

[Cadiboo]

Take a look at https://github.com/Cadiboo/Example-Mod/blob/master/src/main/java/cadiboo/examplemod/EventSubscriber.java

You should also check out the README of that repo.

[Spacejet]

  On 11/30/2018 at 3:16 AM, Cadiboo said:

Take a look at https://github.com/Cadiboo/Example-Mod/blob/master/src/main/java/cadiboo/examplemod/EventSubscriber.java

You should also check out the README of that repo.

Expand  

I'll surely look at it. Thanks a lot to everybody who has helped me

[Spacejet]

Marking as solved