Search the Forums BEFORE making a new post.

[1.12.2] ObjectHolder Not Populating Fields

Posted December 2, 20186 yr

Hello,

I am trying to register my blocks and items using the new ObjectHolder annotation, however, the fields that should be populated always return null. I've looked through the official documentation, however, I cannot find out what is wrong with my code.

Here is my ModBlocks and ModItems classes:

Spoiler


@GameRegistry.ObjectHolder(TestMod.MODID)
public class ModBlocks {

    public static final BlockTest testBlock = null;
}

@GameRegistry.ObjectHolder(TestMod.MODID)
public class ModItems {

    public static final ItemTest itemTest = null;
}

Here are the BlockBase, ItemBlockBase, and ItemBase classes:

Spoiler


public class BlockBase extends Block {

    public BlockBase(Material mat, String name){
        super(mat);
        this.setRegistryName(TestMod.MODID, name);
        this.setTranslationKey(getRegistryName().getPath());
    }
}

public class ItemBlockBase extends ItemBlock {

    public ItemBlockBase(Block block){
        super(block);
        this.setTranslationKey(block.getRegistryName().getPath());
        this.setRegistryName(block.getRegistryName());
        this.setCreativeTab(TestMod.creativeTab);
    }
}


public class ItemBase extends Item {

    public ItemBase(String name){
        this.setRegistryName(name);
        this.setTranslationKey(this.getRegistryName().getPath());
        this.setCreativeTab(TestMod.creativeTab);
    }
}

The test item and test block just extend these classes with no extra modifiers.

and lastly, here is my event subscriber:

Spoiler


@Mod.EventBusSubscriber(modid = TestMod.MODID)
public class EventSubscriber {

    @SubscribeEvent
    public static void onRegisterBlocks(final RegistryEvent.Register<Block> event){
        final IForgeRegistry<Block> registry = event.getRegistry();

        registry.register(new BlockTest("block_test"));

        TestMod.logger.info("Registered Blocks!");

        registerTileEntities();

        TestMod.logger.info("Registered Tile Entities!");
    }

    private static void regItemBlocks(IForgeRegistry<Item> registry){
        registry.register(new ItemBlockBase(ModBlocks.testBlock));    //this line crashes the game - as the testblock is still null.
    }

    @SubscribeEvent
    public static void onRegisterItems(final RegistryEvent.Register<Item> event){
        final IForgeRegistry<Item> registry = event.getRegistry();
        regItemBlocks(registry);

        registry.register(new ItemTest("item_test"));

        TestMod.logger.info("Registered Items!");
    }

    private static void registerTileEntities(){

    }

    private static void registerTileEntity(final Class<? extends TileEntity> clazz){
        try {
            GameRegistry.registerTileEntity(clazz, new ResourceLocation(TestMod.MODID, ModUtil.getRegistryNameForClass(clazz, "TileEntity")));
        } catch (final Exception e) {
            TestMod.logger.error("Error while attempting to register a tile entity!", e);
        }
    }
}

and for those interested, here is the error the game throws:

Spoiler


[21:42:21] [Client thread/ERROR] [FML]: Exception caught during firing event net.minecraftforge.event.RegistryEvent$Register@289bb421:
java.lang.NullPointerException: null
	at com.unassigned.testmod.block.base.ItemBlockBase.<init>(ItemBlockBase.java:20) ~[ItemBlockBase.class:?]
	at com.unassigned.testmod.EventSubscriber.regItemBlocks(EventSubscriber.java:46) ~[EventSubscriber.class:?]
	at com.unassigned.testmod.EventSubscriber.onRegisterItems(EventSubscriber.java:52) ~[EventSubscriber.class:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_4_EventSubscriber_onRegisterItems_Register.invoke(.dynamic) ~[?:?]
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) ~[ASMEventHandler.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144) ~[EventBus$1.class:?]
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182) [EventBus.class:?]
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:782) [GameData.class:?]
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:628) [Loader.class:?]
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:252) [FMLClientHandler.class:?]
	at net.minecraft.client.Minecraft.init(Minecraft.java:514) [Minecraft.class:?]
	at net.minecraft.client.Minecraft.run(Minecraft.java:422) [Minecraft.class:?]
	at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_91]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91]
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_91]
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_91]
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_91]
	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_91]
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
	at GradleStart.main(GradleStart.java:25) [start/:?]
[21:42:21] [Client thread/ERROR] [FML]: Index: 2 Listeners:
[21:42:21] [Client thread/ERROR] [FML]: 0: NORMAL
[21:42:21] [Client thread/ERROR] [FML]: 1: net.minecraftforge.fml.common.eventhandler.EventBus$1@3596a9d5
[21:42:21] [Client thread/ERROR] [FML]: 2: net.minecraftforge.fml.common.eventhandler.EventBus$1@441fd20d
[21:42:21] [Client thread/ERROR] [FML]: 3: net.minecraftforge.fml.common.eventhandler.EventBus$1@7146e9a4
[21:42:21] [Client thread/INFO] [STDOUT]: [net.minecraft.init.Bootstrap:printToSYSOUT:629]: ---- Minecraft Crash Report ----
// This doesn't make any sense!

Time: 12/1/18 9:42 PM
Description: Initializing game

java.lang.NullPointerException: Initializing game
	at com.unassigned.testmod.block.base.ItemBlockBase.<init>(ItemBlockBase.java:20)
	at com.unassigned.testmod.EventSubscriber.regItemBlocks(EventSubscriber.java:46)
	at com.unassigned.testmod.EventSubscriber.onRegisterItems(EventSubscriber.java:52)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_4_EventSubscriber_onRegisterItems_Register.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:782)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:628)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:252)
	at net.minecraft.client.Minecraft.init(Minecraft.java:514)
	at net.minecraft.client.Minecraft.run(Minecraft.java:422)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Client thread
Stacktrace:
	at com.unassigned.testmod.block.base.ItemBlockBase.<init>(ItemBlockBase.java:20)
	at com.unassigned.testmod.EventSubscriber.regItemBlocks(EventSubscriber.java:46)
	at com.unassigned.testmod.EventSubscriber.onRegisterItems(EventSubscriber.java:52)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_4_EventSubscriber_onRegisterItems_Register.invoke(.dynamic)
	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90)
	at net.minecraftforge.fml.common.eventhandler.EventBus$1.invoke(EventBus.java:144)
	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:182)
	at net.minecraftforge.registries.GameData.fireRegistryEvents(GameData.java:782)
	at net.minecraftforge.fml.common.Loader.preinitializeMods(Loader.java:628)
	at net.minecraftforge.fml.client.FMLClientHandler.beginMinecraftLoading(FMLClientHandler.java:252)
	at net.minecraft.client.Minecraft.init(Minecraft.java:514)

-- Initialization --
Details:
Stacktrace:
	at net.minecraft.client.Minecraft.run(Minecraft.java:422)
	at net.minecraft.client.main.Main.main(Main.java:118)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
	at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
	at GradleStart.main(GradleStart.java:25)

Thank you.

Currently developing: https://github.com/unassignedxd/Dynamic-Quarries

Quote

December 2, 20186 yr

4 minutes ago, unassigned said:

I've looked through the official documentation

If you put the annotation on the class the field name must match the registry name. IE if the registry name is "block_test" the field name needs to be block_test or BLOCK_TEST.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Quote

December 2, 20186 yr

Author

2 minutes ago, Animefan8888 said:

If you put the annotation on the class the field name must match the registry name. IE if the registry name is "block_test" the field name needs to be block_test or BLOCK_TEST.

Well, that was definitely the problem. Thanks.

Currently developing: https://github.com/unassignedxd/Dynamic-Quarries

Quote

December 2, 20186 yr

Don't use BlockBase or ItemBase or ItemBlockBase and all that

About Me

Spoiler

My Discord - Cadiboo#8887

My Website - Cadiboo.github.io

My Mods - Cadiboo.github.io/projects

My Tutorials - Cadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/67603-1122-objectholder-not-populating-fields/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 7 hours ago7 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · 20 hours ago20 hr
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · 23 hours ago23 hr
Orbital strike cannon fishing rod mod

By FoxyWoxy · Monday at 11:45 PM1 day
New Forum Design/Update: Issues and Suggestions

I don't know that either - newer worked with Invision Community 😕

The Forum/Guides show a customized toolbar:
https://invisioncommunity.com/4guides/themes-and-customizations/editor-and-emoticons_327/customizing-editor-toolbars-r132/
But I have no idea if this applies to v5

Regarding the Forum, "Mark all as read" seems to be hidden as default but is available if I click on my profile:
https://invisioncommunity.com/forums/topic/481218-fix-for-unreadmark-read/

I saw that it works here and also fixes the one unread thread mentioned in my first post - so I had just overlooked it

The toolbar changes are just QoL - if there is no way to change it at the moment, that's fine

By TileEntity · Monday at 09:21 PM1 day

There are no registered users currently online

Sign In

[1.12.2] ObjectHolder Not Populating Fields

Featured Replies

Join the conversation

Posts

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)