So in this method, specifically at itemStack.isEmpty(), when I am in creative mode and right click on water with a bottle, the bottle quickly fills with water then instantly gets removed from the inventory. itemStack#isEmpty is called when there is only 1 bottle left in the stack. In survival this does not happen and it fills up as it should. Everything else is working fine. Also if I change it to PlayerInteractEvent.RightClickBlock, this problem does not occur. This is everything in the class.

Spoiler

@SubscribeEvent
public ActionResult<ItemStack> onItemRightClick(PlayerInteractEvent.RightClickItem event) {
    EntityPlayer player = event.getEntityPlayer();
    EnumHand hand = EnumHand.MAIN_HAND;
    ItemStack itemStack = player.getHeldItem(hand);
    World world = event.getWorld();

    RayTraceResult rayTraceResult = this.rayTrace(world, player, true);

    if (rayTraceResult == null) {
        return new ActionResult(EnumActionResult.PASS, itemStack);
    } else {

        BlockPos blockpos = rayTraceResult.getBlockPos();

        if (world.getBlockState(blockpos).getMaterial() == Material.WATER && itemStack.getItem() == ItemInit.BOTTLE) {
            if (event.getHand() == player.getActiveHand()) {

                player.playSound(SoundEvents.ITEM_BOTTLE_FILL, 1.0f, 1.0f);
                itemStack.shrink(1);

                if (itemStack.isEmpty()) {

                    player.setHeldItem(hand, new ItemStack(ItemInit.WATER));
                } else if (!player.inventory.addItemStackToInventory(new ItemStack(ItemInit.WATER))) {

                    player.dropItem(new ItemStack(ItemInit.WATER), false);
                }
            }

        }
    }

    return new ActionResult(EnumActionResult.PASS, itemStack);
}

 

Thanks! I got it working. Just a quick question while I'm on this topic, does my class have to extend Item to use RayTraceResult?

14 minutes ago, Siqhter said:

Just a quick question while I'm on this topic, does my class have to extend Item to use RayTraceResult?

No

Ok, I might have been misunderstanding, but since RayTraceResult is protected, I can access it with the this keyword if my class extends Item.

34 minutes ago, Siqhter said:

Ok, I might have been misunderstanding, but since RayTraceResult is protected, I can access it with the this keyword if my class extends Item.

Oh, well then no you cant use it. I didnt know if it was protected or not.

Ok, thanks. I could just copy over the RayTraceResult method, but that's extra code.

Edited December 3, 20186 yr by Siqhter