How do I store entities as a data on an Item

TheRPGAdventurer · December 18, 2018

See, I want a dragon whistle that when right clicked will open a gui, and have an array of commands, fly, circle, come, nothing. The commands seem to work but problem is, when i do the command, all the dragons in the world will do the same command, so I want a dragon to be right clicked by the owner to add a lists of dragons to control, the maximum is 3 dragons per whistle. and I can change what dragon to control by shift + right clicking the whistle, it will send a status message at the hotbar with the dragons displayName.

// This code is an attempt, not really finished.

package com.TheRPGAdventurer.ROTD.client.items;

import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;

import javax.annotation.Nullable;

import com.TheRPGAdventurer.ROTD.DragonMounts;
import com.TheRPGAdventurer.ROTD.client.userinput.StatCollector;
import com.TheRPGAdventurer.ROTD.server.entity.EntityTameableDragon;
import com.TheRPGAdventurer.ROTD.server.network.MessageDragonWhistle;

import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.Entity;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ItemDragonWhistle extends Item {

    private final MessageDragonWhistle dcw = new MessageDragonWhistle();
    private List<EntityTameableDragon> dragons = new ArrayList(); 
    EntityTameableDragon dragon;
	
	public ItemDragonWhistle() {
		this.setUnlocalizedName("dragon_whistle");
		this.setRegistryName(new ResourceLocation(DragonMounts.MODID, "dragon_whistle"));
		this.setMaxStackSize(1);
		this.setCreativeTab(DragonMounts.TAB);
	}
	
	@Override
	@SideOnly(Side.CLIENT)
	public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
		tooltip.add(StatCollector.translateToLocal(dragons.toString()));
	}
	
	
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer player, EnumHand hand) {
		ItemStack stack = player.getHeldItem(hand);

        if(worldIn.isRemote && !player.isSneaking()) {
        	DragonMounts.proxy.openDragonWhistleGui(dragon, new ItemStack(this));
        }
        
        return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, stack);
            		
	}
	
	@Override
	public boolean onLeftClickEntity(ItemStack stack, EntityPlayer player, Entity target) {
		if(target instanceof EntityTameableDragon) {
			EntityTameableDragon dragon = (EntityTameableDragon)target;
			this.dragon = dragon;
			if(dragon.isTamedFor(player)) { 			
				NBTTagCompound nbt;
				if(stack.hasTagCompound()) {
					nbt = stack.getTagCompound();
				} else {
					nbt = new NBTTagCompound();
				}
				
				if(nbt.hasKey("dragons")) {
					
				} else {
					
				}
				
				player.sendStatusMessage(new TextComponentTranslation("dragon.added" + dragon.getUniqueID().toString(), new Object[0]), true);
			} else {
				player.sendStatusMessage(new TextComponentTranslation("dragon.notTamed", new Object[0]), true);
			}
			return true;
		} else {
			return false;
		}
	}
	
/*	if(player.isSneaking()) {
    	controllableDragons.iterator().next();
    	player.sendStatusMessage(dragon.getDisplayName(), true);
    	
    	// setting the value of N as 4 
        int limit = 3; 
        int count = 0; 
        Iterator<EntityTameableDragon> it = controllableDragons.iterator(); 
  
        // Iterating through the list of integers 
        while (it.hasNext()) { 
            it.next(); 
            count++; 
  
            // Check if first four i.e, (equal to N) 
            // integers are iterated. 
            if (count > limit) { 
  
                // If yes then remove all the remaining integers. 
                it.remove(); 
            } 
        } 
  
        System.out.print("New stream of length N"
                         + " after truncation is : "); 
  
        // Displaying new stream of length 
        // N after truncation 
        for (EntityTameableDragon number : controllableDragons) { 
            System.out.print(number + " "); 
        } 
    } */
}

V0idWa1k3r · December 18, 2018

Just store the dragon's UUID in the NBT, then you can find said dragon by UUID.

As for the cycling - store a byte indicating the position in the list in the NBT and manipulate it. When getting the UUID for the dragon get it based on that byte. Eiher name your tags dragon_0, dragon_1, etc. or store them in an NBTTagList.

TheRPGAdventurer · December 18, 2018

as for the limit of 3 dragons per whistle?

V0idWa1k3r · December 18, 2018

If using NBTTagList check for it's size, otherwise check each tag for it's existance and the dragon's existance.

TheRPGAdventurer · December 18, 2018

SO NBTTagCompound is wrong and I should prefer using NBTTaglist then remove NBTTagCompound?

V0idWa1k3r · December 18, 2018

Define "wrong".

1 hour ago, TheRPGAdventurer said:

I should prefer using NBTTaglist then remove NBTTagCompound?

I have no idea what this means, sorry.

TheRPGAdventurer · December 18, 2018

Sorry my bad. What methods do I call to store UUID's im not so sure. Also

private List<EntityTameableDragon> dragons = new ArrayList();

   EntityTameableDragon dragon;

would these be included ?

V0idWa1k3r · December 18, 2018

27 minutes ago, TheRPGAdventurer said:

would these be included ?

Obviously not as you can't store anything per instance of ItemStack in a field in an Item class since items are singletons.

28 minutes ago, TheRPGAdventurer said:

What methods do I call to store UUID's im not so sure.

NBTUtil.createUUIDTag/NBTUtil.getUUIDFromTag

TheRPGAdventurer · December 18, 2018

Is there NBT tutorials in the docs, wikipedia for minecraft only provide for commands

TheRPGAdventurer · December 18, 2018

I know theres something wrong and missing here and Im asking you what.

	@Override
	public boolean onLeftClickEntity(ItemStack stack, EntityPlayer player, Entity target) {
		if(target instanceof EntityTameableDragon) {
			EntityTameableDragon dragon = (EntityTameableDragon)target;
			this.dragon = dragon;
			if(dragon.isTamedFor(player)) { 			
				
				NBTTagCompound nbt;
				NBTTagList nbtList;
				if(stack.hasTagCompound()) {
					nbt = stack.getTagCompound();
				} else {
					nbt = new NBTTagCompound(); 
				}
				
				if(nbt.hasKey("dragons")) {
					UUID uuid = dragon.getUniqueID();  					
					nbt.setTag("dragons", NBTUtil.createUUIDTag(uuid));
					
				//} else {
					
				}
				
				player.sendStatusMessage(new TextComponentTranslation("dragon.added" + dragon.getUniqueID().toString(), new Object[0]), true);
			} else {
				player.sendStatusMessage(new TextComponentTranslation("dragon.notTamed", new Object[0]), true);
			}
			return true;
		} else {
			return false;
		}
	}

Animefan8888 · December 18, 2018

11 minutes ago, TheRPGAdventurer said:

Im asking you what.

You never use

11 minutes ago, TheRPGAdventurer said:

NBTTagList nbtList;

Which you first need to initialize a lot like you do your nbt variable.

RANKSHANK · December 19, 2018

15 hours ago, TheRPGAdventurer said:

nbt = new NBTTagCompound();

Make sure you attach this to the itemstack too.

TheRPGAdventurer · December 19, 2018

1 hour ago, RANKSHANK said:

Make sure you attach this to the itemstack too.

what methods should I call?

RANKSHANK · December 19, 2018

ItemStack.setTagCompound(NbtTagCompound)

TheRPGAdventurer · December 19, 2018

1 hour ago, RANKSHANK said:

ItemStack.setTagCompound(NbtTagCompound)

what method do i call to get the dragon from uuid or nbt, does it have something to do with world?

V0idWa1k3r · December 19, 2018

23 minutes ago, TheRPGAdventurer said:

what method do i call to get the dragon from uuid

WorldServer#getEntityFromUuid

TheRPGAdventurer · December 19, 2018

That doesnt exist it seems, just world.getEntityID(int), so how do I convert UUID to int?

V0idWa1k3r · December 19, 2018

1 hour ago, V0idWa1k3r said:

WorldServer

TheRPGAdventurer · December 19, 2018

   @Override
   public boolean onLeftClickEntity(ItemStack stack, EntityPlayer player, Entity target) {
       if(target instanceof EntityTameableDragon) {
           EntityTameableDragon dragon = (EntityTameableDragon)target;
           this.dragon = dragon;
           if(dragon.isTamedFor(player)) {

               NBTTagCompound nbt = new NBTTagCompound();
               NBTTagList nbtList;
               if(stack.hasTagCompound()) {
                   nbt = stack.getTagCompound();
                   nbtList = nbt.getTagList("dragons", 3); // limit as you said
               } else {
                   stack.setTagCompound(nbt);
               }

               if(nbt.hasKey("dragons")) {
                   UUID uuid = dragon.getUniqueID();
                   nbt.setTag("dragons", NBTUtil.createUUIDTag(uuid));
                   nbt.setInteger("dragons", dragon.getEntityId());
               //} else {
               }


               player.sendStatusMessage(new TextComponentTranslation("dragon.added" + dragon.getUniqueID().toString(), new Object[0]), true);
           } else {
               player.sendStatusMessage(new TextComponentTranslation("dragon.notTamed", new Object[0]), true);
           }
           return true;
       } else {
           return false;
       }
   }

Something is missing perhaps, please tell me what, and what methods to use.

V0idWa1k3r · December 19, 2018

16 minutes ago, TheRPGAdventurer said:

this.dragon = dragon;

You can't store information that is per itemstack in item fields since items are singletons.

17 minutes ago, TheRPGAdventurer said:

nbtList = nbt.getTagList("dragons", 3); // limit as you said

First of all the second parameter in NBTTagCompound#getTagList is not it's limit, it's the type of tag in said list. Second of all you need to account for a case where the list is not present in the tag, or the stack has no tag at all. Currently your list will be null in 2/3 cases.

18 minutes ago, TheRPGAdventurer said:

nbt.setTag("dragons", NBTUtil.createUUIDTag(uuid));
nbt.setInteger("dragons", dragon.getEntityId());

wasn't your point to store the dragon's UUID in a list? Why are you storing it in the item's tag?

You are also not storing the list in the tag, so this

22 hours ago, Animefan8888 said:

You never use

22 hours ago, TheRPGAdventurer said:

NBTTagList nbtList;

Which you first need to initialize a lot like you do your nbt variable.

is still the case.

TheRPGAdventurer · December 19, 2018

package com.TheRPGAdventurer.ROTD.client.items;

import java.util.ArrayList;
import java.util.List;
import java.util.UUID;

import javax.annotation.Nullable;

import com.TheRPGAdventurer.ROTD.DragonMounts;
import com.TheRPGAdventurer.ROTD.client.userinput.StatCollector;
import com.TheRPGAdventurer.ROTD.server.entity.EntityTameableDragon;
import com.TheRPGAdventurer.ROTD.server.network.MessageDragonWhistle;

import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemMonsterPlacer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemWrittenBook;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTUtil;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ItemDragonWhistle extends Item {

    private final MessageDragonWhistle dcw = new MessageDragonWhistle();
 //   private List<EntityTameableDragon> dragons = new ArrayList(); 
 //   EntityTameableDragon dragon;
    private byte listPos;
    
    public ItemDragonWhistle() {
        this.setUnlocalizedName("dragon_whistle");
        this.setRegistryName(new ResourceLocation(DragonMounts.MODID, "dragon_whistle"));
        this.setMaxStackSize(1);
        this.setCreativeTab(DragonMounts.TAB);
    }
    
    @Override
    @SideOnly(Side.CLIENT)
    public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
//        tooltip.add(StatCollector.translateToLocal(dragons.toString()));
    }
    
    
    @Override
    public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer player, EnumHand hand) {
        ItemStack stack = player.getHeldItem(hand);

        if(worldIn.isRemote && !player.isSneaking() && stack.hasTagCompound()) {
            DragonMounts.proxy.openDragonWhistleGui(stack.getTagCompound().getUniqueId("dragons"), new ItemStack(this), (WorldServer)worldIn);
        }
        
        return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, stack);
                    
    }
    
    @Override
    public boolean onLeftClickEntity(ItemStack stack, EntityPlayer player, Entity target) {
        if(target instanceof EntityTameableDragon) {
            EntityTameableDragon dragon = (EntityTameableDragon)target;
        //    this.dragon = dragon;
            if(dragon.isTamedFor(player)) {             
                
                NBTTagCompound nbt = new NBTTagCompound();
                NBTTagList nbtList;
                if(stack.hasTagCompound()) {
                    nbt = stack.getTagCompound();
                    nbtList = nbt.getTagList("dragons", 8); // copied from guiscreen book
                } else {
                    stack.setTagCompound(nbt);
                }
                
                if(nbt.hasKey("dragons")) {
                    UUID uuid = dragon.getUniqueID();                      
                    nbt.setTag("dragons", NBTUtil.createUUIDTag(uuid));    
                    //nbt.setInteger("dragons", dragon.getEntityId()); 
                //} else {                
                }
                
                
                player.sendStatusMessage(new TextComponentTranslation("dragon.added" + dragon.getUniqueID().toString(), DragonMounts.MODID), true);
            } else {
                player.sendStatusMessage(new TextComponentTranslation("dragon.notTamed", DragonMounts.MODID), true);
            }
            return true;
        } else {
            return false;
        }
    }
    
/*    if(player.isSneaking()) {
        controllableDragons.iterator().next();
        player.sendStatusMessage(dragon.getDisplayName(), true);
        
        // setting the value of N as 4 
        int limit = 3; 
        int count = 0; 
        Iterator<EntityTameableDragon> it = controllableDragons.iterator(); 
  
        // Iterating through the list of integers 
        while (it.hasNext()) { 
            it.next(); 
            count++; 
  
            // Check if first four i.e, (equal to N) 
            // integers are iterated. 
            if (count > limit) { 
  
                // If yes then remove all the remaining integers. 
                it.remove(); 
            } 
        } 
  
        System.out.print("New stream of length N"
                         + " after truncation is : "); 
  
        // Displaying new stream of length 
        // N after truncation 
        for (EntityTameableDragon number : controllableDragons) { 
            System.out.print(number + " "); 
        } 
    } */
}

Edited December 19, 2018 by diesieben07
syntax highlighting

TheRPGAdventurer · December 19, 2018

package com.TheRPGAdventurer.ROTD.client.items;

import java.util.ArrayList;
import java.util.List;
import java.util.UUID;

import javax.annotation.Nullable;

import com.TheRPGAdventurer.ROTD.DragonMounts;
import com.TheRPGAdventurer.ROTD.client.userinput.StatCollector;
import com.TheRPGAdventurer.ROTD.server.entity.EntityTameableDragon;
import com.TheRPGAdventurer.ROTD.server.network.MessageDragonWhistle;

import gnu.trove.impl.Constants;
import net.minecraft.client.util.ITooltipFlag;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemMonsterPlacer;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemWrittenBook;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.nbt.NBTUtil;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraft.world.WorldServer;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ItemDragonWhistle extends Item {

 //   private final MessageDragonWhistle dcw = new MessageDragonWhistle();
 //   private List<EntityTameableDragon> dragons = new ArrayList(); 
 //   EntityTameableDragon dragon;
    private byte listPos;
	
	public ItemDragonWhistle() {
		this.setUnlocalizedName("dragon_whistle");
		this.setRegistryName(new ResourceLocation(DragonMounts.MODID, "dragon_whistle"));
		this.setMaxStackSize(1);
		this.setCreativeTab(DragonMounts.TAB);
	}
	
	@Override
	@SideOnly(Side.CLIENT)
	public void addInformation(ItemStack stack, @Nullable World worldIn, List<String> tooltip, ITooltipFlag flagIn) {
//		tooltip.add(StatCollector.translateToLocal(dragons.toString()));
	}
	
	
	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer player, EnumHand hand) {
		ItemStack stack = player.getHeldItem(hand);

        if(!worldIn.isRemote && !player.isSneaking() && stack.hasTagCompound()) {
        	DragonMounts.proxy.openDragonWhistleGui(stack.getTagCompound().getUniqueId("dragons"), new ItemStack(this), (WorldServer)worldIn);
        }
        
        return new ActionResult<ItemStack>(EnumActionResult.SUCCESS, stack);
            		
	}
	
	@Override
	public boolean onLeftClickEntity(ItemStack stack, EntityPlayer player, Entity target) {
		if(target instanceof EntityTameableDragon) {
			EntityTameableDragon dragon = (EntityTameableDragon)target;
		//	this.dragon = dragon;
			if(dragon.isTamedFor(player)) { 			
				
				NBTTagCompound nbt = new NBTTagCompound();
				NBTTagList nbtList;
				if(stack.hasTagCompound()) {
					nbt = stack.getTagCompound();
					nbtList = nbt.getTagList("dragons", Constants.DEFAULT_BYTE_NO_ENTRY_VALUE); 
				} else {
					stack.setTagCompound(nbt);
				}
				
				if(nbt.hasKey("dragons")) {
					UUID uuid = dragon.getUniqueID();  					
					nbt.setTag("dragons", NBTUtil.createUUIDTag(uuid));	
					//nbt.setInteger("dragons", dragon.getEntityId()); 
				//} else {				
				}
				
				
				player.sendStatusMessage(new TextComponentTranslation("dragon.added" + dragon.getUniqueID().toString(), DragonMounts.MODID), true);
			} else {
				player.sendStatusMessage(new TextComponentTranslation("dragon.notTamed", DragonMounts.MODID), true);
			}
			return true;
		} else {
			return false;
		}
	}
	
/*	if(player.isSneaking()) {
    	controllableDragons.iterator().next();
    	player.sendStatusMessage(dragon.getDisplayName(), true);
    	
    	// setting the value of N as 4 
        int limit = 3; 
        int count = 0; 
        Iterator<EntityTameableDragon> it = controllableDragons.iterator(); 
  
        // Iterating through the list of integers 
        while (it.hasNext()) { 
            it.next(); 
            count++; 
  
            // Check if first four i.e, (equal to N) 
            // integers are iterated. 
            if (count > limit) { 
  
                // If yes then remove all the remaining integers. 
                it.remove(); 
            } 
        } 
  
        System.out.print("New stream of length N"
                         + " after truncation is : "); 
  
        // Displaying new stream of length 
        // N after truncation 
        for (EntityTameableDragon number : controllableDragons) { 
            System.out.print(number + " "); 
        } 
    } */
}

Edited December 19, 2018 by diesieben07
syntax highlighting

TheRPGAdventurer · December 19, 2018

Current Problem :

1. really need a docs to understand NBT's and know what methods to call. Vanilla codes cannot be trusted that much "too many much magic numbers and the effort of cycling through each class used for different problems"

2. Constant has been cast on a wrong import lmao, use forge one

3. Cannot diffrentiate NBTLists to NBTTagCompound, it seems like NBTTagCompound is required to use NBTTagLists,

4. Not knowing Cycling through dragons as mentioned above, with byte and what to call to cycle

5. Can I really use Guis to set dragon with commands, pic from the first post

6. Limits as mentioned, no idea how

to set it it with NBTTagLists

Things I Understand:

1. Items are singletons use ItemStacks for some reason (if have a hacked 64 stack diamond sword then separate them from stack in an inventory its low red bar durability is retained)

2. NBT's as I vaguely understood are a way to store data on stuff. Like entities, items, guis? (GUIScreenBook : stored on item or GUI)

3. We will use stored ID's to identify what dragon to control no brainer.

Edited December 19, 2018 by TheRPGAdventurer

TheRPGAdventurer · December 19, 2018

26 minutes ago, diesieben07 said:

I... what?

Limits? Mentioned where?

Per Whistle, I mentioned that it can carry 3 dragon datas. So i want a limit for 3 dragons, I also have to ensure the dragons have the player who used it is the dragon's owner, but since items are singletons....

So i need an NBTTagList to store 3 dragons and cycle which dragon to control with shift + rightCLicking it and it will print a message in the hotbar saying The details what the dragon is being controlled, Owner or UUID breed, I can choose maybe at least one so it wont be a hassle.

TheRPGAdventurer · December 20, 2018

21 hours ago, diesieben07 said:

newIndex = (oldIndex + 1) % Math.min(3, [length of the list]). That will fail if the list is empty

So after I made this, what getter should I call it in the nbt?

Sign In

How do I store entities as a data on an Item

Recommended Posts

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Link to comment

Share on other sites

Join the conversation

Announcements

Recently Browsing

Posts

Topics

Who's Online (See full list)

Important Information