Custom Block Map Colors?

[Guest]

Hello,

 

I'd like to know if there is a way to create custom map colors. I've tried this:

	@Override
	public MapColor getMapColor(IBlockState state, IBlockAccess worldIn, BlockPos pos)
    {
		return new MapColor(52, 8801331);
		
    }

However, MapColor has a private constructor, so this doesn't work. Any solutions? Would making my own class that extends MapColor work or be the most efficient?

[V0idWa1k3r]

  On 12/28/2018 at 5:08 AM, Wolftopia said:

However, MapColor has a private constructor, so this doesn't work. Any solutions?

Expand  

You could use reflection.

 

  On 12/28/2018 at 5:08 AM, Wolftopia said:

Would making my own class that extends MapColor work or be the most efficient?

Expand  

The problem with that is that you can't call super in your constructor since the constructor of the original class is private. And you must call it because MapColor doesn't provide a parameterless constructor.

Alternatively I suppose you could use access transformers, but that is not an ideal solution. Or you could submit a PR to forge.

[Draco18s]

  On 12/28/2018 at 5:08 AM, Wolftopia said:

Hello,

 

I'd like to know if there is a way to create custom map colors. I've tried this:

	@Override
	public MapColor getMapColor(IBlockState state, IBlockAccess worldIn, BlockPos pos)
    {
		return new MapColor(52, 8801331);
		
    }

However, MapColor has a private constructor, so this doesn't work. Any solutions? Would making my own class that extends MapColor work or be the most efficient?

Expand  

1) Its private because MapColor is an enum, not a class, you aren't supposed to be creating new instances.

2) Extending the enum is meaningless as MapItemRenderer does not use YourMapColor, it uses MapColor. And it wouldn't work anyway because the superclass constructor is private, not protected.

[quadraxis]

MapColor is not an enum. However, it is not a good idea to try adding additional instances, as there are only a few available slots for them, and no way of avoiding ID collisions.

 

In any case, returning a new instance from the getter is also incorrect, a fixed value should be used.