Jump to content

[Mod] getItemFromBlock() return null. [SOLVED]


MrSalimoc

Recommended Posts

I'm working on my mod for creating a new block, but i'm stuck.
The problem is in the title.

The code :
 

package mrsalimoc.moderntech.common.blocks;

import mrsalimoc.moderntech.ModernTech;
import mrsalimoc.moderntech.common.items.MTItems;
import mrsalimoc.moderntech.util.MTModel;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;

public class MTBlockBase extends Block implements MTModel{

	public MTBlockBase(String name, Material material) {
		super(material);
		setUnlocalizedName(name);
		setRegistryName(name);
		setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		
		MTBlocks.BLOCKS.add(this);
		MTItems.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()).setUnlocalizedName(this.getUnlocalizedName()));
		System.out.println(this.getRegistryName()); //returning 'moderntech:testblock' (my block)
		System.out.println(new ItemBlock(this).getRegistryName()); //returning 'null'
	}

	@Override
	public void registerModels() {
		ModernTech.proxy.registerItemRenderer(Item.getItemFromBlock(this), 0, "inventory");
		System.out.println(Item.getItemFromBlock(this).getUnlocalizedName()); //returning 'tile.air' (null)
		System.out.println(Item.getItemFromBlock(this).getRegistryName()); //returning 'minecraft:air'
	}
}

 

Creating block code :

package mrsalimoc.moderntech.common.blocks;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.item.Item;

public class MTBlocks {

	public static final List<Block> BLOCKS = new ArrayList<Block>();
	
	public static final Block TESTBLOCK = new MTBlockBase("testblock", Material.IRON);
}

 

 

I don't have any error, but the block don't exist in the game when i launch.
(If you need more code, tell me)

Edited by MrSalimoc
Link to comment
Share on other sites

When do you register your blocks, and why do you have yout BLOCKS array?

procedure WakeMeUp(Integer plusTime);
var
  I: Integer;
begin
  for I := 0 to plusTime do begin
    println('One more minute!');
    Sleep(1000);
  end;
  println('Okay, nothing to worry, I''m alive!');
  println('So... somebody can give me a coffee?');
  println('I know it''s Pascal, and not Java, but I love it :D.');
end;
Link to comment
Share on other sites

I register my block in a Registry Handler :
 

package mrsalimoc.moderntech.util.handler;

import mrsalimoc.moderntech.common.blocks.MTBlocks;
import mrsalimoc.moderntech.common.items.MTItems;
import mrsalimoc.moderntech.util.MTModel;
import net.minecraft.block.Block;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod.EventBusSubscriber;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

@EventBusSubscriber
public class RegistryHandler {

	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(MTItems.ITEMS.toArray(new Item[0]));;
	}
	
	public static void onBlockRegister(RegistryEvent.Register<Block> event) {
		event.getRegistry().registerAll(MTBlocks.BLOCKS.toArray(new Block[0]));;
	}


	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event) {
		for(Item item : MTItems.ITEMS) {
			if(item instanceof MTModel) {
				System.out.println("Item registered");
				((MTModel)item).registerModels();
			}
		}
		
		for(Block block : MTBlocks.BLOCKS) {
			if(block instanceof MTModel) {
				System.out.println("Block registered");
				((MTModel)block).registerModels();
			}
		}
	}
}


And the array contain all my blocks that i create. (see the code)

Link to comment
Share on other sites

You're registering your BLOCKS array's elements, but when did you set it's values?

procedure WakeMeUp(Integer plusTime);
var
  I: Integer;
begin
  for I := 0 to plusTime do begin
    println('One more minute!');
    Sleep(1000);
  end;
  println('Okay, nothing to worry, I''m alive!');
  println('So... somebody can give me a coffee?');
  println('I know it''s Pascal, and not Java, but I love it :D.');
end;
Link to comment
Share on other sites

Here , in my Blocks class :
 

package mrsalimoc.moderntech.common.blocks;

import java.util.ArrayList;
import java.util.List;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.item.Item;

public class MTBlocks {

	public static final List<Block> BLOCKS = new ArrayList<Block>();
	
	public static final Block TESTBLOCK = new MTBlockBase("testblock", Material.IRON);
}

 

Link to comment
Share on other sites

You aren't setting your BLOCKS array's values, you're just making it, and you make a totally different Block.
You should have something in you MTBlocks class:
 

public class MTBlocks {
	
	public static final MTBlockBase TESTBLOCK = new MTBlockBase("testblock", Material.IRON);

	public static final Block[] BLOCKS = {
		TESTBLOCK
	};

}

 

and you should have something like this in your RegistryHandler:

 

@EventBusSubscriber
public class RegistryHandler {

	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		event.getRegistry().registerAll(MTItems.ITEMS); //This should be remade too
        	for (Block Block_ : MTBlocks.BLOCKS) registry.register(Block_.createItemBlock()) // You need to register the Block's items too
	}
	
    	@SubscribeEvent //You didn't wrote it.
	public static void onBlockRegister(RegistryEvent.Register<Block> event) {
		event.getRegistry().registerAll(MTBlocks.BLOCKS);
	}


	@SubscribeEvent
	public static void onModelRegister(ModelRegistryEvent event) {
		for(Item item : MTItems.ITEMS) {
			if(item instanceof MTModel) {
				System.out.println("Item registered");
				((MTModel)item).registerModels();
			}
		}
		
		for(Block block : MTBlocks.BLOCKS) {
			if(block instanceof MTModel) {
				System.out.println("Block registered");
				((MTModel)block).registerModels();
			}
		}
	
}

 

This code (Edit) isn't 100% correct, you should check if anything else is missing, like calling these registers from the mainClass, etc.

Edited by Legenes
procedure WakeMeUp(Integer plusTime);
var
  I: Integer;
begin
  for I := 0 to plusTime do begin
    println('One more minute!');
    Sleep(1000);
  end;
  println('Okay, nothing to worry, I''m alive!');
  println('So... somebody can give me a coffee?');
  println('I know it''s Pascal, and not Java, but I love it :D.');
end;
Link to comment
Share on other sites

P.S.: What tutorial did you use? If none, or only ForgeDocs, I would recomment to use Shadowfact's tutorial. (Only thing he does poorly, is the proxy system, that one should be made using the ForgeDocs.)

procedure WakeMeUp(Integer plusTime);
var
  I: Integer;
begin
  for I := 0 to plusTime do begin
    println('One more minute!');
    Sleep(1000);
  end;
  println('Okay, nothing to worry, I''m alive!');
  println('So... somebody can give me a coffee?');
  println('I know it''s Pascal, and not Java, but I love it :D.');
end;
Link to comment
Share on other sites

None, at start i followed a tutorial but there is too many error then I tried myself (with ForgeDocs).

Big thank, my error was :
 

   	@SubscribeEvent //You didn't wrote it.
	public static void onBlockRegister(RegistryEvent.Register<Block> event) {
		event.getRegistry().registerAll(MTBlocks.BLOCKS);
	}

 

  • Like 1
Link to comment
Share on other sites

You need to use @ObjectHolder and instantiate your objects in the registry events

About Me

Spoiler

My Discord - Cadiboo#8887

My WebsiteCadiboo.github.io

My ModsCadiboo.github.io/projects

My TutorialsCadiboo.github.io/tutorials

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.