Hi everyone,

I created two different items 1- Sacrifice Heart / 2- Sacrifice Ingot

 

Them json and pngs are different but they have same texture in game. How can i fix this bug?

 

Sacrifice Heart json

---------------------------------------

{
   "parent": "item/generated",
   "textures": {
       "layer0": "sacri:items/heart_sacrifice"
   }
}

---------------------------------------------------

Sacrifice Ingot json

---------------------------------------------------

{
   "parent": "item/generated",
   "textures": {
       "layer0": "sacri:items/ingot_sacrifice"
   }
}

-----------------------------------------------

 

Please provide more information. How are you registering the models for your items? Are you using forge's blockstates for them?

@Override
    public void registerModels() {
        
        Main.proxy.registerItemRenderer(this, 0, "inventory");
        
    }

 

And i'm not using Forge's blockstate

You have posted a function that doesn't tell me anything. I don't know where it is defined and what your proxy's registerItemRenderer does. 

Although this alone leads me to suspect you are using IHasModel in which case - don't.

-------------MORE INFORMATION-----------

I'm using IHasModel

public interface IHasModel {
	
	
	public void registerModels();
}

 

This is place that i register

 

public class ItemBase extends Item implements IHasModel{

	public ItemBase(String name) {
		
		
		setUnlocalizedName(name);
		setCreativeTab(CreativeTabs.MISC);
		setRegistryName(name);
		
		ItemInit.ITEMS.add(this);
	}

	@Override
	public void registerModels() {
		
		Main.proxy.registerItemRenderer(this, 0, "inventory");
		
	}
	
}

Another class

@EventBusSubscriber
public class RegistryHandler {

	
	@SubscribeEvent
	public static void onItemRegister(RegistryEvent.Register<Item> event) {
		
		event.getRegistry().registerAll(ItemInit.ITEMS.toArray(new Item[0]));
		
	}
	
	@SubscribeEvent
	public static void onModelRegister(RegistryEvent event) {
		
		
		for(Item item : ItemInit.ITEMS) {
			
			if(item instanceof IHasModel) {
				((IHasModel)item).registerModels();
			}
				
			
		}
	}

 

Stop using IHasModel.

 

Code Style Issue #3 (and #1)

See also Problematic Code #7 and possibly #14
 

Want to read more about IHasModel? I've posted the same thing like 30 times elsewhere. I'm getting sick of it.

 

http://www.minecraftforge.net/forum/search/?&q=IHasModel&type=forums_topic&author=Draco18s&search_and_or=or&sortby=relevancy

Edited February 2, 20196 yr by Draco18s

On 2/3/2019 at 3:45 AM, Draco18s said:

like 30 times elsewhere

More like 300

 

What: Not using an interface to register models

Why: This interface (commonly called IHasModel) is unnecessary. All items need models and nothing about model registration requires private or protected data.

Consequences: This interface makes you write 4 lines of code in each class and 2+ lines of code in your registry event, when 1 or 2 lines of code could accomplish the exact same thing. It also leads to weird bugs when you forget to make your object implement the interface.

How: Simply register each model in the registry event (1 line of code for each model) or write a loop that does it for you (1 or 2 lines depending on the implementation). For example:

Write out

registerModel(item, meta, variant)

for each item and variant or write a loop like this

for (Item item : allModItemsAndItemBlocks)
	    registerModel(item, meta, variant);

A list of all your items can be acquired in many ways, such as looping over registries and checking domain, keeping your own list, looping over registries and using an instanceof check etc.