[1.12.2] Correctly adding EntityAI tasks to EntityAnimals [SOLVED]

[mirk]

Hello again!

I'm wondering what the best way to add a custom EntityAI thing to all EntityAnimals would be? I'm currently doing it on LivingSpawnEvent, but that feels a bit hacky, and I don't know how to check if the EntityAnimals already have the task. Would the best way to do this be at registration?

 

Here's where I'm doing it:

Spoiler

@SubscribeEvent
public static void AddPettingAITask(LivingSpawnEvent event)
{
  EntityLivingBase livingBase = event.getEntityLiving();

  if(livingBase instanceof EntityAnimal)
  {
    EntityAnimal animalEntity = (EntityAnimal)livingBase;
    animalEntity.tasks.addTask(10, new EntityAIPet(animalEntity));
  }
}

 

 

The EntityAIPet class is basically an AI task that allows the player to pet the animal for a small amount of XP every now and then. I can post the code if need be.

Edited February 10, 2019 by mirk

[Draco18s]

As far as I am aware, that's correct.

[mirk]

Yeah, I just refined it a bit and I'm coming back to report that it's a success!

 

Here's the refined code for anyone looking to do a similar thing:

Spoiler

@SubscribeEvent
public static void AddPettingAITask(LivingSpawnEvent event)
{
    EntityLivingBase livingBase = event.getEntityLiving();

    if(livingBase instanceof EntityAnimal)
    {
      	EntityAnimal animalEntity = (EntityAnimal)livingBase;

      	boolean addPettingTask = true;
      	for(EntityAITasks.EntityAITaskEntry task : animalEntity.tasks.taskEntries)
      	{
      		if(task.action instanceof EntityAIPet)
      		{
      			addPettingTask = false;
      			break;
      		}
		}

        if(addPettingTask)
        {
        	animalEntity.tasks.addTask(10, new EntityAIPet(animalEntity));
        }
	}
}

 

Sorry if the formatting is a bit off, it's not cooperating with me.

[Draco18s]

Now you can check to see if there is any possible way that addPettingTask = false; ever gets called. Its possible that it never does.

[mirk]

It is indeed called, at game load, as it looks like the task list is saved at game exit, then loaded on game load, so the EntityAIPet task persists in the task list, and it tries to add another copy of the task as the EntityAnimal spawns in, so addPettingTask = false (sorry, I'm not familiar with the forum formatting options yet) does get set.