{1.13.2} Crops aren't dropping seeds, just the food ?

[RedBullSlurpie]

In 1.12.2 i had it working to where my custom food, example is Corn, When planted would drop both Corn, and sometimes drop a seed so you can re-plant the crop and keep it going. In 1.13.2, I looked at the code for Wheat Seeds and pretty much followed the same setup they have, but my corn continues to only drop food, never any seeds. Here is my Corn Crop code, as well as the Corn Seed Code.

 

Corn Crop Class- https://pastebin.com/yMjhsXaR

Corn Seed Class- https://pastebin.com/JEUSUmLE

Where I am creating the Corn Crop- https://pastebin.com/TmcUHEXJ

Where I am Creating the Corn Seed- https://pastebin.com/FA3zzeBg

 

Not sure what im doing wrong, or if I missed anything, any help would be appreciated. Also I noticed that when I break a crop before its fully grown, nothing at all drops, which was not the case in 1.12.2. Anyone know why this is from looking at my code ?

[DavidM]

1. Stop using static initializers.

2. Most of your overriding methods does not have the @Override annotation, and are therefore messy and hard to debug. Use the @Override notation.

I suspect that you did not override some necessary methods due to the wrong signature. After adding the Override annotations to all of your methods, your compiler should tell you what the problem is.

Edited February 19, 2019 by DavidM

[Cadiboo]

1 hour ago, DavidM said:

1. Stop using static initializers.

What: Not using static initialisers.
Why: Using static initialisers does not allow you to control when your objects are created or the order in which your objects are created.
Consequences: Using static initialisers prevents other mods from overriding your objects, prevents forge from being able to dynamically load/unload mods and can cause weird, unreproducible crashes.
How: Use the @ObjectHolder annotation if you need static references to your objects and create & register your objects in the appropriate registry event. (Note: before registry events Modders created and registered their items in preInit. This practice became out of date in 1.7 with the introduction of registry events, and is no longer possible in 1.13).

1 hour ago, DavidM said:

2. Use the @Override notation

What: Using @Override.
Why: Using @Override tells the compiler that you intend to override a method. This lets your IDE warn you about bugs before they happen.
Consequences: When you update your mod to a new minecraft version/ update your mappings/ update your Forge version and don’t use @Override, methods will silently stop overriding what they should override due to name changes, and will fail to ever be called, resulting in unexpected behaviour, crashes and bugs.
How: Just annotate methods you intend to override with the @Override annotation.

 

[Choonster]

7 hours ago, Cadiboo said:

What: Not using static initialisers.
Why: Using static initialisers does not allow you to control when your objects are created or the order in which your objects are created.
Consequences: Using static initialisers prevents other mods from overriding your objects, prevents forge from being able to dynamically load/unload mods and can cause weird, unreproducible crashes.
How: Use the @ObjectHolder annotation if you need static references to your objects and create & register your objects in the appropriate registry event. (Note: before registry events Modders created and registered their items in preInit. This practice became out of date in 1.7 with the introduction of registry events, and is no longer possible in 1.13).

What: Using @Override.
Why: Using @Override tells the compiler that you intend to override a method. This lets your IDE warn you about bugs before they happen.
Consequences: When you update your mod to a new minecraft version/ update your mappings/ update your Forge version and don’t use @Override, methods will silently stop overriding what they should override due to name changes, and will fail to ever be called, resulting in unexpected behaviour, crashes and bugs.
How: Just annotate methods you intend to override with the @Override annotation.

 

 

Your most recent few posts with these pre-written snippets of advice have been poorly formatted on the dark theme:

 

 

To fix it, you should be able to use the T_x (Remove Format) button and then re-apply the code formatting to the necessary parts.

 

Normally I'd PM you this, but unfortunately the forum wants me to delete a whole lot of PMs in my inbox before I can send another one.