13.2 LootTableLoadEvent not firing for vanilla loot tables

[aw_wolfe]

prior to 13.2, LootTableLoadEvent would fire for vanilla loot tables. ForgeHooks#loadLootTable received a (false) for "custom" parameter. This led to ForgeEventFactory.loadLootTable(name, ret, lootTableManager); being executed. Which in turn led to the LootTableLoadEvent firing.

 

 

However, in 13.2 : (ForgeHooks)

if (!custom)
            ret = ForgeEventFactory.loadLootTable(name, ret, lootTableManager);

 

Is never called for me (except on my own mod's loot tables) because ForgeHooks#loadLootTable is always passed a true for "custom" parameter for any minecraft loot table.

 

Is this a design change? Is something off with my mod/install? A bug? Is there another way to catch and edit vanilla loot tables (need to do dynamically -- do not want to simply add new json that overwrites)?

[aw_wolfe]

Anyone point me in the right direction?

The vanilla loot tables are coming in as "custom" and final. So, not able to catch them in LootTableLoadEvent and unable to modify them by getting LootTableManager and modify them after load.

 

In 1.12, vanilla would fire the LootTableLoadEvent and you could modify the pools.

In 1.13.2, vanilla is not firing the LootTableLoadEvent because it thinks they are "custom".

 

 

[Keitaro]

In 1.13 you can change the loottables with data packs.

Just add the json loottable  for whatever you want to change inside your data folder.

 

Like data/minecraft/loot_tables/entities/pig.json for example.

[aw_wolfe]

Thanks. I get that I can put static loot tables in json.

 

I have a set of loot conditions that need to be checked dynamically.  So in 1.12, I have my own LootConditions, LootEntry. Therefore, I could easily say "if 'unique item' is not already dropped ever in game, zombies can drop 'unique ite'm on Tuesdays after dark with 60%".  My other mods could also add a new item and use this mod as utility to quickly add complex loot conditions.

 

The problem is that in 13.2. LootTableLoadEvent is not being called for vanilla loot tables. It has them as "custom=true" and in 1.12, "custom=false"...so forgehook is NOT called in 13.2, whereas it was in 1.12.

 

If I copy all vanilla loot tables into data/mymod/loot_tables , not all of them are triggering LootTableLoadEvent either...haven't investigated why. 

I am hoping I am doing something dumb or not seeing an obvious solution.

[Draco18s]

So? Implement ILootCondition.