Jump to content

Recommended Posts

Posted

Hello, I have been trying to create a healing event that heals living entities when right-clicked with a certain item. However, when the character right clicks with the item, nothing occurs, that I can see.

package Justin_Perry.learningMod.EventHandlers;


import Justin_Perry.learningMod.init.modItems;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.network.play.server.SPacketCombatEvent.Event;

public class MedicEvents 
{
	
	public boolean onRightClickHeal(ItemStack itemStack, EntityPlayer player, EntityLivingBase target)
	{
		 if (player.getHeldItemMainhand().getItem() == modItems.FAIRY_DUST && target.getHealth() < target.getMaxHealth()) {
			 System.out.println(target.getHealth());
			 target.setHealth(target.getHealth() + 2.0F);
			 System.out.println(target.getHealth());
			 
			 return true;
			 
		 }else {
			 return false;
		 }
	}
}

Thank you for your time today.

Posted (edited)

There is no need for events.

Override Item#itemInteractionForEntity in the class of the item you want to use to heal (get the target (EntityLivingBase) from the parameters ).

 

Apart from that, the code you posted is not a valid event subscriber. Event subscribers take in exactly one parameter (event type).

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Posted (edited)

If the behavior is to be implemented with a new item, prioritize overriding Item#itemInteractionForEntity over creating an event subscriber.

 

If for some reason the "overriding Item#itemInteractionForEntity" cannot be implemented, create an event subscriber for PlayerInteractEvent.EntityInteract.

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.