Sound Not Working

[outflows]

 

So all I want to do is add a sound to the registry but for some reason it's not working. This is what I did:

public class SoundRegistrator 
{
	public static final SoundEvent BOND;
	
	static {
		BOND = addSoundsToRegistry("bond");
	}
	
	private static SoundEvent addSoundsToRegistry(String soundId) {
		ResourceLocation shotSoundLocation = new ResourceLocation("pokalert", soundId);
		SoundEvent soundEvent = new SoundEvent(shotSoundLocation);
		soundEvent.setRegistryName(shotSoundLocation);
		return soundEvent;
	}
}

public class SoundRegisterListener 
{
  @SubscribeEvent(priority = EventPriority.NORMAL, receiveCanceled = true)
  public void registerSOundEvents(RegistryEvent.Register<SoundEvent> event) {
	  event.getRegistry().registerAll(SoundRegistrator.BOND);
  }
}

EntityPlayer player = Minecraft.getMinecraft().player;
EntityPlayerSP sp = (EntityPlayerSP)player;
ResourceLocation location = new ResourceLocation("pokalert", "bond");
SoundEvent sevent = new SoundEvent(location);
sp.playSound(sevent, 5.0f, 5.0f);

{
  "bond": {
    "category": "player",
    "sounds": [{ "name": "pokalert:bond.ogg", "stream": true }]
    }
}

 

[CrashDbo]

  On 4/10/2019 at 2:20 AM, outflows said:

 

  public void registerSOundEvents(RegistryEvent.Register<SoundEvent> event) {

Expand  

 

I think you want registerSoundEvent, not registerSOundEvent.

[DavidM]

  On 4/10/2019 at 3:01 AM, CrashDbo said:

I think you want registerSoundEvent, not registerSOundEvent.

Expand  

The method name does not matter in this case.

 

  On 4/10/2019 at 2:20 AM, outflows said:

static { BOND = addSoundsToRegistry("bond"); }

Expand  

Do not statically instantiate your sounds. Instantiate and register them in the appropriate event.

[outflows]

  On 4/10/2019 at 3:27 AM, DavidM said:

The method name does not matter in this case.

 

Do not statically instantiate your sounds. Instantiate and register them in the appropriate event.

Expand  

what would the appropriate event be? Also, would I put the eventbus for this in the init or preinit? One last thing, the sound file I'm using is like 3 minutes long so would that affect anything?

Edited April 10, 2019 by outflows

[DavidM]

1.

  On 4/10/2019 at 4:45 AM, outflows said:

what would the appropriate event be?

Expand  

This:

  On 4/10/2019 at 2:20 AM, outflows said:

public void registerSOundEvents(RegistryEvent.Register<SoundEvent> event) { event.getRegistry().registerAll(SoundRegistrator.BOND); }

Expand  

In this event subscriber, instead of doing:

event.getRegistry().registerAll(SoundRegistrator.BOND);

, create the SoundEvents instead. Something similar to:

event.getRegistry().registerAll(new SoundEvent(...).setRegistryName(...), new SoundEvent(...)...);

 

2.

  On 4/10/2019 at 4:45 AM, outflows said:

would I put the eventbus for this in the init or preinit

Expand  

If I'm understanding what you are doing correctly, you should not need init or preinit.

All your sound registration goes in the RegistryEvent.Register<SoundEvent> event subscriber.

Edited April 10, 2019 by DavidM

[outflows]

  On 4/10/2019 at 7:26 AM, DavidM said:

 

This:

In this event subscriber, instead of doing:

event.getRegistry().registerAll(SoundRegistrator.BOND);

, create the SoundEvents instead. Something similar to:

event.getRegistry().registerAll(new SoundEvent(...).setRegistryName(...), new SoundEvent(...)...);

Expand  

Thanks for the help with that but I have one more question if you don't mind helping. Although this is somewhat unrelated, I've been searching through forum posts for hours now and can't figure out how to make the sound follow the player. If you could help that would be awesome

[outflows]

  On 4/10/2019 at 8:08 AM, diesieben07 said:

Check out MovingSoundMinecart.

Expand  

Yes, I have seen you on like 3 other posts saying that. I looked at the class and I didn't really understand how on earth I was supposed to implement that into my code. Granted I only started modding like a week ago. I actually figured it out though for anyone who wants to know. It's incredibly simple:

 

Minecraft.getMinecraft().getSoundHandler().playSound(PositionedSoundRecord.getMusicRecord(SoundEvent));

[outflows]

Could you show me an example of this being used

[outflows]

Do you know how I can get a list of all sounds that are currently playing in the world?

[outflows]

  On 4/10/2019 at 8:49 AM, diesieben07 said:

Minecraft#getSoundHandler()#sndManager#playingSounds. Note that both sndManager and playingSounds are private fields, so you'll have to use reflection to access them.

Expand  

For some reason I'm getting an error while trying to call this. I don't know if you meant to put the pound signs there but maybe that's some syntax I'm unfamiliar with. I am also unfamiliar with reflection if you could help me out there too.

[Cadiboo]

The "#" is the same as a ".", it just means "instance method" "instance" rather than "static method" "static"

Read https://stackoverflow.com/questions/37628/what-is-reflection-and-why-is-it-useful

Then use the ObfuscationReflectionHelper (only in Forge versions above 2782)

Edited April 10, 2019 by Cadiboo

[outflows]

oh, well in that case I cannot find the sndManager method when I do Minecraft.getMinecraft().getSoundHandler().sndManager()

[Cadiboo]

My bad, It doesn't have to be a method, it can also be a field.

[outflows]

  On 4/10/2019 at 9:08 AM, Cadiboo said:

My bad, It doesn't have to be a method, it can also be a field.

Expand  

So how would I format it so that I don't get the error. Sorry btw I'm really new to modding and I didn't learn any of this in my java class for whatever reason

[Cadiboo]

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

[outflows]

  On 4/10/2019 at 9:13 AM, Cadiboo said:

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

Expand  

Oh I see, that makes more sense now. Thanks for all the help.

[outflows]

  On 4/10/2019 at 9:13 AM, Cadiboo said:

Minecraft.getMinecraft().getSoundHandler().sndManager.playingSounds.

As diesieben07 said, sndManager and playingSounds are private, so you will need to use Reflection or an Access Transformer to access them.

Expand  

I'm sorry to keep asking questions but I am thoroughly confused as to how I can use reflection to get these methods. Right now I have:

 

Minecraft mc = Minecraft.getMinecraft();
Method method = mc.getClass().getMethod("sndManager", null);

[Cadiboo]

  On 4/10/2019 at 9:01 AM, Cadiboo said:

Then use the ObfuscationReflectionHelper (only in Forge versions above 2782)

Expand  

Example of something similar (getting and then setting Minecraft#blockRendererDispatcher#fluidRenderer) https://github.com/Cadiboo/NoCubes/blob/ef2968d83544597fd5d267e476742beb2ec9a177/src/main/java/io/github/cadiboo/nocubes/client/ClientProxy.java#L89 

[outflows]

  On 4/10/2019 at 9:39 AM, Cadiboo said:

Example of something similar (getting and then setting Minecraft#blockRendererDispatcher#fluidRenderer) https://github.com/Cadiboo/NoCubes/blob/ef2968d83544597fd5d267e476742beb2ec9a177/src/main/java/io/github/cadiboo/nocubes/client/ClientProxy.java#L89 

Expand  

Hey so I tried using reflection to get the necessary fields and it works the first time to obtain the sndManager object but when I try to use that in order to obtain the playingSounds variable, I end up getting an error because it apparently doesn't exist as an instance variable of the sndManager object. I tried checking to see what fields I get from the sndManager object but none of them were the same as in the SoundManager class. All I remember was that one of the fields was clazz and another was fieldAccessor. I really hope you can help me because I've been stuck on this problem for hours now. Here is my code: 

 

        SoundHandler sh = Minecraft.getMinecraft().getSoundHandler();
        Class cls = sh.getClass();
        Class snd = cls.getDeclaredField("sndManager").getClass();
        Field ps = snd.getDeclaredField("playingSounds");

[outflows]

  On 4/10/2019 at 12:58 PM, diesieben07 said:

• Do not use getClass to get class object. Use class literals (Foo.class).
• You need to use the methods in ObfuscationReflectionHelper and you need to use SRG names.  Otherwise your code will not work outside the development environment.

Expand  

It would really help if you could show me how to do it because I am very lost at the moment

[outflows]

  On 4/10/2019 at 2:12 PM, diesieben07 said:

Which part do you have problems with exactly...?

Expand  

Well I have no idea how to format this tbh. Also, I don't know what SRG means and how to use the helper thing. If you could just at least give me a template for how I could access the playingSounds method that would be awesome

[outflows]

  On 4/10/2019 at 3:10 PM, diesieben07 said:

Minecraft code is obfuscated when it is distributed by Mojang. Forge uses MCP mappings to translate the obfuscated names to readable names. The SRG names are an intermediary step in this process. You can use the MCPBot (see linked page) to look up the SRG name for any method or field.

Expand  

This is what I was able to get but it definitely does not work

 

        Class mc = Minecraft.class;
        java.lang.reflect.Method sh = mc.getMethod("getSoundHandler", null);
        sh.setAccessible(true);
        SoundHandler soundH = (SoundHandler)sh.invoke(mc, null);
        ObfuscationReflectionHelper.getPrivateValue(soundH.class, new Object(), "playingSounds");

[outflows]

  On 4/10/2019 at 4:55 PM, diesieben07 said:

• Do not use getPrivateValue. Use findField, etc. to get the Field / Method instance.
• Please learn the basics of reflection.

Expand  

I'm sorry, I've been trying to learn it but it's not very intuitive for me. Should I be using the ObfuscationReflectionHelper to get the soundhandler as well?

Edited April 10, 2019 by outflows

[outflows]

  On 4/10/2019 at 4:55 PM, diesieben07 said:

• Do not use getPrivateValue. Use findField, etc. to get the Field / Method instance.
• Please learn the basics of reflection.

Expand  

I can't find any info online about SRG names and the website that they use is down for some reason. I am just really confused right now

[Cadiboo]

You need

- the SoundHandler instance from getSoundHandler

- Field Objects for sndManager and playingSounds

Then get the value of each field using Field#get on the appropriate instance.

 

Critique:

  On 4/10/2019 at 4:53 PM, outflows said:

Class mc = Minecraft.class;

Expand  

Why do you store this in a variable? You only use it once

  On 4/10/2019 at 4:53 PM, outflows said:

java.lang.reflect.Method

Expand  

Why is this fully qualified?

  On 4/10/2019 at 4:53 PM, outflows said:

Method sh = mc.getMethod("getSoundHandler", null);

Expand  

Isn’t this method public?

  On 4/10/2019 at 4:53 PM, outflows said:

ObfuscationReflectionHelper.getPrivateValue(soundH.class, new Object(), "playingSounds");

Expand  

What is soundH? The SoundHandler doesn’t have this value, the SoundManager does. The SoundHandler  has an instance of the SoundManager which you need to get though (sndManager). You also need to use the SRG name of the field which you can look up at many places.