MC1.12.2 How to get properly soundType from a block

[winnetrie]

How would i get the soundType from a block.

 

Right now i have this:

parentBlock = ForgeRegistries.BLOCKS.getValue(new ResourceLocation(modprefix + registryname));
setSoundType(parentBlock.getSoundType());

but getSoundType()  is deprecated.

There is also this:

getSoundType(IBlockState state, World world, BlockPos pos, @Nullable Entity entity)

But i do not understand to use this. Why do i need World, BlockPos and Entity here ?

World, BlockPos and Entity are not relevant.

I need the soundtype from the parentblock, but not parentblock that is already somewhere in the world.

EDIT: Same thing for getBlockHardness btw

Edited April 10, 2019 by winnetrie

[winnetrie]

1 minute ago, diesieben07 said:

What are you trying to achieve?

I'm trying to create a universal BlockSlab class, where the soundtype and blockhardness is the same as the block i want it to be.

For example i have a bricks block and i want to make a slab for it with the same properties(sound, hardnes etc etc)

[winnetrie]

23 minutes ago, diesieben07 said:

Override the respective methods in your slab class and delegate to their versions in the original block.

Like this? :

@Override
	public SoundType getSoundType(IBlockState state, World world, BlockPos pos, @Nullable Entity entity){
		
		blockSound = parentBlock.getSoundType(state, world, pos, entity);
		
        return blockSound;
    }

How would i set the slabs soundtype to this sound now?

[winnetrie]

1 minute ago, diesieben07 said:

Is blockSound a field here?

yes a private field.

1 minute ago, diesieben07 said:

You do not "set" the sound. The sound is determined by whatever is returned from getSoundType. If you return your parent block's getSoundType result you effectively copy it's behavior.

Oh..? Really? I didn't knew that. I Always thought i need to get it and then set it also.

Does this rule also apply for getblockhardness?

Wait i post the class:

public abstract class BlockTerracottaSlab extends BlockSlab{
	
	private Block parentBlock;
	private SoundType blockSound;

	public BlockTerracottaSlab(Material material, MapColor mapcolor, String modprefix, String registryname) {
		super(material, mapcolor);
		
		parentBlock = ForgeRegistries.BLOCKS.getValue(new ResourceLocation(modprefix + registryname));
		//setSoundType(blockSound);
		setRegistryName(modprefix + registryname);
		setCreativeTab(CreativeTabs.BUILDING_BLOCKS);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public SoundType getSoundType(IBlockState state, World world, BlockPos pos, @Nullable Entity entity){
		
		blockSound = parentBlock.getSoundType(state, world, pos, entity);
        return blockSound;
    }
	
	
	@Override
    public float getBlockHardness(IBlockState blockState, World worldIn, BlockPos pos)
    {
        return parentBlock.getBlockState().getBaseState().getBlockHardness(worldIn, pos);
    }

	@Override
	public String getUnlocalizedName(int meta) {
		// TODO Auto-generated method stub
		return parentBlock.getUnlocalizedName();
	}

	@Override
	public boolean isDouble() {
		// TODO Auto-generated method stub
		return false;
	}

	@Override
	public IProperty<?> getVariantProperty() {
		// TODO Auto-generated method stub
		return BlockSlab.HALF;
	}

	@Override
	public Comparable<?> getTypeForItem(ItemStack stack) {
		// TODO Auto-generated method stub
		return EnumBlockHalf.BOTTOM;
	}
	
	@SideOnly(Side.CLIENT)
    protected static boolean isHalfSlab(IBlockState state)
    {
        Block block = state.getBlock();
        return block instanceof BlockSlab;
    }
	
	public static class Double extends BlockTerracottaSlab {

		public Double(Material material, MapColor mapcolor, String modprefix, String registryname) {
			super(material, mapcolor, modprefix, registryname);
			// TODO Auto-generated constructor stub
		}

		@Override
		public boolean isDouble() {
			return true;

		}
	}

	public static class Half extends BlockTerracottaSlab {

		public Half(Material material, MapColor mapcolor, String modprefix, String registryname) {
			super(material, mapcolor, modprefix, registryname);
			// TODO Auto-generated constructor stub
		}

		@Override
		public boolean isDouble() {
			return false;

		}
	}

}

please tell me if something isn't right.

[winnetrie]

2 minutes ago, diesieben07 said:

getBlockHardness looks fine, you can do the same thing in getSoundType, you do not need the blockSound field.

Oh right, i'm sorry. I forget to fix that. It's indeed not needed. Thank you very much.

I actually can't believe it was as easy as that…..??

[winnetrie]

Just another quick question. Can i do the same for getMapColor and getMaterial?

Just asking because they have a deprecated annotiation

Edited April 10, 2019 by winnetrie