[1.12.2] Unbinding TESRs

[DavidM]

I was playing a modpack (Sky Factory 4), and the amount of "Bonsai Pot", a tile entity whose TESR is expensive, is causing severe performance issue on the client side.

Someone has already made a PR that adds a config to disable the rendering; however, the PR was not accepted.

Therefore, I am wondering if it is possible to make a new mod to "unbind", or disable, certain TESR from a tile entity.

How would I disable certain TESRs?

Edited April 28, 2019 by DavidM

[DavidM]

I've created a prototype of this: https://github.com/davidmaamoaix/StopRender/blob/master/src/main/java/cn/davidma/stoprender/StopRender.java.

I've tested this with vanilla chest and ender chest, and received promising results.

However, is this code going to cause any problems?

Edited April 28, 2019 by DavidM

[Cadiboo]

It’s sounds like the author should really fix their code

[loordgek]

DavidM IS the author

edit - oops i was thinking cadiboo was talking about davidM code my bad

Edited May 1, 2019 by loordgek

[desht]

13 minutes ago, loordgek said:

DavidM IS the author

No, he's the author of some code to unbind the TESR, not the author of Bonsai Trees.  But looking at the github issue, the Bonsai Trees author is looking into the performance issues.

 

@DavidM The unbinding code looks fine on the face of it, having looked at TileEntityRendererDispatcher, but I'd recommend testing it with Bonsai Trees and as many other mods as is feasible.