Jump to content

[1.12.2] Item name doesn't display


Kekz

Recommended Posts

I know that similar questions have been asked and I followed the steps given in those answers but my Item still doesn't display a proper name.

I followed a somewhat outdated tutorial while building the bases for my mod. Since then I added most of what my Item is supposed to do.  

The only thing left is the item name, I already have a texture.  

Maybe someone can find a mistake I made in the folder setup, or maybe I used the wrong name. I checked everything and can't find my error.  

 

My folder structure with location of en_us.lang (I also tried naming it en_US.lang, still didn't work):  

folder_structure_mc.thumb.PNG.3640c25d95c3932ee974a9269541dbf7.PNG

Also classes:  

 

Main mod class:

Spoiler

package me.opkekz.imagespawner;

import me.opkekz.imagespawner.configuration.ConfigurationHandler;
import me.opkekz.imagespawner.init.ModItems;
import me.opkekz.imagespawner.item.ImageSpawnerItem;
import me.opkekz.imagespawner.proxy.IProxy;
import me.opkekz.imagespawner.reference.Reference;
import me.opkekz.imagespawner.utility.ImageSpawnerCommand;
import net.minecraft.item.Item;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.event.FMLServerStartingEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;

@Mod(modid=Reference.MOD_ID, name=Reference.MOD_NAME, version=Reference.VERSION)
public class ImageSpawner {
    
    @Mod.Instance(Reference.MOD_ID)
    public static ImageSpawner instance;
    
    @SidedProxy(clientSide=Reference.CLIENT_PROXY, serverSide=Reference.SERVER_PROXY)
    public static IProxy proxy;
    
    @EventHandler
    public void serverStarting(FMLServerStartingEvent event) {
        event.registerServerCommand(new ImageSpawnerCommand());
    }

    @Mod.EventHandler
    public void preInit(FMLPreInitializationEvent event) {
        //ConfigurationHandler.init(event.getSuggestedConfigurationFile());
        ModItems.init();
        
    }
    
    @Mod.EventHandler
    public void init(FMLInitializationEvent event) {
        //proxy.init();
    }
    
    @Mod.EventHandler
    public void postInit(FMLPostInitializationEvent event) {
        
    }
    
}

 

Reference.java:  

Spoiler

package me.opkekz.imagespawner.reference;

public class Reference {
    
    public static final String MOD_ID = "imagespawner";
    public static final String MOD_NAME = "ImageSpawner";
    public static final String VERSION = "1.12.2-1.0";
    public static final String CLIENT_PROXY = "me.opkekz.imagespawner.proxy.ClientProxy";
    public static final String SERVER_PROXY = "me.opkekz.imagespawner.proxy.ServerProxy";
    
    public static enum ImageSpawnerEnum {
        IMAGESPAWNER("imagespawner", "imagespawner");
        
        private String unlocalizedName;
        private String registryName;
        
        ImageSpawnerEnum(String unlocalizedName, String registryName) {
            this.unlocalizedName = unlocalizedName;
            this.registryName = registryName;
        }
        
        public String getRegistryName() {
            return registryName;
        }
        
        public String getUnlocalizedName() {
            return unlocalizedName;
        }
    }

}
 

 

ModItems.java:

Spoiler

package me.opkekz.imagespawner.init;

import java.util.HashSet;
import java.util.Set;

import me.opkekz.imagespawner.item.ImageSpawnerItem;
import me.opkekz.imagespawner.reference.Reference;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.event.ModelRegistryEvent;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.event.RegistryEvent;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.registry.ForgeRegistries;
import net.minecraftforge.registries.IForgeRegistry;

@Mod.EventBusSubscriber(modid=Reference.MOD_ID)
public class ModItems {
    
    public static ImageSpawnerItem imagespawner;
    
    public static void init() {
        
        imagespawner = new ImageSpawnerItem();
        //ForgeRegistries.ITEMS.register(imagespawner);
        
    }
    
    @SubscribeEvent
    public static void registerItems(RegistryEvent.Register<Item> event) {
        event.getRegistry().registerAll(imagespawner);
    }
    
    @SubscribeEvent
    public static void registerRenders(ModelRegistryEvent event) {
        registerRender(imagespawner);
    }
    
    private static void registerRender(Item item) {
        ModelLoader.setCustomModelResourceLocation(item, 0, new ModelResourceLocation( item.getRegistryName(), "inventory"));
    }
    
}

 

The first part of the item class:  

Spoiler

package me.opkekz.imagespawner.item;

import com.google.common.eventbus.Subscribe;

import ibxm.Player;
import me.opkekz.imagespawner.reference.Reference;
import me.opkekz.imagespawner.utility.GetRGB;
import me.opkekz.imagespawner.utility.RgbToEnum;
import net.minecraft.block.Block;
import net.minecraft.block.BlockColored;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.Minecraft;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.EnumDyeColor;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.network.play.client.CPacketChatMessage;
import net.minecraft.server.MinecraftServer;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.MathHelper;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ImageSpawnerItem extends Item{
    
    IBlockState[][] blockMatrix;
    public static final PropertyEnum<EnumDyeColor> COLOR = PropertyEnum.<EnumDyeColor>create("color", EnumDyeColor.class);
    private String imagePath;
    
    public ImageSpawnerItem() {
        
        super();
        this.setCreativeTab(CreativeTabs.TOOLS);
        setUnlocalizedName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getUnlocalizedName());
        setRegistryName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getRegistryName());
        
        int[][] rgbMatrix = GetRGB.getValues("C:\\Users\\Ale\\Downloads\\forge-1.12.2-14.23.5.2768-mdk\\src\\main\\java\\me\\opkekz\\imagespawner\\utility\\LOLTesti.png");
        EnumDyeColor[][] colorMatrix = RgbToEnum.rgbToEnum(rgbMatrix);
        buildBlockMatrix(colorMatrix);
        
    }

 

My en_us.lang file contains this line:  

item.imagespawner.name=Image Spawner  

 

As far as I understand, after "item." I have to write the unlocalized name, which I did. I also put it in the right folder (as far as I know) but it still won't work.  

 

I would be very thankful for any kind of help.

If you need any more information let me know.

Edited by Kekz
Link to comment
Share on other sites

Your enum is over complicating the process of setting names.

A good practice is to set the unlocalized name to the registry name to avoid conflicts, since the registry name contains the mod id.

this.setUnlocalizedName(this.getRegistryName().toString());

 

Also, define “don’t work”. What is the name currently like?

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

First of all to answer your question, go ingame and and press F3 + H....This will show advanced tooltips.

Now put your item/block in your inventory and hover with your mouse over it. You should see a gray tekst, that tekst contains your modid followed with ":" and then the name of your item/block

Actually to be short the gray tekst is the registryname of your item/block. So what does it say? …."imagespawner:imagespawner" ?

DavidM is right. Why do you use an enum for naming stuff? Why do you use 2 separate names for registryname and unlocalizedname?

Something i do is passing a resourcelocation in the constructor for example my invar block class in a simple way:

 

public class BlockInvar extends Block{

	public BlockInvar(ResourceLocation registryname) {
		super(Material.IRON, MapColor.IRON);
		setSoundType(SoundType.METAL);
		setHardness(7.0F);
		setResistance(10.0F);
		//setHarvestLevel("pickaxe", 3);
		setUnlocalizedName(registryname.toString());
		setRegistryName(registryname);
		setCreativeTab(Utilities.WINNETRIESEXPANSIONMOD);
	}

}

You can still use an Enum if you like, but just keep 1 name. 

Creating the block would look like this:

ModBlockReference.invar_block = new BlockInvar(new ResourceLocation(References.PREFIX + "block_invar"))

If you want to use your enum naming change "block_invar" to Reference.ImageSpawnerEnum.IMAGESPAWNER.getRegistryName()

But i think that enum thing is just overkill in my opinion

Edited by winnetrie
Link to comment
Share on other sites

10 hours ago, DavidM said:

Your enum is over complicating the process of setting names.

Also, define “don’t work”. What is the name currently like?

The enum was suggested in a tutorial, so I just followed that since I'm new to modding.  

Currently, it says item.imagespawner:imagespawner.name

 

Quote

 

A good practice is to set the unlocalized name to the registry name to avoid conflicts, since the registry name contains the mod id.


this.setUnlocalizedName(this.getRegistryName().toString());

 

So instead of:  

 setUnlocalizedName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getUnlocalizedName());
 setRegistryName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getRegistryName());

I would do:  

setRegistryName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getRegistryName());
setUnlocalizedName(this.getRegistryName().toString());

?

Link to comment
Share on other sites

3 minutes ago, Kekz said:

I would do:  


setRegistryName(Reference.ImageSpawnerEnum.IMAGESPAWNER.getRegistryName());
setUnlocalizedName(this.getRegistryName().toString());

?

I tried this and now the item is called item.imagespawner:imagespawner:imagespawner.name

Link to comment
Share on other sites

I also have these methods, from the tutorial in my ImageSpawnerItem.java class. Maybe these are causing some problems?  

	@Override
	public String getUnlocalizedName() {
		
		return String.format("item.%s%s", Reference.MOD_ID.toLowerCase() + ":", getUnwrappedUnlocalizedName(super.getUnlocalizedName()));
		
	}
	
	@Override
	public String getUnlocalizedName(ItemStack itemStack) {
		return String.format("item.%s%s", Reference.MOD_ID.toLowerCase() + ":", getUnwrappedUnlocalizedName(super.getUnlocalizedName()));
	}
	
	protected String getUnwrappedUnlocalizedName(String unlocalizedName) {
		return unlocalizedName.substring(unlocalizedName.indexOf(".") + 1);
	}

 

Edit:

I deleted these methods, Item still shows up as: item.imagespawner:imagespawner.name

Edited by Kekz
Link to comment
Share on other sites

26 minutes ago, Kekz said:

I deleted these methods, Item still shows up as: item.imagespawner:imagespawner.name

That is what you want.

Now you should change the translation line in your .lang file into something like:

item.imagespawner:imagespawner.name=Image Spawner

Also, it seems like you are following a rather bad tutorial that writes unnecessary and pointless code. I would suggest ditching it.

  • Thanks 1

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

4 minutes ago, DavidM said:

Also, it seems like you are following a rather bad tutorial that writes unnecessary and pointless code. I would suggest ditching it.

Yeah, that's what I did. I only needed it to learn how to implement a basic item but the tutorial is 2 years old so some stuff was outdated.  

 

I updated my lang file to: 

item.imagespawner:imagespawner.name=Image Spawner

This combined with renaming the file back to en_US.lang finally worked. Thanks!

Edited by Kekz
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • my bad, i shared a very old LOG, now must be the right one, im sorry.
    • Hello TileEntity, thanks for your help, is just that i do not have terraria mod installed, i can give you mi list of mods.   EpicFight-20.7.4.jar handcrafted-forge-1.20.1-3.0.6.jar resourcefullib-forge-1.20.1-2.1.25.jar thedragonlib-1.20.1-1.0.0.jar tameablebeasts-1.20.1-5.1.jar geckolib-forge-1.20.1-4.4.6.jar mythicmounts-20.1-7.4.2-forge.jar Patchouli-1.20.1-84-FORGE.jar morevillagers-forge-1.20.1-5.0.0.jar balm-forge-1.20.1-7.3.4-all.jar trashslot-forge-1.20-15.1.0.jar peacefulrecipes 1.20.jar ferritecore-6.0.1-forge.jar darkmining-forge-1.20.1-1.1.0.jar ParCool-1.20.1-3.2.1.2-R.jar minecolonies-1.20.1-1.1.563-RELEASE.jar towntalk-1.20.1-1.1.0.jar structurize-1.20.1-1.0.733-RELEASE.jar blockui-1.20.1-1.0.156-RELEASE.jar domum_ornamentum-1.20.1-1.0.186-RELEASE-universal.jar multipiston-1.20-1.2.43-RELEASE.jar svmm-1.20.1-1.3.0.3.jar InsaneLib-1.13.5-mc1.20.1.jar Satako-7.0.16-1.20.1.jar Bountiful-6.0.3+1.20.1-forge.jar Kambrik-6.1.1+1.20.1-forge.jar kotlinforforge-4.11.0-all.jar kubejs-forge-2001.6.5-build.7.jar rhino-forge-2001.2.2-build.18.jar superbosses-1.2.0-1.20.1.jar lootjs-forge-1.20.1-2.12.0.jar MobsPropertiesRandomness-4.10.8-mc1.20.1.jar Pehkui-3.8.2+1.20.1-forge.jar lostcities-1.20-7.1.8.jar yuushya-1.20.1-forge-2.1.1.jar architectury-9.2.14-forge.jar artifacts-forge-9.5.11.jar curios-forge-5.9.1+1.20.1.jar cloth-config-11.1.118-forge.jar mcdar-4.0.3.jar mcdw-9.0.4.jar mcda-5.0.2.jar Connector-1.0.0-beta.43+1.20.1.jar ConnectorExtras-1.10.1+1.20.1.jar fabric-api-0.92.2+1.11.8+1.20.1.jar immersive_armors-1.6.1+1.20.1-forge.jar cosmeticarmorreworked-1.20.1-v1a.jar K-Turrets-3.0.25-1.20.1.jar M'TEG-1.0.1-1.20.1.jar JustEnoughGuns-0.4.0-1.20.1.jar framework-forge-1.20.1-0.7.6.jar JustEnoughResources-1.20.1-1.4.0.247.jar modernfix-forge-5.18.1+mc1.20.1.jar corpse-forge-1.20.1-1.0.12.jar randombonemealflowers-1.20.1-4.5.jar collective-1.20.1-7.61.jar treeharvester-1.20.1-8.7.jar ImprovableSkills-1.20.1-20.1.8.jar HammerLib-1.20.1-20.1.30.jar easy_mob_farm_1.20.1-7.1.0.jar easy-piglins-forge-1.20.1-1.0.5.jar easy_villagers-1.20.1-1.0.17.jar the_bumblezone-7.4.5+1.20.1-forge.jar productivebees-1.20.1-12.5.3.jar XaerosWorldMap_1.38.8_Forge_1.20.jar Xaeros_Minimap_24.2.0_Forge_1.20.jar jei-1.20.1-forge-15.3.0.8.jar Rats-1.20.1-8.1.2.jar citadel-2.5.4-1.20.1.jar Animation_Overhaul-forge-1.20.x-1.3.1.jar Necronomicon-Forge-1.4.2.jar invtweaks-1.20.1-1.1.0.jar sophisticatedbackpacks-1.20.1-3.20.5.1044.jar sophisticatedcore-1.20.1-0.6.22.611.jar travelersbackpack-forge-1.20.1-9.1.14.jar BetterThirdPerson-Forge-1.20-1.9.0.jar  
    • ill be asleep by the time you respond so mention like a lot of thing to do so when i wake i can try them
    • it instantly crashes
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.