May 12, 20196 yr 15 minutes ago, superminerJG said: //What I do: I call the interface Modelable instead of IHasModel. This doesn't matter. IHasModel is STILL IHasModel regardless of what you call it. You are usingIHasModel still. 15 minutes ago, superminerJG said: //What he's suggesting (because all items have registerItemRenderer) Nope, I am suggesting this instead: ForgeRegistries.ITEMS.getValuesCollection().stream().filter(i -> i.getRegistryName().getResourceDomain().equals(VSBRegistryNames.MODID)).forEach(i -> ModelLoader.setCustomModelResourceLocation(i, 0, new ModelResourceLocation(i.getRegistryName(), "inventory"))); No proxy, no for loop, just an elegant one-line solution. If you need custom case models then an interface is acceptable and the code is modified slightly to something like that i -> i instanceof ISpecialModel ? ((ISpecialModel)i).registerModel() : ModelLoader.setCustomModelResourceLocation(...) 20 minutes ago, superminerJG said: //Making an item in ModItems No, dont ever do that. Don't ever use static initializers for registry entries. All registry entries must be instantinated in the appropriate registry event, otherwise your mod WILL break.
May 13, 20196 yr 9 hours ago, superminerJG said: //what forge lets you do: look at how long that is... public static final Item SECOND_ITEM = new Item().setUnlocalizedName("second_item").setRegistryName("second_item").setCreativeTab(CreativeTabs.MATERIALS); “Forge” doesn’t make you do that, you’re making yourself do that. That is the most basic way to do stuff. There are other ways like doing it in the constructor (don’t do this) or making a helper method. See these 2 gists IHasModel replacement (automated model registration): https://gist.github.com/Cadiboo/3f5cdb785affc069af2fa5fdf2d70358 Correct object registration & instantiation: https://gist.github.com/Cadiboo/b825d62fb46538e7b7b262c5612d62aa About Me Spoiler My Discord - Cadiboo#8887 My Website - Cadiboo.github.io My Mods - Cadiboo.github.io/projects My Tutorials - Cadiboo.github.io/tutorials Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support. When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible. Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.