Jump to content
Search In
  • More options...
Find results that contain...
Find results in...

[1.12.2] Custom Furnace Doin Weird Stuff


BerryHeyy
 Share

Recommended Posts

Hey,

 

I have a problem which I've been trying to solve for the past hour. I've made a custom furnace, a blast furnace, and it smelts 1 item (hematite) into 2 items (2 magnetite & slag) if the temperature is over 434. Everything is fine until you remove the items at the output, it all goes down hill after that. 

 

I've also rigged up some loggers to see what's inside the outputs array.

 

Testing results:

1 Hematite in the input, 1 coke in the fuel input: Everything seems to be working fine. Magnetite increases with 2 every cycle, and slag with 1. The output arrays show the correct numbers, 2xmagnetite 1xslag. But when I remove the items in the output slot. The loggers show 0xair 0xair and the cycles continue but no output items are being made. The same happens when I remove the input and put it back.

 

I really don't know whats causing this. Here's my code;

(Blast furnace tile entity)

package com.bonphy.chemicraft.block.tileentity;

import com.bonphy.chemicraft.ChemiCraft;
import com.bonphy.chemicraft.block.blocks.BlockBlastFurnace;
import com.bonphy.chemicraft.block.recipes.RecipeBlastFurnace;
import com.bonphy.chemicraft.init.ItemRef;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.*;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.ITickable;
import net.minecraft.util.text.ITextComponent;
import net.minecraft.util.text.TextComponentString;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.fml.common.registry.GameRegistry;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import net.minecraftforge.items.CapabilityItemHandler;
import net.minecraftforge.items.ItemStackHandler;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;

public class TileEntityBlastFurnace extends TileEntity implements ITickable {

    private ItemStackHandler handler = new ItemStackHandler(4);
    private String customName;
    private ItemStack[] outputs = null;

    private int burnTime;
    private int currentBurnTime;
    private int cookTime;
    private int totalCookTime = 200;
    private int temperature;
    private int maxTemperature = 1000;
    private Item currentlySmelting;

    Logger logger = LogManager.getLogger(ChemiCraft.MODID);

    @Override
    public boolean hasCapability(Capability<?> capability, EnumFacing facing)
    {
        if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return true;
        else return false;
    }

    @Override
    public <T> T getCapability(Capability<T> capability, EnumFacing facing)
    {
        if(capability == CapabilityItemHandler.ITEM_HANDLER_CAPABILITY) return (T) this.handler;
        return super.getCapability(capability, facing);
    }

    public boolean hasCustomName()
    {
        return this.customName != null && !this.customName.isEmpty();
    }

    public void setCustomName(String customName)
    {
        this.customName = customName;
    }

    @Override
    public ITextComponent getDisplayName()
    {
        return this.hasCustomName() ? new TextComponentString(this.customName) : new TextComponentTranslation("container.electrolyzer_block");
    }

    @Override
    public void readFromNBT(NBTTagCompound compound)
    {
        super.readFromNBT(compound);
        this.handler.deserializeNBT(compound.getCompoundTag("Inventory"));
        this.burnTime = compound.getInteger("BurnTime");
        this.cookTime = compound.getInteger("CookTime");
        this.totalCookTime = compound.getInteger("CookTimeTotal");
        this.temperature = compound.getInteger("temperature");
        this.currentBurnTime = getItemBurnTime((ItemStack)this.handler.getStackInSlot(2));

        if(compound.hasKey("CustomName", 8)) this.setCustomName(compound.getString("CustomName"));
    }

    @Override
    public NBTTagCompound writeToNBT(NBTTagCompound compound)
    {
        super.writeToNBT(compound);
        compound.setInteger("BurnTime", (short)this.burnTime);
        compound.setInteger("CookTime", (short)this.cookTime);
        compound.setInteger("CookTimeTotal", (short)this.totalCookTime);
        compound.setInteger("temperature", (short)this.temperature);
        compound.setTag("Inventory", this.handler.serializeNBT());

        if(this.hasCustomName()) compound.setString("CustomName", this.customName);
        return compound;
    }

    public boolean isBurning()
    {
        return this.burnTime > 0;
    }

    @SideOnly(Side.CLIENT)
    public static boolean isBurning(TileEntityBlastFurnace te)
    {
        return te.getField(0) > 0;
    }

    public void update()
    {

        boolean dirtyMark = false;

        if (handler.getStackInSlot(0).isEmpty()) {
            this.cookTime = 0;
            this.currentlySmelting = null;
            this.outputs = null;
            dirtyMark = true;
        }

        if(this.isBurning())
        {
            --this.currentBurnTime;
            if (this.temperature < this.maxTemperature) {
                this.temperature += 1;
            }
            BlockBlastFurnace.setState(true, world, pos);
        }

        if(!this.isBurning()) {
            if (this.temperature != 0) {
                this.temperature -= 3;
            }
        }

        ItemStack input = handler.getStackInSlot(0);
        ItemStack fuel = handler.getStackInSlot(1);

        if(this.isBurning() || !fuel.isEmpty())
        {
            if(!this.isBurning() && this.canSmelt())
            {
                this.burnTime = getItemBurnTime(fuel);
                this.currentBurnTime = burnTime;

                if(this.isBurning() && !fuel.isEmpty())
                {
                    dirtyMark = true;

                    Item item = fuel.getItem();
                    fuel.shrink(1);

                    if(fuel.isEmpty())
                    {
                        ItemStack item1 = item.getContainerItem(fuel);
                        this.handler.setStackInSlot(1, item1);
                    }
                }
            }
        }

        if(this.isBurning() && this.canSmelt() && cookTime > 0)
        {

            if (cookTime != totalCookTime) {
                cookTime++;
            }

            if(cookTime == totalCookTime)
            {

                if (this.currentlySmelting.equals(ItemRef.HEMATITE_ITEM) && this.temperature > 454) {
                    if(!handler.getStackInSlot(2).isEmpty() && !handler.getStackInSlot(3).isEmpty())
                    {
                        handler.getStackInSlot(2).grow(2);
                        handler.getStackInSlot(3).grow(1);
                        this.currentlySmelting = null;
                        outputs = null;
                        cookTime = 0;
                        input.shrink(1);
                        dirtyMark = true;
                    }
                    else
                    {
                        handler.insertItem(2, outputs[0], false);
                        handler.insertItem(3, outputs[1], false);

                        this.currentlySmelting = null;
                        outputs = null;
                        cookTime = 0;
                        input.shrink(1);
                        dirtyMark = true;
                    }
                }
            }
        }
        else
        {
            if(this.canSmelt() && this.isBurning())
            {
                ItemStack[] outputs = RecipeBlastFurnace.getInstance().getResults(input);
                if(outputs != null)
                {
                    this.outputs = null;
                    this.outputs = outputs;

                    logger.info(outputs[0] + "" + outputs[1]);
                    cookTime++;
                    this.currentlySmelting = input.getItem();
                    handler.setStackInSlot(0, input);
                    dirtyMark = true;
                }
            }
        }

        if(dirtyMark) {
            this.markDirty();
        }

    }

    private boolean canSmelt()
    {
        if((this.handler.getStackInSlot(0)).isEmpty()) return false;
        else
        {
            ItemStack[] results = RecipeBlastFurnace.getInstance().getResults(this.handler.getStackInSlot(0));
            if(results == null) return false;
            else
            {
                ItemStack[] outputs = new ItemStack[] {this.handler.getStackInSlot(2), this.handler.getStackInSlot(3)};
                if(outputs[0].isEmpty() && outputs[1].isEmpty()) return true;
                if(!outputs[0].isItemEqual(results[0]) && !outputs[1].isItemEqual(results[1])) return false;

                int res0 = outputs[0].getCount() + results[0].getCount();
                int res1 = outputs[1].getCount() + results[1].getCount();

                return res0 <= 64 && res0 <= outputs[0].getMaxStackSize() && res1 <= 64 && res1 <= outputs[1].getMaxStackSize();
            }
        }
    }

    public static int getItemBurnTime(ItemStack fuel)
    {
        if(fuel.isEmpty()) return 0;
        else
        {
            Item item = fuel.getItem();

            if (item == ItemRef.COKE_ITEM) return 2400;

            return GameRegistry.getFuelValue(fuel);
        }
    }

    public static boolean isItemFuel(ItemStack fuel)
    {
        return getItemBurnTime(fuel) > 0;
    }

    public boolean isUsableByPlayer(EntityPlayer player)
    {
        return this.world.getTileEntity(this.pos) != this ? false : player.getDistanceSq((double)this.pos.getX() + 0.5D, (double)this.pos.getY() + 0.5D, (double)this.pos.getZ() + 0.5D) <= 64.0D;
    }

    public int getField(int id)
    {
        switch(id)
        {
            case 0:
                return this.burnTime;
            case 1:
                return this.currentBurnTime;
            case 2:
                return this.cookTime;
            case 3:
                return this.totalCookTime;
            case 4:
                return this.temperature;
            case 5:
                return this.maxTemperature;
            default:
                return 0;
        }
    }

    public void setField(int id, int value)
    {
        switch(id)
        {
            case 0:
                this.burnTime = value;
                break;
            case 1:
                this.currentBurnTime = value;
                break;
            case 2:
                this.cookTime = value;
                break;
            case 3:
                this.totalCookTime = value;
                break;
            case 4:
                this.temperature = value;
                break;
        }
    }
}

 

(Recipes class for blast furnace)

package com.bonphy.chemicraft.block.recipes;

import com.bonphy.chemicraft.init.ItemRef;
import net.minecraft.item.ItemStack;

import java.util.HashMap;
import java.util.Map;

public class RecipeBlastFurnace {

    private static final RecipeBlastFurnace INSTANCE = new RecipeBlastFurnace();
    private final Map<ItemStack, ItemStack[]> recipesList = new HashMap<>();

    public static RecipeBlastFurnace getInstance()
    {
        return INSTANCE;
    }

    private RecipeBlastFurnace()
    {
        addSinteringRecipe(new ItemStack(ItemRef.HEMATITE_ITEM), new ItemStack(ItemRef.MAGNETITE_ITEM, 2), new ItemStack(ItemRef.SLAG_ITEM,1));
    }


    public void addSinteringRecipe(ItemStack input, ItemStack output1, ItemStack output2)
    {
        if(getResults(input) != null) return;
        this.recipesList.put(input, new ItemStack[]{output1, output2});
    }

    public ItemStack[] getResults(ItemStack input)
    {
        for(Map.Entry<ItemStack, ItemStack[]> entry : this.recipesList.entrySet())
        {
            if(this.compareItemStacks(input, entry.getKey()))
            {
                return entry.getValue();
            }
        }
        return null;
    }

    private boolean compareItemStacks(ItemStack stack1, ItemStack stack2)
    {
        return stack2.getItem() == stack1.getItem() && (stack2.getMetadata() == 32767 || stack2.getMetadata() == stack1.getMetadata());
    }

}

 

(Blast furnace GUI, still work in progress don't worry)

image.png.37a5259f5272f47dcbdc8d5c5a33a6df.png

 

 

 

Thanks for reading my question, and I would be thankful if you can help me.

-Berry

 

 

Link to comment
Share on other sites

I could swear that there was a thread a page back with somebody having this same issue.

In java everything is passed as a reference(kinda, it's a bit different but I won't complicate stuff). Thus when you get the item stacks from the results of your recipe and blindly put them in the output slot it is still THE SAME ITEM STACK that is stored in your recipe map. Any modifications to it apply to the stack in your recipe. 

 

Also some misc. issues:

11 minutes ago, BerryHeyy said:

return te.getField(0) > 0;

Don't use get/setField, that is a silly vanilla mechanic. Simply reference your fields directly.

 

12 minutes ago, BerryHeyy said:

BlockBlastFurnace.setState(true, world, pos);

I have a suspicion that you are doing the stupid invalidate/validate tileentity stuff there. Don't. Simply override TileEntity#shouldRefresh.

 

13 minutes ago, BerryHeyy said:

this.outputs = null; this.outputs = outputs;

Why? You are just wasting a CPU cycle at that point. Doesn't really matter, but still, why?

 

 

  • Like 1
Link to comment
Share on other sites

I get it, but what am I supposed to do? Clone the itemstack and then add the cloned stacks to my outputs?

 

10 minutes ago, V0idWa1k3r said:
20 minutes ago, BerryHeyy said:

this.outputs = null; this.outputs = outputs;

Why? You are just wasting a CPU cycle at that point. Doesn't really matter, but still, why?

This was just to test some things out to fix it. I thought something was adding the outputs up together, so I tried clearing it every time I got the outputs.

Link to comment
Share on other sites

Wow. That makes sense. Thanks a lot man.

 

if(this.canSmelt() && this.isBurning())
            {
                ItemStack[] outputs = RecipeBlastFurnace.getInstance().getResults(input).clone();
                if(outputs != null)
                {
                    this.outputs = new ItemStack[]{outputs[0].copy(), outputs[1].copy()};
                    cookTime++;
                    this.currentlySmelting = input.getItem();
                    handler.setStackInSlot(0, input);
                    dirtyMark = true;
                }
            }

I did this to fix it. There's probably a better solution to this. But this seems to be working fine.

 

Thanks again.

Link to comment
Share on other sites

3 hours ago, BerryHeyy said:

private final Map<ItemStack, ItemStack[]> recipesList = new HashMap<>();

ItemStack does not override hashcode and will not work as keys in a Map the way you are expecting it to.

 

As for the recipe, I would suggest creating a list of custom recipe entries and search through it with a method that checks if two ItemStacks are "equal".

private List<MyEntry>;

// Pseudocode.
MyEntry: (inputStack, outputStacks[])

 

Moreover, stop following HarryTalks' tutorials as his tutorials are outdated and promotes bad practices.He himself is new to programming, resulting in problematic code and cargo cult programming in his tutorial. 

Edited by DavidM

Some tips:

Spoiler

Modder Support:

Spoiler

1. Do not follow tutorials on YouTube, especially TechnoVision (previously called Loremaster) and HarryTalks, due to their promotion of bad practice and usage of outdated code.

2. Always post your code.

3. Never copy and paste code. You won't learn anything from doing that.

4. 

Quote

Programming via Eclipse's hotfixes will get you nowhere

5. Learn to use your IDE, especially the debugger.

6.

Quote

The "picture that's worth 1000 words" only works if there's an obvious problem or a freehand red circle around it.

Support & Bug Reports:

Spoiler

1. Read the EAQ before asking for help. Remember to provide the appropriate log(s).

2. Versions below 1.11 are no longer supported due to their age. Update to a modern version of Minecraft to receive support.

 

 

Link to comment
Share on other sites

8 minutes ago, DavidM said:

ItemStack does not override hashcode and will not work as keys in a Map the way you are expecting it to.

 

They... are not expecting it to work the way you are expecting them to expect it to work(my, that's a confusing sentence).

 

Look at their implementation:

public ItemStack[] getResults(ItemStack input)
    {
        for(Map.Entry<ItemStack, ItemStack[]> entry : this.recipesList.entrySet())
        {
            if(this.compareItemStacks(input, entry.getKey()))
            {
                return entry.getValue();
            }
        }
        return null;
    }

    private boolean compareItemStacks(ItemStack stack1, ItemStack stack2)
    {
        return stack2.getItem() == stack1.getItem() && (stack2.getMetadata() == 32767 || stack2.getMetadata() == stack1.getMetadata());
    }

I mean yeah, there are better structures than a Map here, sure, but they can change it later.

 

Edited by V0idWa1k3r
  • Haha 1
Link to comment
Share on other sites

On 5/7/2019 at 3:26 PM, BerryHeyy said:

ItemStack[] outputs = RecipeBlastFurnace.getInstance().getResults(input).clone();

if(outputs != null)

This is not going to work, for two reasons:

 

1) You're cloning an array, not the item stacks

2) You check for null *after* calling .clone() on it.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Oh, you are right, I totally missed them cloning the array.

They do clone the itemstacks from said array which is what made me miss this issue:

On 5/7/2019 at 11:26 PM, BerryHeyy said:

this.outputs = new ItemStack[]{outputs[0].copy(), outputs[1].copy()};

 

Link to comment
Share on other sites

1 hour ago, V0idWa1k3r said:

Oh, you are right, I totally missed them cloning the array.

Yeah I did that before cloning the itemstacks, but I soon realised I needed to copy the itemstacks, and forgot to remove the clone for the array. Whoops

 

On 5/8/2019 at 1:00 AM, DavidM said:

Moreover, stop following HarryTalks' tutorials

Hehe, he just got me on my feet to begin modding, as I already have past programming experience. I'll try to fix all these bad practices. Thanks for noting this one out.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share



  • Recently Browsing

    No registered users viewing this page.

  • Posts

    • so i watched this tutorial on youtube(https://www.youtube.com/watch?v=vZgYjHwKcHA&t=691s) for make sittable blocks and even if is a 1,12,2 tutorial video a kind of translated it to 1.16.5 code but is not working "correctly"; the SeatEntity spawns in MY position and not in the position of the chair, and it blocks me the mouse movement in Y, and i can't shift for exit the chair, i can break blocks but my hand is kind of freeze in time (https://imgur.com/a/6xoKrV5)   this is my code:  @SubscribeEvent public static void test(PlayerInteractEvent.RightClickBlock event) { PlayerEntity player = event.getPlayer(); if(player.getRidingEntity() != null) { return; } World world = event.getWorld(); BlockPos pos = event.getPos(); Vector3d vec = new Vector3d(pos.getX() + 0.5f,pos.getY(), pos.getZ() + 0.5f); double maxDistance = 4.5D; if((vec.x - player.getPosX()) * (vec.x - player.getPosX()) + (vec.y - player.getPosY()) * (vec.y - player.getPosY()) + (vec.z - player.getPosZ()) * (vec.z - player.getPosZ()) > maxDistance * maxDistance) { return; } BlockState state = world.getBlockState(pos); ItemStack mainStack = player.getHeldItemMainhand(); ItemStack offStack = player.getHeldItemOffhand(); if(!mainStack.isEmpty() || !offStack.isEmpty()) { return; } if(state.getBlock() instanceof StairsBlock) { //List<SeatStair> seats = world.getEntitiesWithinAABB(SeatStair.class, new AxisAlignedBB(pos,pos.add(1,1,1))); SeatStair seat = new SeatStair(EntityType.ARMOR_STAND,world,pos); world.addEntity(seat); player.startRiding(seat); } } public static class SeatStair extends Entity { public SeatStair(EntityType<QUESTIONMARK extends Entity> type, World world, BlockPos pos) { super(type,world); setPosition(pos.getX() + 0.5D,pos.getY() + 0.2D,pos.getZ() + 0.5D); } @Override protected void registerData() { } @Override public void tick() { super.tick(); BlockPos pos = getPosition(); if(!(getEntityWorld().getBlockState(pos).getBlock() instanceof StairsBlock)) { setDead(); return; } List<Entity> passengers = getPassengers(); if(passengers.isEmpty()) { setDead(); } for(Entity entity : passengers) { if(entity.isSneaking()) { setDead(); } } } @Override protected void readAdditional(CompoundNBT compound) { } @Override protected void writeAdditional(CompoundNBT compound) { } @Override public IPacket<QUESTIONMARK> createSpawnPacket() { return null; } }  
    • I keep getting the following error when I try to start up minecraft. Brief report: I already tried to uninstall forge and download it again, uninstall the mods and download others, I changed the version (before 1.17.1 to 1.18.1), I already deleted the phrase "forge-common.toml of type COMMON for modid forge" and even saving it magically returned to the report.  I also put the crash report here.
    • Hello, I'm trying to make a forge server for me and a few friends to play on. Generally this goes over without too many problems but just recently when i was trying to make a new modpack the server wouldnt start, so I went through removing mods until I could find the error and as it turned out no mods were erroring, as just lone forge wouldnt start. the error I seem to be getting is "19.01 21:59:37 [Server] INFO ERROR StatusLogger Reconfiguration failed: No configuration found for '232204a1' at 'null' in 'null'" I have no idea what this means but after this the console wont send any messages other than "Auto-saving world..." after a couple minutes, and when out of curiosity I tried to join on a client it acted like the server was up but I could not join and there was no response console side from me trying to do so. It does recieve stop and start commands fine though. Thank you
    • Any help or advice would be appreciated. I'm trying to learn how to add particles to a mod, using a tutorial from TheGreyGhost. Trying to get the particle to appear in the Entity's tick() method. The vanilla FLAME particle appears but not my particle. @Override public void tick() { if(entity == null) return; try { // Adds a particle to every entity while in the overworld! //this.level.addParticle(ParticleTypes.FLAME, this.getX(), this.getY() + 1, this.getZ(), 0, 0.04, 0); // Try to add a custom particle to every entity in the overworld. Color tint = Color.CYAN; // does this do anything if the particle texture is already colored? double diameter = this.getEntityScale(); FlameParticleData flameParticleData = new FlameParticleData(tint, diameter); this.level.addParticle(flameParticleData, this.getX(), this.getY() + 2, this.getZ(), 0, 0.05, 0); } catch (Exception e) { The other code I have setting up the Particle Registration, the FlameParticle, the FlameParticleData, the FlameParticleFactory, and the FlameParticleType: ParticleRegistration.java. I also have a flame_particle.json that references the flame.png that I want to use. @Mod.EventBusSubscriber(modid = MyMod.MODID, bus = Bus.MOD, value = Dist.CLIENT) public class ParticleRegistration { public static final DeferredRegister<ParticleType<?>> PARTICLES_TYPES = DeferredRegister.create( ForgeRegistries.PARTICLE_TYPES, MyMod.MODID); // This sets the FlameParticleType to use the textures specified in flame_particle.json. public static final RegistryObject<ParticleType<FlameParticleData>> FLAME_PARTICLE = PARTICLES_TYPES.register( "flame_particle", FlameParticleType::new); // Is this necessary? public static ParticleType<FlameParticleData> flameParticleType = new FlameParticleType(); @SuppressWarnings("resource") @SubscribeEvent public static void registerParticleFactory(ParticleFactoryRegisterEvent event) { Minecraft.getInstance().particleEngine.register(ParticleRegistration.FLAME_PARTICLE.get(), FlameParticleFactory::new); } } FlameParticle.java /** * Based on TheGreyGhost's MinecraftByExample * Custom Particle to illustrate how to add a Particle with your own texture and movement/animation behaviour * */ public class FlameParticle extends SpriteTexturedParticle { /** * Construct a new FlameParticle at the given [x,y,z] position, with the given initial velocity, the given color, and the * given diameter. * We also supply sprites so that you can change the sprite texture in the tick() method (although not needed for this example) */ public FlameParticle(ClientWorld world, double x, double y, double z, double velocityX, double velocityY, double velocityZ, Color tint, double diameter, IAnimatedSprite sprites) { super(world, x, y, z, velocityX, velocityY, velocityZ); this.sprites = sprites; setColor(tint.getRed()/255.0F, tint.getGreen()/255.0F, tint.getBlue()/255.0F); setSize((float)diameter, (float)diameter); // the size (width, height) of the collision box. final float PARTICLE_SCALE_FOR_ONE_METRE = 0.5F; // if the particleScale is 0.5, the texture will be rendered as 1 metre high // sets the rendering size of the particle for a TexturedParticle. this.scale(PARTICLE_SCALE_FOR_ONE_METRE * (float)diameter); //maxAge = 100; // lifetime in ticks: 100 ticks = 5 seconds this.lifetime = 100; final float ALPHA_VALUE = 1.0F; this.alpha = ALPHA_VALUE; //the vanilla Particle constructor added random variation to our starting velocity. Undo it! this.xd = velocityX; this.yd = velocityY; this.zd = velocityZ; // the move() method will check for collisions with scenery this.hasPhysics = true; // I think hasPhysics replaces canCollide } // Comments from TheGreyGhost // ---- methods used by TexturedParticle.renderParticle() method to find out how to render your particle // the base method just renders a quad, rotated to directly face the player // can be used to change the skylight+blocklight brightness of the rendered Particle. @Override public int getLightColor(float partialTick) // previously protected int getBrightnessForRender(float partialTick) { final int BLOCK_LIGHT = 15; // maximum brightness final int SKY_LIGHT = 15; // maximum brightness final int FULL_BRIGHTNESS_VALUE = LightTexture.pack(BLOCK_LIGHT, SKY_LIGHT); // .pack replaces .packLight return FULL_BRIGHTNESS_VALUE; // if you want the brightness to be the local illumination (from block light and sky light) you can just use // the Particle.getBrightnessForRender() base method, which contains: // BlockPos blockPos = new BlockPos(this.posX, this.posY, this.posZ); // return this.world.isBlockLoaded(blockPos) ? WorldRenderer.getCombinedLight(this.world, blockPos) : 0; } // Choose the appropriate render type for your particles: // There are several useful predefined types: // PARTICLE_SHEET_TRANSLUCENT semi-transparent (translucent) particles // PARTICLE_SHEET_OPAQUE opaque particles // TERRAIN_SHEET particles drawn from block or item textures // PARTICLE_SHEET_LIT appears to be the same as OPAQUE. Not sure of the difference. In previous versions of minecraft, // "lit" particles changed brightness depending on world lighting i.e. block light + sky light public IParticleRenderType getRenderType() { return IParticleRenderType.PARTICLE_SHEET_TRANSLUCENT; } /** * call once per tick to update the Particle position, calculate collisions, remove when max lifetime is reached, etc */ @Override public void tick() { // if you want to change the texture as the particle gets older, you can use //setSpriteFromAge(sprites); // not sure whether this should be uncommented yet this.xo = x; // previously prevPosX and posX this.yo = y; // previously prevPosY and posY this.xo = z; // previously prevPosZ and posZ move(xd, yd, zd); // simple linear motion. You can change speed by changing xd, yd, // zd every tick. For example - you can make the particle accelerate downwards due to gravity by // final double GRAVITY_ACCELERATION_PER_TICK = -0.02; // yd += GRAVITY_ACCELERATION_PER_TICK; // calling move() also calculates collisions with other objects // collision with a block makes the ball disappear. But does not collide with entities if (onGround) { // onGround is only true if the particle collides while it is moving downwards... this.remove(); // this.setExpired() is probably this.remove() } if (yo == y && yd > 0) { // detect a collision while moving upwards (can't move up at all) this.remove(); } if (this.age++ >= this.lifetime) { // this.maxAge becomes this.lifetime this.remove(); } } private final IAnimatedSprite sprites; // contains a list of textures; choose one using either // newParticle.selectSpriteRandomly(sprites); or newParticle.selectSpriteWithAge(sprites); } FlameParticleData.java /** * Based on TheGreyGhost's MinecraftByExample * The particle has two pieces of information which are used to customise it: * * 1) The colour (tint) which is used to change the hue of the particle * 2) The diameter of the particle * * This class is used to * 1) store this information, and * 2) transmit it between server and client (write and read methods), and * 3) parse it from a command string i.e. the /particle params */ public class FlameParticleData implements IParticleData { public FlameParticleData(Color tint, double diameter) { this.tint = tint; this.diameter = constrainDiameterToValidRange(diameter); } public Color getTint() { return tint; } /** * @return get diameter of particle in metres */ public double getDiameter() { return diameter; } @Nonnull @Override public ParticleType<FlameParticleData> getType() { return ParticleRegistration.flameParticleType; } // write the particle information to a PacketBuffer, ready for transmission to a client @Override public void writeToNetwork(PacketBuffer buf) { buf.writeInt(tint.getRed()); buf.writeInt(tint.getGreen()); buf.writeInt(tint.getBlue()); buf.writeDouble(diameter); } // used for debugging I think; prints the data in human-readable format @Nonnull @Override public String writeToString() { return String.format(Locale.ROOT, "%s %.2f %i %i %i", this.getType().getRegistryName(), diameter, tint.getRed(), tint.getGreen(), tint.getBlue()); } private static double constrainDiameterToValidRange(double diameter) { final double MIN_DIAMETER = 0.05; final double MAX_DIAMETER = 1.0; return MathHelper.clamp(diameter, MIN_DIAMETER, MAX_DIAMETER); } private Color tint; private double diameter; // Comments from the TheGreyGhost // --------- these remaining methods are used to serialize the Particle Data. // I'm not yet sure what the Codec is used for, given that the DESERIALIZER already deserializes using read. // Perhaps it will be used to replace the manual read methods in the future. // The CODEC is a convenience to make it much easier to serialise and deserialise your objects. // Using the builder below, you construct a serialiser and deserialiser in one go, using lambda functions. // eg for the FlameParticleData CODEC: // a) In order to serialise it, it reads the 'tint' member variable (type: INT) and the 'diameter' member variable (type: DOUBLE) // b) In order to deserialise it, call the matching constructor FlameParticleData(INT, DOUBLE) public static final Codec<FlameParticleData> CODEC = RecordCodecBuilder.create( instance -> instance.group( Codec.INT.fieldOf("tint").forGetter(d -> d.tint.getRGB()), Codec.DOUBLE.fieldOf("diameter").forGetter(d -> d.diameter) ).apply(instance, FlameParticleData::new) ); private FlameParticleData(int tintRGB, double diameter) { this.tint = new Color(tintRGB); this.diameter = constrainDiameterToValidRange(diameter); } // The DESERIALIZER is used to construct FlameParticleData from either command line parameters or from a network packet public static final IDeserializer<FlameParticleData> DESERIALIZER = new IDeserializer<FlameParticleData>() { // parse the parameters for this particle from a /particle command @Nonnull @Override public FlameParticleData fromCommand(@Nonnull ParticleType<FlameParticleData> type, @Nonnull StringReader reader) throws CommandSyntaxException { reader.expect(' '); double diameter = constrainDiameterToValidRange(reader.readDouble()); final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; reader.expect(' '); int red = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int green = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); reader.expect(' '); int blue = MathHelper.clamp(reader.readInt(), MIN_COLOUR, MAX_COLOUR); Color color = new Color(red, green, blue); return new FlameParticleData(color, diameter); } // read the particle information from a PacketBuffer after the client has received it from the server @Override public FlameParticleData fromNetwork(@Nonnull ParticleType<FlameParticleData> type, PacketBuffer buf) { // warning! never trust the data read in from a packet buffer. final int MIN_COLOUR = 0; final int MAX_COLOUR = 255; int red = MathHelper.clamp(buf.readInt(), MIN_COLOUR, MAX_COLOUR); int green = MathHelper.clamp(buf.readInt(), MIN_COLOUR, MAX_COLOUR); int blue = MathHelper.clamp(buf.readInt(), MIN_COLOUR, MAX_COLOUR); Color color = new Color(red, green, blue); double diameter = constrainDiameterToValidRange(buf.readDouble()); return new FlameParticleData(color, diameter); } }; } FlameParticleFactory.java /** * Based on TheGreyGhost's MinecraftByExample * On the client side: * When the client wants to spawn a Particle, it gives the FlameParticleData to this factory method * The factory selects an appropriate Particle class and instantiates it * */ public class FlameParticleFactory implements IParticleFactory<FlameParticleData> { //IParticleFactory private final IAnimatedSprite sprites; // contains a list of textures; choose one using either // not sure if i still need this // newParticle.selectSpriteRandomly(sprites); or newParticle.selectSpriteWithAge(sprites); // this method is needed for proper registration of your Factory: // The ParticleManager.register method creates a Sprite and passes it to your factory for subsequent use when rendering, then // populates it with the textures from your textures/particle/xxx.json public FlameParticleFactory(IAnimatedSprite sprite) { this.sprites = sprite; } @Nullable @Override public Particle createParticle(FlameParticleData flameParticleData, ClientWorld world, double xPos, double yPos, double zPos, double xVelocity, double yVelocity, double zVelocity) { FlameParticle newParticle = new FlameParticle(world, xPos, yPos, zPos, xVelocity, yVelocity, zVelocity, flameParticleData.getTint(), flameParticleData.getDiameter(), sprites); newParticle.pickSprite(sprites); // not quite the newParticle.selectSpriteRandomly(sprites) that was used. return newParticle; } // This is private to prevent you accidentally registering the Factory using the default constructor. // ParticleManager has two register methods, and if you use the wrong one the game will enter an infinite loop private FlameParticleFactory() { throw new UnsupportedOperationException("Use the FlameParticleFactory(IAnimatedSprite sprite) constructor"); } } FlameParticleType.java /** * Based on TheGreyGhost's MinecraftByExample * Simple class used to describe the Particle */ public class FlameParticleType extends ParticleType<FlameParticleData> { private static boolean ALWAYS_SHOW_REGARDLESS_OF_DISTANCE_FROM_PLAYER = false; public FlameParticleType() { super(ALWAYS_SHOW_REGARDLESS_OF_DISTANCE_FROM_PLAYER, FlameParticleData.DESERIALIZER); } // get the Codec used to // a) convert a FlameParticleData to a serialised format // b) construct a FlameParticleData object from the serialised format public Codec<FlameParticleData> codec() { return FlameParticleData.CODEC; } } The flame_particle.json, which is located in resources/asset.MyMod/particles, that references the flame.png, located in resources/asset.MyMod/particles/textures/particles { "textures": [ "MyMod:flame" ] }  
    • How did you figure out the texture changing? I looked at your code and I can't seem to replicate your solution.
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Privacy Policy.