[1.12.2] How to remove potion from player delivered from block

[DinoPawz]

Hi,

Forge 

1.12.2-14.23.5.2768

I am trying to set and remove a potion from a block. Block does not have an update function, so I have implemented ITickable.

public class LeadBlock extends Block implements ITickable {

    private static Map<EntityPlayer, PotionEffect> potionEffects = new HashMap<>();

    LeadBlock(@Nonnull String name, @Nonnull MaterialVariant materialVariant) {
        super(Material.IRON);
        setRegistryName(Reference.MODID, name);
        setUnlocalizedName(Reference.MODID_PREFIX + name);
        setHarvestLevel("pickaxe", 2);
        setHardness(materialVariant.getHardness());
        setResistance(materialVariant.getResistance());
        setCreativeTab(Tab.METALS);
        setSoundType(SoundType.METAL);
        this.setDefaultState(this.blockState.getBaseState());
    }

    @Override
    public void onEntityCollidedWithBlock(@Nonnull World worldIn, BlockPos pos, IBlockState state, Entity entityIn) {
        if (worldIn.isRemote) {
            if (entityIn instanceof EntityPlayer) {
                EntityPlayer player = (EntityPlayer)entityIn;
                PotionEffect potionEffect = new PotionEffect(MobEffects.POISON, 300, 10, true, true);
                player.addPotionEffect(potionEffect);
                potionEffects.put(player, potionEffect);
            }
        }
        super.onEntityCollidedWithBlock(worldIn, pos, state, entityIn);
    }

    @Override
    public void onEntityWalk(@Nonnull World worldIn, BlockPos pos, Entity entityIn) {
        if (worldIn.isRemote) {
            if (entityIn instanceof EntityPlayer) {
                EntityPlayer player = (EntityPlayer)entityIn;
                PotionEffect potionEffect = new PotionEffect(MobEffects.POISON, 600, 20, true, true);
                player.addPotionEffect(potionEffect);
                potionEffects.put(player, potionEffect);
            }
        }
        super.onEntityWalk(worldIn, pos, entityIn);
    }

    @Override
    public void update() {
        OreberriesGalore.LOGGER.warn("In LeadBlock.update");
        if (!potionEffects.isEmpty()) {
            OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect map has an entry");
            for (Map.Entry<EntityPlayer, PotionEffect> entry : potionEffects.entrySet()) {
                EntityPlayer player = entry.getKey();
                if (player != null) {
                    OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect found player");
                    if (!player.isPotionActive(entry.getValue().getPotion())) {
                        OreberriesGalore.LOGGER.warn("In LeadBlock.update potionEffect about to remove potion effect from player");
                        player.removePotionEffect(entry.getValue().getPotion());
                        potionEffects.remove(entry.getKey(), entry.getValue());
                    }
                }
            }
        }
    }
}

The potion effect status bar gets activated correctly, and the potion effect counts down correctly, and the player's health hearts render green correctly. However, the player suffers no physical ill effects. And when the potion effect has finished, the status bars remain active until logging out, as do the player's health hearts remain green. The update function does not run as there is no output to the log file from this class.

Edited May 12, 2019 by DinoPawz

[DavidM]

10 minutes ago, DinoPawz said:

if (worldIn.isRemote) {

You probably want

if (!world.isRemote)

 

The latter executes the code on the server side.

Edited May 12, 2019 by DavidM

[DinoPawz]

doh, thank you

 

[V0idWa1k3r]

4 hours ago, DinoPawz said:

extends Block implements ITickable

No. ITickable isn't a magical interface that will deliver updates to everything you put it on. This will NOT work with a Block since the game won't iterate through ALL the blocks to deliver them the ticks.

ITickable is for entities and tileentities.