Jump to content

Recommended Posts

Posted

Hi all,

 

after quite some time away I finally got back to fixing a long-standing issue within my mod in progress. (See here)

 

I was advised to send the capability data to the server via a packet, and therefore set out to that. I came across this tutorial: https://wiki.mcjty.eu/modding/index.php?title=Networking-1.12 and used that to test out how packets work. The example function that was provided works flawlessly. However, when I tried to use another packet to update the needed data, I received a crash.

 

Here's the crash log.

 

And here are my relevant classes:

 

Event Subscriber

	@SideOnly(Side.CLIENT)
	@SubscribeEvent(priority=EventPriority.NORMAL, receiveCanceled=true)
	public static void onKeyInput(InputEvent.KeyInputEvent event)
	{
		System.out.println("Key Input Event");
		KeyBinding[] keyBindings = ClientProxy.keyBindings;

		// crashes
		if (keyBindings[KEY_TEST].isPressed())
		{
			System.out.println("Key binding =" + keyBindings[KEY_TEST].getKeyDescription());
			PacketHandler.INSTANCE.sendToServer(new PacketUpdateElement(BioElements.WATER));
		}

      	//Works fine
		if (keyBindings[KEY_GET_BLOCK].isPressed())
		{
			System.out.println("Key binding =" + keyBindings[KEY_GET_BLOCK].getKeyDescription());
			PacketHandler.INSTANCE.sendToServer(new PacketSendKey()); 
		}
	}

 

Packet

public class PacketUpdateElement implements IMessage
{
	private BioElements element;

	@Override
	public void fromBytes(ByteBuf buf)
	{
		try
		{
			byte[] bytes = new byte[buf.readableBytes()];
			buf.readBytes(bytes);
			element = BioElements.valueOf(new String(bytes));
		}
		catch (IllegalArgumentException e) // If no matching String is found in the enum, an IllegalArgumentException will be thrown
		{
			System.out.println("An error occurred: " + e.getMessage());
			element = BioElements.NONE;
			System.out.println("Element was set to NONE.");
		}
	}

	@Override
	public void toBytes(ByteBuf buf)
	{
		buf.writeBytes(element.name().getBytes());
	}

	public PacketUpdateElement(BioElements element)
	{
		this.element = element;
	}

	public static class Handler implements IMessageHandler<PacketUpdateElement, IMessage>
	{
		@Override
		public IMessage onMessage(PacketUpdateElement message, MessageContext context)
		{
			FMLCommonHandler.instance().getWorldThread(context.netHandler).addScheduledTask(() -> handle(message, context));
			return null;
		}

		private void handle(PacketUpdateElement message, MessageContext context)
		{
			EntityPlayerMP playerEntity = context.getServerHandler().player;

			if (playerEntity.hasCapability(CAPABILITY_BIO_PLAYER_DATA, null))
			{
				playerEntity.getCapability(CAPABILITY_BIO_PLAYER_DATA, null).setElement(message.element);
			}

			playerEntity.sendStatusMessage(new TextComponentString(TextFormatting.GREEN + "Selected element from packet: " + message.element.name()), false);
		}
	}
}

 

Packet handler

public class PacketHandler
{
	private static int packetId = 0;

	public static SimpleNetworkWrapper INSTANCE = null;

	public PacketHandler()
	{
	}

	public static int nextID()
	{
		return packetId++;
	}

	public static void registerMessages(String channelName)
	{
		INSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel(channelName);
		registerMessages();
	}

	public static void registerMessages()
	{
		// Register messages which are sent from the client to the server here:
		INSTANCE.registerMessage(PacketSendKey.Handler.class, PacketSendKey.class, nextID(), Side.SERVER);
		INSTANCE.registerMessage(PacketUpdateElement.Handler.class, PacketUpdateElement.class, nextID(), Side.SERVER);
	}
}

PacketHandler.registerMessages("biomod");  is fired in the FMLInitializationEvent event subscriber.

 

I tried figuring out the issue on my own, but had no luck so far.

Posted

Your packet class MUST have an explicitly defined parameterless constructor.

 

  On 5/21/2019 at 6:13 PM, Alekseyev said:

@SideOnly(Side.CLIENT)

Expand  

Don't abuse SideOnly, modders are not even meant to use it in the first place. If your event handlers are client-side only then only register them on the client.

 

Don't send a packet to the server every time a key is pressed regardless of anything. Perform the checks as to whether the client should even send the packet first, receive the packet on the server, perform your checks for whatever it is you need to do, etc. Don't spam the server with packets, but don't trust the client either.

 

  On 5/21/2019 at 6:13 PM, Alekseyev said:

byte[] bytes = new byte[buf.readableBytes()]; buf.readBytes(bytes); element = BioElements.valueOf(new String(bytes));

Expand  

Why are you doing this? Just store the ordinal as a byte or something in the buffer, then read the enum constant through said enum's array.

If you don't like this approach then you can have an index field in your enums and get it by the index. There is no reason to send a string.

Also if you ever do need to send a string use ByteBufUtils.

 

 

Posted
  On 5/21/2019 at 6:28 PM, V0idWa1k3r said:

Your packet class MUST have an explicitly defined parameterless constructor.

Expand  

How do I supply the info to the packet, then?

 

---------------------------------------------------

  On 5/21/2019 at 6:28 PM, V0idWa1k3r said:

Don't send a packet to the server every time a key is pressed regardless of anything. Perform the checks as to whether the client should even send the packet first, receive the packet on the server, perform your checks for whatever it is you need to do, etc. Don't spam the server with packets, but don't trust the client either.

Expand  

Thanks for the heads up, I will keep it in mind for the future. This particular case was just for easy testing anyway and will be removed afterwards.

  On 5/21/2019 at 6:28 PM, V0idWa1k3r said:

Why are you doing this? Just store the ordinal as a byte or something in the buffer, then read the enum constant through said enum's array.

If you don't like this approach then you can have an index field in your enums and get it by the index. There is no reason to send a string. 

Also if you ever do need to send a string use ByteBufUtils.

Expand  

I thought about simply using an ordinal and a single byte, since the amount of enum values will never exceed 256 anyway. I will look into fixing this as soon as the packet sending itself works.

Posted
  On 5/21/2019 at 6:33 PM, Alekseyev said:

How do I supply the info to the packet, then?

 

Expand  

I didn't say that it must ONLY have the parameterless constructor, i said that you must INCLUDE it. You can still keep your current constructor and use it just fine.

 

Also there are a ton of ways to pass data to an object without involving the constructor, like a setter for example. But this is basic java.

 

 

  • Thanks 1
Posted
  On 5/21/2019 at 6:34 PM, V0idWa1k3r said:

Also there are a ton of ways to pass data to an object without involving the constructor, like a setter for example. But this is basic java

Expand  

Sorry, sometimes I'm dumb. I was assuming that if there has to be a parameterless constructor, that one would be used in the sending process somehow and you would be unable to use your pre-created object.

 

I would dare to say that I know basic java pretty well, it's using someone else's hooks and libraries and whatnot (in this case Forge) what gets me all the time. :s

Posted
  On 5/21/2019 at 6:37 PM, Alekseyev said:

Sorry, sometimes I'm dumb. I was assuming that if there has to be a parameterless constructor, that one would be used in the sending process somehow and you would be unable to use your pre-created object.

Expand  

Server creates the packet by calling new YourPacket(some, params), right?

 

What do you think the client does, it doesn't know what some, params are, but it still needs to create the packet instance so that it can take the buffer it does have and pipe it through fromBytes(buf). And the only way that even makes sense is to call a parameterless constructor.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted
  On 5/21/2019 at 9:46 PM, Draco18s said:

And the only way that even makes sense is to call a parameterless constructor.

Expand  

A factory would be nicer if vanilla did it that way

About Me

  Reveal hidden contents

Versions below 1.14.4 are no longer supported on this forum. Use the latest version to receive support.

When asking support remember to include all relevant log files (logs are found in .minecraft/logs/), code if applicable and screenshots if possible.

Only download mods from trusted sites like CurseForge (minecraft.curseforge.com). A list of bad sites can be found here, with more information available at stopmodreposts.org

Edit your own signature at www.minecraftforge.net/forum/settings/signature/ (Make sure to check its compatibility with the Dark Theme)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It all began when I made what I thought was a smart move, investing a significant sum in a promising new cryptocurrency project. The marketing was slick, the whitepaper looked solid, and the hype was massive. But just a few weeks in, I started noticing red flags. The platform went down intermittently, withdrawals were delayed, and eventually, the website vanished altogether. I realized too late: I had fallen victim to a sophisticated crypto scam. Devastated and angry, I felt completely helpless. The blockchain is supposed to be secure and transparent, but tracing stolen assets through multiple wallets, mixers, and decentralized exchanges felt like chasing shadows. I reported it to local authorities, but they admitted they had limited tools for handling crypto-based crimes. That’s when a close friend recommended Alpha Spy Nest Forensic Digital Recovery Experts. Skeptical but desperate, I reached out. From the very first consultation, their professionalism stood out. They didn’t promise miracles, but they laid out a realistic recovery plan. Their team of cyber forensics specialists, blockchain analysts, and legal advisors worked together seamlessly. They began by tracing the movement of my funds through a series of blockchain addresses, even identifying key mixing points and suspicious wallet activity. I was amazed by the level of detail they could extract.Over the following weeks, Alpha Spy Nest liaised with major exchanges and digital compliance bodies, submitting detailed forensic reports. With their guidance, several suspicious wallets were flagged, frozen, and ultimately, a substantial portion of my lost funds was recovered and returned. I never thought recovery was even possible. But thanks to Alpha Spy Nest, not only did I regain a large part of my investment, I also restored some peace of mind. They didn’t just recover funds, they gave me back hope in a world where digital crime seemed untouchable. 
    • Looking to save big on your first international money transfer? Use the Lemfi coupon code 10% Cashback Up To $50 On First Transfer and enjoy instant cashback rewards on your first transaction. Our exclusive RITEQH6J Lemfi coupon code is designed to maximize your savings across the globe. Whether you're in the USA, Canada, UK, or elsewhere, this code unlocks premium benefits for you. With the Lemfi discount code $10 off and Lemfi code 10% Cashback Up To $50 On First Transfer, you’re not just sending money—you’re earning while doing it. Let’s dive into all the ways you can make the most of this offer. What Is The Lemfi Promo Code for 10% Cashback Up To $50 On First Transfer? Both new and existing users can benefit significantly by applying our Lemfi coupon 10% Cashback Up To $50 On First Transfer on the Lemfi app or website. This offer is part of Lemfi’s initiative to provide more value to its global users with every money transfer. 10% Cashback Up To $50 On First Transfer Lemfi coupon is your gateway to saving more, whether you're new or already using the app. Here's what you get with the promo code RITEQH6J: RITEQH6J – Flat 10% Cashback Up To $50 On First Transfer RITEQH6J – 10% Cashback Up To $50 On First Transfer coupon pack for multiple uses RITEQH6J – 10% Cashback Up To $50 On First Transfer flat discount for new customers RITEQH6J – Extra 10% Cashback Up To $50 On First Transfer promo code for existing customers Lemfi First Time Promo Code 10% Cashback Up To $50 On First Transfer For New Users In 2025 If you’re signing up for the first time in 2025, you’re in for an amazing treat. Using our Lemfi First Time Promo Code for 10% Cashback Up To $50 On First Transfer ensures maximum benefits on your first transaction. Here are some exciting perks of using RITEQH6J: RITEQH6J – $30 sign-up bonus to new users RITEQH6J – 10% cash back up to $50 on first transfer RITEQH6J – $20 cashback on recurring money transfers RITEQH6J – $30 bonus on $100 transfer RITEQH6J – Valid globally for all new Lemfi customers How To Redeem The Lemfi Coupon 10% Cashback Up To $50 On First Transfer For New Users? Using the Lemfi First Time Promo Code for 10% Cashback Up To $50 On First Transfer is super easy. Follow this simple guide: Download and install the Lemfi app from the App Store or Google Play. Sign up and create a new account. Go to the promo code section during your first transaction. Enter RITEQH6J to activate the Lemfi Promo Code First Order 10% Cashback Up To $50 On First Transfer. Complete the transaction to enjoy the Lemfi First Time Promo Code 10% Cashback Up To $50 On First Transfer for new users. Lemfi Promo Code 10% Cashback Up To $50 On First Transfer For Existing Customers Already a Lemfi user? You can still enjoy great benefits using our lemfi promo code 10% Cashback Up To $50 On First Transfer for existing users. Take advantage of the lemfi discount code 10% Cashback Up To $50 On First Transfer for existing customers by using the code RITEQH6J: RITEQH6J – $10 bonus for all users RITEQH6J – $20 per referral after 20 transactions RITEQH6J – $20 cashback on recurring money transfers RITEQH6J – $30 bonus on $100 transfer How To Use The Lemfi Code for 10% Cashback Up To $50 On First Transfer For Existing Customers? To redeem the Lemfi discount code for 10% Cashback Up To $50 On First Transfer, follow these steps: Open the Lemfi app and Lemfi login to your existing account. Go to the 'Promo Code' or 'Offers' section. Apply the Code promo Lemfi for 10% Cashback Up To $50 On First Transfer – RITEQH6J. Make your transaction and enjoy instant cashback rewards. Latest Lemfi Promo Code for 10% Cashback Up To $50 On First Transfer Stay ahead of the savings game by using our Lemfi first time promo code for 10% Cashback Up To $50 On First Transfer first order. It's the best way to unlock exclusive Lemfi offers. With the Lemfi discount code 10% Cashback Up To $50 On First Transfer and Lemfi cashback code, here’s what RITEQH6J brings: $30 sign-up bonus to new users 10% cashback up to $50 on first transfer $20 per referral after 20 transactions $20 cashback on recurring money transfers $30 bonus on $100 transfer How To Find The Lemfi Code for 10% Cashback Up To $50 On First Transfer? Finding the Lemfi code for 10% Cashback Up To $50 On First Transfer is easier than you think. You can get the Lemfi cashback code by subscribing to Lemfi’s newsletter for exclusive offers. Don’t forget to check out Lemfi referral code Reddit for 10% Cashback Up To $50 On First Transfer discussions and user-shared deals. Also, visit trusted coupon websites like ours for verified and regularly updated Lemfi promo codes. Is Lemfi 10% Cashback Up To $50 On First Transfer Code Legit? Absolutely! Wondering Is Lemfi legit?—Yes, it is. Our code promo Lemfi legit is fully tested and verified. The Lemfi discount code RITEQH6J is 100% authentic and can be used worldwide without restrictions. It's a secure, safe, and effective way to enjoy cashback on your transfers. How Does Lemfi Code for 10% Cashback Up To $50 On First Transfer Work? The 10% Cashback Up To $50 On First Transfer on first-time Lemfi money transfer works instantly once you apply the code RITEQH6J. After you enter the code during your transaction, Lemfi automatically applies the cashback. The Lemfi promo code for recurring transactions also allows users to benefit on future money transfers. Whether you're a new or existing user, the savings keep adding up with every use. How To Earn Lemfi 10% Cashback Up To $50 On First Transfer Coupons As A New Customer? To earn the Lemfi coupon code 10% Cashback Up To $50 On First Transfer, all you have to do is register on Lemfi with a valid email and phone number. After signing up, enter our code RITEQH6J during your first transfer. You can also look for 100 off Lemfi coupon code during Lemfi promotions. Keep an eye on your inbox and our site for fresh Lemfi offers every month. What Are The Advantages Of Using The Lemfi Discount Code for 10% Cashback Up To $50 On First Transfer? Using the Lemfi promo code for $10 bonus and Lemfi promo code for 10% Cashback Up To $50 On First Transfer offers many perks: $30 sign-up bonus to new users 10% cashback up to $50 on first transfer $20 per referral after 20 transactions $20 cashback on recurring money transfers $30 bonus on $100 transfer Lemfi Discount Code For 10% Cashback Up To $50 On First Transfer And Free Gift For New And Existing Customers With our Lemfi Discount Code for 10% Cashback Up To $50 On First Transfer, the bonuses don’t stop. Use the 10% Cashback Up To $50 On First Transfer Lemfi discount code and enjoy even more rewards. Here’s what RITEQH6J brings you: RITEQH6J – $30 sign-up bonus to new users RITEQH6J – 10% cashback up to $50 on first transfer RITEQH6J – $20 per referral after 20 transactions RITEQH6J – $20 cashback on recurring money transfers RITEQH6J – $30 bonus on $100 transfer Pros And Cons Of Using The Lemfi Discount Code 10% Cashback Up To $50 On First Transfer For Here are some pros and cons of the Lemfi 10% Cashback Up To $50 On First Transfer discount code and latest Lemfi code 10% cashback up to $50 on first transfer: Pros: Easy to apply and use Instant cashback on first transfer Valid for both new and existing users No expiration date Works globally Cons: Cashback capped at $50 May require minimum transfer amount Terms And Conditions Of Using The Lemfi Coupon 10% Cashback Up To $50 On First Transfer In 2025 To make the most of the Lemfi 10% Cashback Up To $50 On First Transfer code and latest Lemfi code 10% Cashback Up To $50 On First Transfer, keep these T&Cs in mind: Valid for both new and existing users Can be used worldwide No expiration date Requires use of code RITEQH6J during transaction Minimum transfer limit may apply Final Note: Use The Latest Lemfi Discount Code 10% Cashback Up To $50 On First Transfer To unlock your savings, don’t forget to use the Lemfi discount code for 10% Cashback Up To $50 On First Transfer. This code guarantees amazing benefits across various regions and transactions. With the Lemfi 10% Cashback Up To $50 On First Transfer code, you can enjoy worry-free money transfers and generous bonuses. Save more every time you send money! FAQs Of Lemfi 10% Cashback Up To $50 On First Transfer Code What is the best Lemfi promo code in 2025? The best Lemfi promo code for 2025 is RITEQH6J, offering 10% cashback up to $50 on your first transfer and other recurring rewards. Can I use the Lemfi code multiple times? Yes, you can use RITEQH6J for recurring benefits such as $20 cashback on future transfers and $30 bonuses on $100 sent. Is the Lemfi code valid in the USA and UK? Yes, the code is globally valid including in the USA, UK, Canada, and more. How do I enter the Lemfi promo code? Enter RITEQH6J in the promo section during your first transfer on the Lemfi app or website to activate your cashback offer. Does Lemfi have a referral bonus? Yes, Lemfi offers a $20 referral bonus after 20 successful transactions when your code is used by others
    • And the mods.toml?   Instead of using  modId="${mod_id}" try  modId="wackyweapons"
    • I've been working on Minecraft Forge 1.21 Modding, (I'm a bit inexperienced), and when trying to create my own custom throwable projectile entity, I come across this error I can't seem to fix. The console reads that my "mod not working due to Invalid bare key: '${mod_id}'  ". Does anyone know why this is happening? The Pastebin link for all the relevant files is https://pastebin.com/h3UaNYwn. Any help would be greatly appreciated. Thanks.
    • Found a similar post from 3 weeks ago as the only similar issue, seems specific to some linux distributions, like cachyos which i am using, due to libzng processing hashes differently? https://github.com/PrismLauncher/PrismLauncher/issues/3889
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.