Jump to content

Find and replace adjacent blocks


Yamahari

Recommended Posts

Hi, I added a new type of block "weeds" that should be able to spread to nearby crops. The block itself works fine, but I don't know how I should go about the spreading mechanic.

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            String registryName = blockState.getValue().getBlock().getRegistryName().toString();
            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

I tried something like that, but that doesn't seem to work. How do I find out what type of block is next to the ticked blocked and how do I replace blocks in the world? 

Edited by Yamahari
Link to comment
Share on other sites

35 minutes ago, Yamahari said:

            if(registryName.equals("wheat")
                    || registryName.equals("beetroots")
                    || registryName.equals("carrots")
                    || registryName.equals("potatoes")) {

Ok, so, two problems:

 

1) Comparing strings in order to identify blocks is The Worst idea. Blocks.WHEAT, Blocks.BEETROOTBlocks.CARROTS, and Blocks.POTATOES are a thing. Just check if(block == Blocks.WHEAT), etc.

2) This can't handle mod added crops of any kind, you should instance check if(block instanceof BlockCrops)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Link to comment
Share on other sites

Thanks for the feedback, it's been a long long time since I last touched modding x)

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

Can you help me with this: how do I get the age property from the block that may be replaced? 

 

Nvm i got it:

BlockCrops blockCrops = (BlockCrops) block;
if(blockState.getValue().get(blockCrops.getAgeProperty()) < blockCrops.getMaxAge()) {
	worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
}

 

Edited by Yamahari
Link to comment
Share on other sites

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
        super.tick(state, worldIn, pos, random);
        Map<BlockPos, IBlockState> blockStates = new HashMap();
        blockStates.put(pos.north(), worldIn.getBlockState(pos.north()));
        blockStates.put(pos.south(), worldIn.getBlockState(pos.south()));
        blockStates.put(pos.east(), worldIn.getBlockState(pos.east()));
        blockStates.put(pos.west(), worldIn.getBlockState(pos.west()));

        for(Map.Entry<BlockPos, IBlockState> blockState : blockStates.entrySet()) {
            Block block = blockState.getValue().getBlock();
            if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
                worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
            }
        }
    }

what is that

do it like so

public void tick(IBlockState state, World worldIn, BlockPos pos, Random random) {
		super.tick(state, worldIn, pos, random);
		for (EnumFacing facing : EnumFacing.HORIZONTALS){
			BlockPos offSet = pos.offset(facing);
			IBlockState blockState = worldIn.getBlockState(offSet);
			Block block = blockState.getBlock();
			if(block instanceof BlockCrops && block != BlockList.weeds && random.nextInt(4) == 0) {
				worldIn.setBlockState(blockState.getKey(), BlockList.weeds.getDefaultState());
			}
		}
	}

 

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • हथियार व्यापारियों की चमक आज के समय में भारत और दुनिया के विभिन्न हिस्सों में तेजी से बढ़ रही है। स्वीडन की स्थित संस्था सिपरी की नवीनतम रिपोर्ट के अनुसार, विश्व भर में विभिन्न देश अब पूर्व कभी नहीं देखे गए हथियारों और सैन्य सामग्रियों पर धन का व्यय कर रहे हैं। वैश्विक संघर्षों के बढ़ते संकेतों के कारण, विश्व के कई हिस्सों में युद्ध की संभावनाएं बढ़ रही हैं। पश्चिमी एशिया में युद्ध की आग फैल रही है, जबकि दक्षिण चीन सागर और ताइवान में भी तनाव बढ़ रहा है। भारत-चीन सीमा पर भी स्थिति चिंताजनक है। इन घटनाओं के परिणामस्वरूप, विभिन्न देशों की प्राथमिकताएं बदल रही हैं, और हथियार व्यापारियों का धंधा आजकल चमक उठा है। सिपरी की रिपोर्ट के अनुसार, 2023 में वैश्विक सैन्य खर्च एक नया रिकॉर्ड स्थापित किया गया है। 2022 की तुलना में, 2023 में सैन्य खर्च 6.8 फीसदी बढ़कर 24.4 ट्रिलियन डॉलर पर पहुंच गया। इसके पीछे कुछ विशेष कारण हैं, जिनमें दुनिया भर में तनाव बढ़ना और अद्यतित सैन्य तैयारियों की आवश्यकता शामिल है। इस वृद्धि में, भारत जैसे देशों का योगदान भी अधिक है। भारत ने भी अपने सैन्य खर्चों में वृद्धि की है, और यह दुनिया के सबसे बड़े और सबसे प्रभावशाली राष्ट्रों में एक बन गया है। इसके अलावा, अमेरिका, चीन, और रूस भी सैन्य खर्च में वृद्धि की हैं, जिससे विश्व सुरक्षा में नए दायरे खुले हैं। संभावनाओं के इस नए मंच पर, दुनिया के सक्षम देश अब अपने सैन्य तैयारियों में ज्यादा ध्यान दे रहे हैं। यह वृद्धि विकास और प्रगति के बजट पर भी प्रभाव डाल रही है, जिससे विभिन्न देशों के आर्थिक प्रगति में बदलाव आ सकता है।   https://www.nayaindia.com/editorial-column/editorial1/arms-sales-increased-in-the-world-454072.html
    • Hello, Hi and I am making a forge 1.12.2 mod and also trying to get a custom model helmet item (I made a joker mask) and exported it to .json format and put it in the ~/namespace/models/item folder. Though, I'm struggling to get the item to render what I want it to be rendered like as I've positioned it in the 'head' window view in blockbench. How did you render out your model? I checked your code and it looks like no references to the actual model are being made. I'm new to this forge modding stuff (was a fabric modder) and I desperately need some help. Is there a way to standardly render out armor models made using blockbench? any methods that one can use? My model in JSON: ```json { "credit": "Made with Blockbench", "texture_size": [160, 160], "textures": { "0": "ydyrn:items/joker_mask_texture", "particle": "ydyrn:items/joker_mask_texture" }, "elements": [ { "from": [0, 0, 0], "to": [16, 16, 1], "faces": { "north": {"uv": [0, 1.7, 16, 14.2], "texture": "#0"}, "east": {"uv": [0, 4, 0.9, 5.6], "texture": "#0"}, "south": {"uv": [0, 5.8, 1.6, 7.4], "texture": "#0"}, "west": {"uv": [0, 1.9, 1.3, 3.5], "texture": "#0"}, "up": {"uv": [0, 3.4, 1.6, 4.2], "texture": "#0"}, "down": {"uv": [0, 9, 1.6, 9.7], "texture": "#0"} } }, { "from": [15.8, 11, 0.5], "to": [16.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } }, { "from": [0.2, 11, 14.6], "to": [15.8, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"} } }, { "from": [-0.2, 11, 0.5], "to": [0.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "thirdperson_lefthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "firstperson_righthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "firstperson_lefthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "ground": { "rotation": [40, 0, 0], "translation": [0, -2.5, 0], "scale": [0.5, 0.5, 0.5] }, "gui": { "rotation": [0, 180, 0] }, "head": { "translation": [0, 0, 0.25], "scale": [0.82773, 0.73594, 0.9] }, "fixed": { "translation": [0, 0, 8.75] } }, "groups": [ 0, { "name": "straps", "origin": [0, 0, 0], "color": 0, "children": [1, 2, 3] } ] } ```
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • In your config folder, delete the sophisticatedcore-common.toml file and test it again
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.