[Solved] [1.13.2] Why is this code not working?

[Tameet]

I wrote this code, but test_item don't drops when i break a gravel with a stick in mainhand. What's wrong?

		if ((event.getState().getBlock() instanceof BlockGravel)) {
			if (event.getHarvester() != null) {
				ItemStack tool = event.getHarvester().getHeldItemMainhand();
				ItemStack item = new ItemStack(Items.STICK);
				if (tool == item) {
					event.getDrops().add(new ItemStack(ItemList.test_item, 1));
					event.setDropChance((float) 0.8);
				}
			}
		}

 

Edited June 1, 2019 by Tameet

[DavidM]

You've created two different instance of ItemStack. They don't double equal "==".

[TheOnlyTrueEnte]

Try this:

if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

[Tameet]

13 minutes ago, TheOnlyTrueEnte said:

Try this:

if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

Many thanks

[Yamahari]

In java "==" does mean something different than in other languages, "==" compares if both references reference the same instance, if you wanna compare if 2 objects are equal, you can use .equals() method or as provided by Forge a reference to the registered Item/Block in Items.<name of block>, Blocks.<name of block> ( note that as pointed out by @TheOnlyTrueEnte you can use == here because the getItem() method you're using returns a reference to some item in Items or your custom item list not a new instance of that item)

[DavidM]

3 hours ago, TheOnlyTrueEnte said:

Try this:

if ((event.getState().getBlock() instanceof BlockGravel)) {
	if (event.getHarvester() != null) {
		Item tool = event.getHarvester().getHeldItemMainhand().getItem();
		if (tool == Items.STICK) {
			event.getDrops().add(new ItemStack(ItemList.test_item, 1));
			event.setDropChance((float) 0.8);
		}
	}
}

 

Please do not post copy-pastable code like this. Others might copy it without learning anything.

[TheOnlyTrueEnte]

On 6/1/2019 at 2:56 PM, DavidM said:

Please do not post copy-pastable code like this. Others might copy it without learning anything.

Got it.