[1.13.2] ItemBlock help

[Simon_kungen]

Hi

 

How do I register ItemBlocks? I can register the actual block without problems but the item variant throws the error:

Quote

java.lang.NullPointerException: Can't use a null-name for the registry, object net.minecraft.item.ItemBlock@1468e880.

 

 

[Simon_kungen]

5 hours ago, diesieben07 said:

Show your code.

 

RegistrationHandler.java

Spoiler

public class RegistrationHandler {

    protected static final List<Block> blocks = new LinkedList<>();
    protected static final List<Item> items = new LinkedList<>();
    protected static final List<ItemBlock> itemBlocks = new LinkedList<>();
    protected static final List<Potion> potions = new LinkedList<>();

    public static void register(final RegistryEvent.Register event)
    {
        Type generic = event.getGenericType();

        if (generic == Block.class || generic == ItemBlock.class) {
            registerBlocks(event);
            registerItemBlocks(event);
        } else if (generic == Item.class) {
            registerItems(event);
        } else if (generic == Potion.class) {
            registerPotions(event);
        }

    }

    protected static void registerItemBlocks(final RegistryEvent.Register<Item> event)
    {
        itemBlocks.forEach(block -> event.getRegistry().register(block));
    }


    protected static void registerBlocks(final RegistryEvent.Register<Block> event)
    {
        IntercraftBlocks.register();
        blocks.forEach(block -> event.getRegistry().register(block));
    }

    protected static void registerItems(final RegistryEvent.Register<Item> event)
    {
        IntercraftItems.register();
        items.forEach(item -> event.getRegistry().register(item));
    }

    protected static void registerPotions(final RegistryEvent.Register event)
    {
        IntercraftPotions.register();
        potions.forEach(potion -> event.getRegistry().register(potion));
    }
}

 

 

 

IntercraftBlocks.java

Spoiler

public class IntercraftBlocks
{

    public static final Block CABLECASE;

    static {
        CABLECASE = new BlockCableCase();
    }

    public static void register()
    {
        registerBlock(CABLECASE, IntercraftItemGroups.WIRING);
    }

    protected static void registerBlock(Block block, ItemGroup group)
    {
        RegistrationHandler.blocks.add(block);
        Item item = new Item(new Item.Properties());

        RegistrationHandler.itemBlocks.add(new ItemBlock(block,new Item.Properties()));
    }

 

 

[Simon_kungen]

42 minutes ago, diesieben07 said:

Do not use the event like that. Make separate methods for RegistryEvent.Register<Block>, etc. RegistryEvent.Register<ItemBlock> is also not a thing. You register ItemBlocks like any other item: in RegistryEvent.Register<Item>.

 

You also must not create registry entries in static initializers. They must be created in a forge-controlled event, most appropriately the RegistryEvent.Register.

Ok, made it add the item block to the items list. But I'm still getting the error "Can't use a null-name for the registry":

 

Spoiler

 

 

RegistrationHandler.java

Spoiler

public class RegistrationHandler {

    protected static final List<Block> blocks = new LinkedList<>();
    protected static final List<Item> items = new LinkedList<>();
    protected static final List<Potion> potions = new LinkedList<>();

    public static void register(final RegistryEvent.Register event)
    {
        Type generic = event.getGenericType();

        if (generic == Block.class) {
            registerBlocks(event);
        } else if (generic == Item.class) {
            registerItems(event);
        } else if (generic == Potion.class) {
            registerPotions(event);
        }

    }



    protected static void registerBlocks(final RegistryEvent.Register<Block> event)
    {
        IntercraftBlocks.register();
        blocks.forEach(block -> event.getRegistry().register(block));
    }

    protected static void registerItems(final RegistryEvent.Register<Item> event)
    {
        IntercraftItems.register();
        items.forEach(item -> event.getRegistry().register(item));
    }

    protected static void registerPotions(final RegistryEvent.Register event)
    {
        IntercraftPotions.register();
        potions.forEach(potion -> event.getRegistry().register(potion));
    }
}

 

 

 

IntercraftBlocks.java

Spoiler

public class IntercraftBlocks
{

    public static final Block CABLECASE;

    static {
        CABLECASE = new BlockCableCase();
    }

    public static void register()
    {
        registerBlock(CABLECASE, IntercraftItemGroups.WIRING);
    }

    protected static void registerBlock(Block block, ItemGroup group)
    {
        RegistrationHandler.blocks.add(block);

        RegistrationHandler.items.add(new ItemBlock(block,new Item.Properties()));
    }
}

 

 

 

If I register it as a regular item and not as an ItemBlock it complains about me having two objects with the same name.