Get Block from String?

[Focamacho]

How can I get a block from a String?

 

Example:

String config = "minecraft:water;minecraft:grass;biomesoplenty:gem_block:7;ore:logWood";

 

I tried:

	public static List<ItemStack> getBlockConfig(String config) {
		System.out.println(config);
		List<ItemStack> allBlocks = new ArrayList<Integer>();
		String[] blockList = config.split(";");
		if(!(blockList.length <= 0)) {
			for(String block : blockList) {
				if(block.startsWith("ore:")) {
					String[] split = block.split(":");
					allBlocks.addAll(getBlockListFromOredict(split[1]));
				} else {
					String[] split = block.split(":");
					if(split.length > 2) {
						ItemStack blockItem = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]), 1, Integer.parseInt(split[2]));
						allBlocks.add(blockItem);
					} else if(split.length == 2){
						ItemStack blockItem = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]));
						allBlocks.add(blockItem);
					}
				}
			}
		}
		return allBlocks;
	}	

 

But for blocks like water & flowers, it returns Air.

Tried using blockstate, but it don't work with oredict, because crashs in logWood using .getStateFromMeta.

 

Crash:

Quote

Caused by: java.lang.IllegalArgumentException: Cannot set property PropertyEnum{name=variant, clazz=class net.minecraft.block.BlockPlanks$EnumType, values=[acacia, dark_oak]} to oak on block minecraft:log2, it is not an allowed value
    at net.minecraft.block.state.BlockStateContainer$StateImplementation.withProperty(BlockStateContainer.java:233)
    at net.minecraft.block.BlockNewLog.getStateFromMeta(BlockNewLog.java:74)
    at com.focamacho.mysticaladaptations.util.BlockCheck.getStateListFromOredict(BlockCheck.java:190)
    at com.focamacho.mysticaladaptations.util.BlockCheck.getBlockConfig(BlockCheck.java:168)
    at com.focamacho.mysticaladaptations.util.BlockCheck.<clinit>(BlockCheck.java:22)
    ... 48 more

I need a list of blocks defined in the configuration file, for comparison with a Right-Clicked block.

[Draco18s]

Well, there are two logs: "minecraft:log" and "minecraft:log2"

One of them is oak, spruce, jungle, and birch, the other is acacia and dark oak. You're trying to set log2 to oak, which is not an allowed variant.

[Focamacho]

How should I do it?

	public static List<IBlockState> getBlockListFromOredict(String ore) {
		List<IBlockState> oreBlocks = new ArrayList<IBlockState>();
		List<ItemStack> oreItems = OreDictionary.getOres(ore);
		for(ItemStack item : oreItems) {
			oreBlocks.add(Block.getBlockFromItem(item.getItem()).getStateFromMeta(item.getMetadata());
		}
		return oreBlocks;
	}

 

[Cadiboo]

Use the BlockStateArgument https://github.com/Cadiboo/NoCubes/blob/b15098ba9d7c7f082be1112a3ab9c7ac95370a02/src/main/java/io/github/cadiboo/nocubes/config/ConfigHelper.java#L261-L270 

[Focamacho]

There's no BlockStateArgument.

I'm using 1.12.2 - 14.23.5.2768

Edited June 26, 2019 by Focamacho

[Focamacho]

This code only crashs with ore:logWood 

	public static List<IBlockState> getBlockListFromOredict(String ore) {
		List<IBlockState> oreBlocks = new ArrayList<IBlockState>();
		List<ItemStack> oreItems = OreDictionary.getOres(ore);
		for(ItemStack item : oreItems) {
			oreBlocks.add(Block.getBlockFromItem(item.getItem()).getStateFromMeta(item.getMetadata());
		}
		return oreBlocks;
	}

[Focamacho]

I tried use ItemStacks, but a ItemStack from blocks like minecraft:water, always returns tile.air.

[Focamacho]

I'm trying to get a list of blocks from a configuration file, using a String:

water_seeds = config.get(category, "water_seeds", "minecraft:water").getString();
wood_seeds = config.get(category, "wood_seeds", "ore:logWood").getString();

 

BlockCheck.java

public static final List<ItemStack> Water = getBlockConfig(ModConfig.water_seeds);
public static final List<ItemStack> Wood = getBlockConfig(ModConfig.wood_seeds);
  
public static List<ItemStack> getBlockConfig(String config) {
		List<ItemStack> allBlocks = new ArrayList<ItemStack>();
		String[] blockList = config.split(";");
		if(!(blockList.length <= 0)) {
			for(String block : blockList) {
				if(block.startsWith("ore:")) {
					String[] split = block.split(":");
					allBlocks.addAll(getBlockListFromOredict(split[1]));
				} else {
					String[] split = block.split(":");
					if(split.length > 2) {
						ItemStack blockA = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]), 1, Integer.parseInt(split[2]));
						allBlocks.add(blockA);
					} else if(split.length == 2){
						ItemStack blockA = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]));
						allBlocks.add(blockA);
					}
				}
			}
		}
		return allBlocks;
	}
	
	public static List<ItemStack> getBlockListFromOredict(String ore) {
		List<ItemStack> oreItems = OreDictionary.getOres(ore);
		return oreItems;
	}

 

But, when I create a ItemStack from things like "minecraft:water" or "minecraft:lava" it returns a tile.air:

Quote

[12:25:10] [main/INFO] [STDOUT]: [com.focamacho.mysticaladaptations.util.BlockCheck:getBlockConfig:186]: minecraft:water itemstack: 1xtile.air@0

[12:25:10] [main/INFO] [STDOUT]: [com.focamacho.mysticaladaptations.util.BlockCheck:getBlockConfig:186]: minecraft:lava itemstack: 1xtile.air@0:

 

And I need use the List<ItemStack> to compare a right-clicked block with the blocks in the list.

SeedExtractor.java

	       	........
			ItemStack blockItem = iblockstate.getBlock().getPickBlock(iblockstate, raytraceresult, worldIn, pos, player);
	       	if(player.canPlayerEdit(pos, raytraceresult.sideHit, itemstack)) {
				if(checkBlockAndTier(itemstack, blockItem, BlockCheck.Wood, Type.WOOD)) seed = returnSeedItem(Type.WOOD);
				else if(checkBlockAndTier(itemstack, blockItem, BlockCheck.Water, Type.WATER)) seed = returnSeedItem(Type.WATER);
				else if(checkBlockAndTier(itemstack, blockItem, BlockCheck.Fire, Type.FIRE)) seed = returnSeedItem(Type.FIRE);
			........


	public boolean checkBlockAndTier(ItemStack extractor, ItemStack block, List<ItemStack> blockList, CropType.Type seed) {
		if(checkBlock(block, blockList) && verifyTier(seed, extractor) && seed.isEnabled()) return true;
		else return false;
	}
      
	public boolean checkBlock(ItemStack block, List<ItemStack> blockList) {
		if(blockList == null || blockList.isEmpty()) return false;
		else {
			for(ItemStack b : blockList) {
				if(OreDictionary.itemMatches(b, block, true)) {
					return true;
				}
			}
		}
		return false;
	}

 

to result in this:

 

 

Edited June 26, 2019 by Focamacho

[Alpvax]

What version are you using? Could you not use block tags instead of config values?

[Focamacho]

I'm using 1.12.2. I found a way to fix my problem, I don't know if it's the best way, but it works.

I create a new List<Block> for each seed, and get his values using:

	public static List<Block> getBlockConfig2(String config) {
		List<Block> allBlocks = new ArrayList<Block>();
		String[] blockList = config.split(";");
		if(!(blockList.length <= 0)) {
			for(String block : blockList) {
				if(block.startsWith("ore:")) {
					//nothing
				} else {
					String[] split = block.split(":");
					if(split.length > 2) {
						ItemStack blockA = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]), 1, Integer.parseInt(split[2]));
						if(blockA.getItem() == Items.AIR) {
							Block blockB = Block.getBlockFromName(split[0] + ":" + split[1]);
							if(blockB != null) {
								allBlocks.add(blockB);
							}
						}
					} else if(split.length == 2){
						ItemStack blockA = new ItemStack(Item.getByNameOrId(split[0] + ":" + split[1]));
						if(blockA.getItem() == Items.AIR) {
							Block blockB = Block.getBlockFromName(split[0] + ":" + split[1]);
							if(blockB != null) {
								allBlocks.add(blockB);
							}
						}
					}
				}
			}
		}
		return allBlocks;
	}

 

https://github.com/Focamacho/MysticalAdaptations/commit/f4f233d76ce057ba79b10379c571cc62cfe18522