[1.14.2] Step height change not removed when removing armor piece

[kwpugh]

Hi All,

 

I'm having some trouble with an armor class.   When the player remove the boots, the change in step height does not go away.   Is there a different way I should be implementing this or am I missing something important?

 

Any guidance would help.

 

Thank you.

 

package com.kwpugh.gobber2.items.armor;

import com.kwpugh.gobber2.lists.ItemList;
import com.kwpugh.gobber2.util.SpecialAbilities;

import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.inventory.EquipmentSlotType;
import net.minecraft.item.ArmorItem;
import net.minecraft.item.IArmorMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Effect;
import net.minecraft.world.World;

public class ItemCustomArmor extends ArmorItem
{
	public ItemCustomArmor(IArmorMaterial materialIn, EquipmentSlotType slots, Properties builder)
	{
		super(materialIn, slots, builder);
	}
	
	
	public void onArmorTick(final ItemStack stack, final World world, final PlayerEntity player)
	{
		if(player instanceof PlayerEntity)
		{	
			ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
			ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
			ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
		    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);	
		 
		    //Full Set

	    	if(head != null && head.getItem() == ItemList.gobber2_helmet && 
	    			chest != null && chest.getItem() == ItemList.gobber2_chestplate && 
	    			legs != null && legs.getItem() == ItemList.gobber2_leggings && 
	    			feet != null && feet.getItem() == ItemList.gobber2_boots)
	    	{
	    		((LivingEntity) player).removePotionEffect(Effect.get(19)); //Poison
	    	}	
		    
		    //Helmet
		    if(head.getItem() == ItemList.gobber2_helmet)
			{
				int newfoodlevel = 1;
				float newsatlevel = 0.0F;
				SpecialAbilities.giveRegenffect(world, player, stack, newfoodlevel, newsatlevel);			
			}
			else
			{
				
			}
		    
		    //Chestplate
		    if(chest.getItem() == ItemList.gobber2_chestplate)
			{
		 		if(player.isInWater())
		 		{
		 			SpecialAbilities.giveBreathing(world, player, chest);
		 		}
			}
		    
		    //Leggings
		    if(legs.getItem() == ItemList.gobber2_leggings)
			{
				player.fallDistance = 0.0F;
			}
			else
			{
				player.fallDistance = 1.0F;
			}	
		    
		    //Boots
		    if(feet.getItem() == ItemList.gobber2_boots)
			{
				player.stepHeight = 2.1F;
				
				if(!player.onGround)
				{
					//player.jumpMovementFactor += 0.09F;
				}
		    }
			else
		    {
				player.stepHeight = 0.0F;
		    }		 	
		}
	}
	
	@Override
	public boolean isBookEnchantable(ItemStack stack, ItemStack book)
	{
		return true;
	}

	@Override
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
	{
		return repair.getItem() == ItemList.gobber2_armor_repair;
	}
}

 

[kwpugh]

ok, I should use inventroyTick to remove?

 

From an educational perspective, why do potion effects stop when the armor piece is removed, but no step height?

 

 

[Draco18s]

30 minutes ago, kwpugh said:

if(head != null ...

ItemStacks can't be null.

[kwpugh]

So, this seems to work.   Is this a proper way to do it?

 

package com.kwpugh.gobber2.items.armor;

import com.kwpugh.gobber2.lists.ItemList;
import com.kwpugh.gobber2.util.SpecialAbilities;

import net.minecraft.entity.LivingEntity;
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.inventory.EquipmentSlotType;
import net.minecraft.item.ArmorItem;
import net.minecraft.item.IArmorMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.potion.Effects;
import net.minecraft.world.World;
import net.minecraftforge.registries.ForgeRegistries;

public class ItemCustomArmor extends ArmorItem
{
	public ItemCustomArmor(IArmorMaterial materialIn, EquipmentSlotType slots, Properties builder)
	{
		super(materialIn, slots, builder);
	}	
	
	public void onArmorTick(final ItemStack stack, final World world, final PlayerEntity player)
	{
		if(player instanceof PlayerEntity)
		{	
		    
			ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
			ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
			ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
		    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);
		    
		    //Full Set
	    	if(head.getItem() == ItemList.gobber2_helmet && 
	    			chest.getItem() == ItemList.gobber2_chestplate && 
	    			legs.getItem() == ItemList.gobber2_leggings && 
	    			feet.getItem() == ItemList.gobber2_boots)
	    	{
	    		((LivingEntity) ForgeRegistries.POTIONS).removePotionEffect(Effects.POISON);
	    	}	
		    
		    //Helmet
		    if(head.getItem() == ItemList.gobber2_helmet)
			{
				int newfoodlevel = 1;
				float newsatlevel = 0.0F;
				SpecialAbilities.giveRegenffect(world, player, stack, newfoodlevel, newsatlevel);			
			}
		    
		    //Chestplate
		    if(chest.getItem() == ItemList.gobber2_chestplate)
			{
		 		if(player.isInWater())
		 		{
		 			SpecialAbilities.giveBreathing(world, player, chest);
		 		}
			}
		    
		    //Leggings
		    if(legs.getItem() == ItemList.gobber2_leggings)
			{
				player.fallDistance = 0.0F;
			}	
		    
		    //Boots
		    if(feet.getItem() == ItemList.gobber2_boots)
			{
				player.stepHeight = 2.1F;
				
				if(!player.onGround)
				{
					//player.jumpMovementFactor += 0.09F;
				}
		    }		 	
		}
	}
	
	public void inventoryTick(ItemStack stack, World world, PlayerEntity player, int itemSlot, boolean isSelected)
	{			
		ItemStack head = player.getItemStackFromSlot(EquipmentSlotType.HEAD);
		ItemStack chest = player.getItemStackFromSlot(EquipmentSlotType.CHEST);
		ItemStack legs = player.getItemStackFromSlot(EquipmentSlotType.LEGS);
	    ItemStack feet = player.getItemStackFromSlot(EquipmentSlotType.FEET);
	    
		if(!(legs.getItem() == ItemList.gobber2_leggings))
		{
			player.fallDistance = 1.0F;
		}	
		
		if(!(feet.getItem() == ItemList.gobber2_boots))
		{
			player.stepHeight = 0.0F;
	    }		
	}
	
	@Override
	public boolean isBookEnchantable(ItemStack stack, ItemStack book)
	{
		return true;
	}

	@Override
	public boolean getIsRepairable(ItemStack toRepair, ItemStack repair)
	{
		return repair.getItem() == ItemList.gobber2_armor_repair;
	}
}

 

[kwpugh]

Ok, I figured it out, thank you for the pointers.