Hi

 

I have a block that needs to store a single int value. When breaking that block will drop n amount of items depending on that block's value.

 

public class BlockHardOre extends Block {

    private int meta = 4;

    public BlockHardOre(final String name, final float hardness, final float resistance) {
        super(Block.Properties.create(Material.ROCK).hardnessAndResistance(hardness,resistance));

        setRegistryName(name+"_ore");
    }

    
    public IItemProvider getItemDropped(IBlockState state, World worldIn, BlockPos pos, int fortune) {
        return Items.DIAMOND;
    }
    public int getItemsToDropCount(IBlockState state, int fortune, World worldIn, BlockPos pos, Random random) {
        return Math.max(this.meta,1);
    }
}

 

The value meta here is simply a placeholder when I was testing. The real meta value would derive from the stored value in the block.

 

The second would be to have the block's appearance be changed what that value is. Stone's texture as the background and then apply my texture on top of it just like how Potions' model works, the secondary texture would have to be coloured.

Blocks are singletons. This means that there is only one block instance in the entire game. To store stuff like this you need to use BlockStates and their properties (look at tallgrass for examples). Depending on what you want, you might be able to accomplish everything with the json model system. If not, you can use the IModelData system.

23 hours ago, Cadiboo said:

Blocks are singletons. This means that there is only one block instance in the entire game. To store stuff like this you need to use BlockStates and their properties (look at tallgrass for examples). Depending on what you want, you might be able to accomplish everything with the json model system. If not, you can use the IModelData system.

Alright. I managed to do the layer by making it into two models overlapping each other with the second layer being transparent. But I'm having some issues with Blockstates:

{
  "forge_marker": 1,
  "variants": {
    "density": {
      "0": {
        "model": "minecraft:block/stone"
      },
      "1": {
        "model": "intercraftcore:block/ore_faces/ore_0"
      },
      "2": {
        "model": "intercraftcore:block/ore_faces/ore_1"
      },
      "3": {
        "model": "intercraftcore:block/ore_faces/ore_2"
      },
      "4": {
        "model": "intercraftcore:block/ore_faces/ore_3"
      }
    }
  }
}

 

I would guess it should be like this, but when I try and spawn it into the world it says that property doesn't exist. I'm also having issues with setting the default blockstate when you place it into the world by hand, it should be in that case be variant 4.

Alright, not sure if the first one would work if I got this problem solved:

 

Seems like you have to add a property to the block class, so I tried that:

Spoiler

BlockHardOre.java

    public BlockHardOre(final String name, final float hardness, final float resistance) {
        super(Block.Properties.create(Material.ROCK, MaterialColor.STONE).hardnessAndResistance(hardness,resistance));

        setRegistryName(name+"_ore");
        setDefaultState(this.stateContainer.getBaseState().with(BlockProperties.DENSITY, 1));
    }

 

BlockProperties.java

public class BlockProperties {
    public static final IntegerProperty DENSITY = IntegerProperty.create("density",0,4);
}

 

 

 

But I run into the error:

Caused by: java.lang.IllegalArgumentException: Cannot set property IntegerProperty{name=density, clazz=class java.lang.Integer, values=[0, 1, 2, 3, 4]} as it does not exist in Block{minecraft:air}

So my guess is that I need to register this to the Block class. But I have no idea how to do that.

https://github.com/Draco18s/ReasonableRealism/blob/1.12.1/src/main/java/com/draco18s/ores/block/ore/BlockHardOreBase.java#L74-L77

8 hours ago, Simon_kungen said:

Block{minecraft:air}

Either you badly registered your block, or you're trying to set your property on an air block, not your block.

 

8 hours ago, Simon_kungen said:

setDefaultState(this.stateContainer.getBaseState().with(BlockProperties.DENSITY, 1));

do NOT do this. Override fillStateContainer

6 hours ago, Cadiboo said:

Either you badly registered your block, or you're trying to set your property on an air block, not your block.

 

do NOT do this. Override fillStateContainer

Ok, that worked. Can now place the block with the desired density. But it looks like it is still not changing the block model.

Spoiler

{
  "forge_marker": 1,
  "variants": {
    "density": {
      0: {
        "model": "minecraft:block/stone"
      },
      1: {
        "model": "intercraftcore:block/ore_faces/ore_0"
      },
      2: {
        "model": "intercraftcore:block/ore_faces/ore_1"
      },
      3: {
        "model": "intercraftcore:block/ore_faces/ore_2"
      },
      4: {
        "model": "intercraftcore:block/ore_faces/ore_3"
      }
    }
  }
}

 

 

 

Looks like it doesn't find the file. When I change the blockstate file the model works just fine.

Unable to load model: 'intercraftcore:block/block/ore_faces/ore_2' referenced from: intercraftcore:cu_ore#density=0: java.io.FileNotFoundException: intercraftcore:models/block/block/ore_faces/ore_2.json

 

Spot the difference between

"intercraftcore:models/block/block/ore_faces/ore_2.json" and
"intercraftcore:models/block/ore_faces/ore_2.json"

41 minutes ago, Cadiboo said:

Spot the difference between

"intercraftcore:models/block/block/ore_faces/ore_2.json" and
"intercraftcore:models/block/ore_faces/ore_2.json"

Oh wow. Thanks for spotting it! Works now.