[1.14.3] Game crashes whenever modded item is given to player.

[freelancepoliceman]

I'm new modding, so I've simply made a single block + item with no texture, following Mcjty's 1.14 tutorial. The game seems to load normally; however, when I use the /give command to give the item to the player, the game seems to crash. The crash log was quite unhelpful -- though I've attached it to this post, of course, it essentially just says "unexpected error occurred". Since the crash only occurs when the game has to interact with the item, I assume I've made some obvious and common mistake registering it, or else Eclipse or Gradle somehow aren't building Minecraft quite properly.

 

Here is what I think the relevant code might be:

 

Main mod class:

Spoiler

@Mod("coloredtorches")
public class ColoredTorches {
    public static final String modid = "coloredtorches";
    public static IProxy proxy = DistExecutor.runForDist(() -> () -> new ClientProxy(), () -> () -> new ServerProxy());
    public static ModSetup setup = new ModSetup();
    public ColoredTorches() {
        FMLJavaModLoadingContext.get().getModEventBus().addListener(this::setup);
    }

    private void setup(final FMLCommonSetupEvent event) {

    }
    @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD)
    public static class RegistryEvents {
        @SubscribeEvent
        public static void onBlocksRegistry(final RegistryEvent.Register<Block> event) {
             event.getRegistry().register(new FirstBlock());
        }

        @SubscribeEvent
        public static void onItemsRegistry(final RegistryEvent.Register<Item> event) {
             event.getRegistry().register(new BlockItem(ModBlocks.FIRSTBLOCK, new Item.Properties()).setRegistryName("firstblock"));         
        }
    }

}

 

FirstBlock.java

Spoiler

public class FirstBlock extends Block {

    public FirstBlock() {
        super(Properties.create(Material.IRON)
                .sound(SoundType.METAL)
                .hardnessAndResistance(2.0f)
                .lightValue(14)
        );
        setRegistryName("firstblock");
    }
}

 

ModBlocks.java

Spoiler

public class ModBlocks {
    @ObjectHolder("mytutorial:firstblock")
    public static FirstBlock FIRSTBLOCK;
}

 

Thank you kindly for any advice.

crash-2019-07-08_20.26.20-client.txt

Edited July 9, 2019 by freelancepoliceman

[Cadiboo]

instead of event.getRegistry().register(new BlockItem(ModBlocks.FIRSTBLOCK, new Item.Properties()).setRegistryName("firstblock")); use event.getRegistry().register(new BlockItem(ModBlocks.FIRSTBLOCK, new Item.Properties()).setRegistryName(ModBlocks.FIRSTBLOCK.getRegistryName()));

This eliminates the chance of getting the registry name wrong.

 

Change your ModBlocks class from

public class ModBlocks {
    @ObjectHolder("mytutorial:firstblock")
    public static FirstBlock FIRSTBLOCK;
}

to

@ObjectHolder(ColoredTorches.modid)
public class ModBlocks {
    public static final FirstBlock FIRSTBLOCK = null;
}

 

You're game is currently crashing because ModBlocks.FIRSTBLOCK is null. It is null because you've hardcoded the name of the block to "mytutorial:firstblock" when it should be "coloredtorches:firstblock". This means that the field never gets filled with your block, and you're item block tries to use a null block in getTranslationKey, causing a crash. Putting @ObjectHolder on your class with your modid means that you don't need to hardcode each name above each field, instead the name of the object is gotten with yourModId + ":" + nameOfField.

[Draco18s]

Quote

java.lang.NullPointerException: Unexpected error
    at net.minecraft.item.BlockItem.getTranslationKey(BlockItem.java:181) ~[forge-1.14.3-27.0.25_mapped_snapshot_20190621-1.14.2-recomp.jar:?] {}

https://stackoverflow.com/questions/218384/what-is-a-nullpointerexception-and-how-do-i-fix-it

[freelancepoliceman]

3 hours ago, Cadiboo said:

instead of event.getRegistry().register(new BlockItem(ModBlocks.FIRSTBLOCK, new Item.Properties()).setRegistryName("firstblock")); use event.getRegistry().register(new BlockItem(ModBlocks.FIRSTBLOCK, new Item.Properties()).setRegistryName(ModBlocks.FIRSTBLOCK.getRegistryName()));

This eliminates the chance of getting the registry name wrong.

 

Change your ModBlocks class from

public class ModBlocks {
    @ObjectHolder("mytutorial:firstblock")
    public static FirstBlock FIRSTBLOCK;
}

to

@ObjectHolder(ColoredTorches.modid)
public class ModBlocks {
    public static final FirstBlock FIRSTBLOCK = null;
}

 

You're game is currently crashing because ModBlocks.FIRSTBLOCK is null. It is null because you've hardcoded the name of the block to "mytutorial:firstblock" when it should be "coloredtorches:firstblock". This means that the field never gets filled with your block, and you're item block tries to use a null block in getTranslationKey, causing a crash. Putting @ObjectHolder on your class with your modid means that you don't need to hardcode each name above each field, instead the name of the object is gotten with yourModId + ":" + nameOfField.

 

Gah. I’m an idiot, and apparently can’t read. Thank you so much — and I’ll take your advice into account.

 

I noticed the harcoding too. I was trying to follow the tutorial I saw, which I imagine hardcoded to more clearly explain what was going on. I thought I could make the code more elegant if I could just get it to work, which, obviously, proved to my embarassment. I suppose I just copied and pasted code without being careful enough to change it. I apologize for being a moron. 

 

Thank you, again. 

Edited July 9, 2019 by freelancepoliceman