Jump to content

Recommended Posts

Posted (edited)

So I am having a couple of problems whilst trying to get started with Forge. I Downloaded and extracted a nightly MDK forge build and tried following instructions from docs.

 

  1.  `gradlew setupDecompWorkspace`does not appear to be a valid gradlew task.
  2. Having some issue with running gradle tasks from IntelliJ - wrong Java Version (I think i must have set import settings wrong) - I did manage to get it working on a previous try (reimport fixed this)
  3. I have no idea how to generate the API Java Docs so I can find my way around MC / MCForge and actually write code. Yes I tried gradle task Javadoc, but that just  generate docs for the example Mod

 

 

1) Console printscreen -  trying to run gradlew on a freshly unziped Forge mdk folder copy `forge-1.14.3-27.0.60-mdk.zip`:

D:\Code\Gamedev\MCMOD\forge_mdk60_Simple
λ set J
JAVA_HOME=C:\Program Files\Java\jdk1.8.0_211

D:\Code\Gamedev\MCMOD\forge_mdk60_Simple
λ gradlew setupDecompWorkspace
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.9/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
New Dep: net.minecraftforge:forge:1.14.3-27.0.60_mapped_snapshot_20190719-1.14.3

FAILURE: Build failed with an exception.

* What went wrong:
Task 'setupDecompWorkspace' not found in root project 'forge_mdk60_Simple'.

* Try:
Run gradlew tasks to get a list of available tasks. Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 5s

D:\Code\Gamedev\MCMOD\forge_mdk60_Simple
λ gradlew genIntellijRuns
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.9/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing

> Configure project :
New Dep: net.minecraftforge:forge:1.14.3-27.0.60_mapped_snapshot_20190719-1.14.3

Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/4.9/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 7s
4 actionable tasks: 4 executed
D:\Code\Gamedev\MCMOD\forge_mdk60_Simple
λ

 

2) See attached screen shot of IntelliJ - I had this issue before and then change IntellJ and my environment vars use Java 8 JDK, so I'm stupped as to why this is happening again. i.imgur.com/7N9OCFk.png

 

3) I am guessing `gradlew javadoc` would generate the docs if  `gradlew setupDecompWorkspace` existed/succeeded.

 

Any help would be much appreciated.

Edited by zv_odd
Posted

Ok I get that `setupDecompWorkspace ` is depreciated and removed. I have a working setup in IntelliJ - happy launches MC with forge + example mod loaded.

But I still have no idea how to generate MC / MCForge Java docs! Running the javadoc gradle task just creates docs for ExampleMod.

 

Can any one please point me to a tutorial on how to generate  API Docs for forge MC?

I'm really not great with the Java environment, but i do write a lot of code in other languages, and it seems flipping crazy that the topic of "how to get A readable API reference" is not the #1 first step after "setup your build environment".
 

Posted

You could run gradlew javadoc I suppose, but Forge being a framework rather than an API and Minecraft not being designed to be modded you're almost always going to find yourself using your IDE to browse through Minecraft and Forge to see how things are used and what they do.

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

  • 2 weeks later...
Posted (edited)

I absolutely tried running ` gradlew javadoc`, but as I said it only generated the docs for things declared in the ExampleMod package.

Do you know, are there some arguments that I can pass to it to change the scope of document generation?


As I'm really not that comfortable with the 2 main Java IDEs  (I mostly use Sublime or VIM), I was really hoping I could generate some searchable reference of all the main "packages"( modules,?) names and there classes, methods and their signatures, so I could easily search and browse for useful stuff whilst experimenting.

I'm not sure I really understand what you mean documentation can't be generated for a framework, it still has a collection of commented classes, methods, interfaces, etc.  Seems like going through that with an AST and grabbing comments + signatures is a large part of what Java Doc does? IDK seems strange that the layout of a codebase into a framework  ( i.e. rather than a complete main loop style application) should make much difference to that process.

 

I guess I just assumed that there would be some of the same tooling that IDE's like eclipse use to generate auto completion & etc, would have some standard way for generating a html version of those "mappings".

I have spent some time reading the forge code base on github - yeah that's an OK option, but there isn't a similar option for the decompiled Minecraft classes (obviously without comments) - which I also would also need to reference fairly regularly.

 


Also, partially this desire was promoted by this weird problem I'm having where some of the classes from ForgeMC (forge-1.14.3-27.0.57-mdk - could be a version specific issue?) didn't seem to exist,  specifically when I tried: 

import net.minecraftforge.common.config.Config;


I got a compiler error saying it couldn't find that class/package.

I was hoping to verify the package was actually there  via the generated docs.

Edited by zv_odd
clarify understanding
Posted

I totally understand what your saying, I just find it hard to believe there isn't a way ( that is already tooled and used by  mc modders) to generate/export list of class names + function sigs.

 

Quote

In my opinion it is not feasible to create Minecraft mods without always cross-referencing the vanilla and Forge code.


^ 100% agree!
 

Quote

You need an IDE for that.

5% agree -  It also makes plenty of sense for the collection of class names and signatures to be aggregated by some docgen tooling. Isn't that kinda one of the core purposes of JavaDoc?

Does anyone know how to generate that from the decompiled MC source and ForgeMC? 

Posted
3 hours ago, zv_odd said:

I totally understand what your saying, I just find it hard to believe there isn't a way ( that is already tooled and used by  mc modders) to generate/export list of class names + function sigs.

We all use an IDE. Which allows use to look through the source code. If I'm not mistaken a lot of the Minecraft source for 1.14 is still being made readable you know after obfuscation.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Posted

Exactly why do you need a dump of the class names and method sigs?

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I'm trying to setup a zombie apocalypse modpack with some fantasy elements but after a little bit of playing my game crashes with a log stating it crashed while "Rendering entity in world". It says it happened while rendering an ice and fire dragon but it has given me multiple different crashes each with different entities and mods as the suspected culprit.. I also know that sometimes Oculus and embeddium have problems but I can't find a single issue similar to mine. Crash log with dragon as cuplrit: https://mclo.gs/E8WfYGk Crash log with heavy machine gun as culprit: https://mclo.gs/bppMCne
    • Hello! Essentially I am trying to replicate something similar to the Endermans anger proc for looking at them to my mob LimeEntity. I want to make LimeEntity play the 'waveAnimation' file i made in blockbench whenever the player looks at him. I was trying to understand the Endermans code and having trouble. I just want to feel out if this would be an easy-ish task.  Here is my code on my Entity thus far, below all this code is the Enderman code. package net.jacobgari.sgslimemod.entity.custom; import net.jacobgari.sgslimemod.entity.ModEntities; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.level.ServerLevel; import net.minecraft.world.entity.*; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.ai.goal.*; import net.minecraft.world.entity.animal.Animal; import net.minecraft.world.entity.player.Player; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.item.crafting.Ingredient; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import org.jetbrains.annotations.Nullable; public class LimeEntity extends TamableAnimal { private static final EntityDataAccessor<Boolean> WAVING = SynchedEntityData.defineId(LimeEntity.class, EntityDataSerializers.BOOLEAN); public LimeEntity(EntityType<? extends Animal> pEntityType, Level pLevel) { super((EntityType<? extends TamableAnimal>) pEntityType, pLevel); } public final AnimationState idleAnimationState = new AnimationState(); private int idleAnimationTimeout = 0; public final AnimationState waveAnimationState = new AnimationState(); private int waveAnimationTimeout = 0; @Override public void tick() { super.tick(); if (this.level().isClientSide()) { setupAnimationStates(); } } private void setupAnimationStates() { if (this.idleAnimationTimeout <= 0) { this.idleAnimationTimeout = this.random.nextInt(40) + 80; this.idleAnimationState.start(this.tickCount); } else { --this.idleAnimationTimeout; } if (this.isWaving() && waveAnimationTimeout <= 0) { waveAnimationTimeout = 50; waveAnimationState.start(this.tickCount); } else { --this.waveAnimationTimeout; } if (!this.isWaving()) { waveAnimationState.stop(); } } @Override protected void updateWalkAnimation(float pPartialTick) { float f; if (this.getPose() == Pose.STANDING) { f = Math.min(pPartialTick * 6F, 1f); } else { f = 0f; } this.walkAnimation.update(f, 0.2f); } public void setWaving(boolean waving) { this.entityData.set(WAVING, waving); } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(WAVING, false); } public boolean isWaving() { return this.entityData.get(WAVING); } @Override protected void registerGoals() { this.goalSelector.addGoal(0, new FloatGoal(this)); this.goalSelector.addGoal(1, new LookAtPlayerGoal(this, Player.class, 8.0f)); this.goalSelector.addGoal(2, new TemptGoal(this, 1.15D, Ingredient.of(Items.SAND), false)); this.goalSelector.addGoal(3, new SitWhenOrderedToGoal(this)); this.goalSelector.addGoal(4, new FollowOwnerGoal(this, 1.0D, 10.0F, 2.0F, false)); this.goalSelector.addGoal(5, new FollowParentGoal(this, 1.1D)); this.goalSelector.addGoal(6, new BreedGoal(this, 1.15D)); this.goalSelector.addGoal(7, new WaterAvoidingRandomStrollGoal(this, 1.1D)); this.goalSelector.addGoal(8, new RandomLookAroundGoal(this)); } public static AttributeSupplier.Builder createAttributes() { return Animal.createLivingAttributes() .add(Attributes.MAX_HEALTH, 20D) .add(Attributes.FOLLOW_RANGE, 24D) .add(Attributes.MOVEMENT_SPEED, 0.3D) .add(Attributes.ATTACK_DAMAGE, 4f); } @Override public @Nullable AgeableMob getBreedOffspring(ServerLevel pLevel, AgeableMob pOtherParent) { return ModEntities.LIME.get().create(pLevel); } @Override public boolean isFood(ItemStack pStack) { return pStack.is(Items.SAND); } } package net.minecraft.world.entity.monster; import java.util.EnumSet; import java.util.List; import java.util.Optional; import java.util.UUID; import java.util.function.Predicate; import javax.annotation.Nullable; import net.minecraft.core.BlockPos; import net.minecraft.core.Direction; import net.minecraft.core.particles.ParticleTypes; import net.minecraft.core.registries.Registries; import net.minecraft.nbt.CompoundTag; import net.minecraft.nbt.NbtUtils; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.level.ServerLevel; import net.minecraft.sounds.SoundEvent; import net.minecraft.sounds.SoundEvents; import net.minecraft.tags.BlockTags; import net.minecraft.tags.DamageTypeTags; import net.minecraft.tags.FluidTags; import net.minecraft.util.Mth; import net.minecraft.util.RandomSource; import net.minecraft.util.TimeUtil; import net.minecraft.util.valueproviders.UniformInt; import net.minecraft.world.damagesource.DamageSource; import net.minecraft.world.effect.MobEffectInstance; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.EntityDimensions; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.LivingEntity; import net.minecraft.world.entity.NeutralMob; import net.minecraft.world.entity.Pose; import net.minecraft.world.entity.ai.attributes.AttributeInstance; import net.minecraft.world.entity.ai.attributes.AttributeModifier; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.ai.goal.FloatGoal; import net.minecraft.world.entity.ai.goal.Goal; import net.minecraft.world.entity.ai.goal.LookAtPlayerGoal; import net.minecraft.world.entity.ai.goal.MeleeAttackGoal; import net.minecraft.world.entity.ai.goal.RandomLookAroundGoal; import net.minecraft.world.entity.ai.goal.WaterAvoidingRandomStrollGoal; import net.minecraft.world.entity.ai.goal.target.HurtByTargetGoal; import net.minecraft.world.entity.ai.goal.target.NearestAttackableTargetGoal; import net.minecraft.world.entity.ai.goal.target.ResetUniversalAngerTargetGoal; import net.minecraft.world.entity.ai.targeting.TargetingConditions; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.projectile.ThrownPotion; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.item.alchemy.Potion; import net.minecraft.world.item.alchemy.PotionUtils; import net.minecraft.world.item.alchemy.Potions; import net.minecraft.world.item.enchantment.Enchantments; import net.minecraft.world.level.ClipContext; import net.minecraft.world.level.GameRules; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.block.Blocks; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.level.gameevent.GameEvent; import net.minecraft.world.level.pathfinder.BlockPathTypes; import net.minecraft.world.level.storage.loot.LootParams; import net.minecraft.world.level.storage.loot.parameters.LootContextParams; import net.minecraft.world.phys.AABB; import net.minecraft.world.phys.BlockHitResult; import net.minecraft.world.phys.Vec3; public class EnderMan extends Monster implements NeutralMob { private static final UUID SPEED_MODIFIER_ATTACKING_UUID = UUID.fromString("020E0DFB-87AE-4653-9556-831010E291A0"); private static final AttributeModifier SPEED_MODIFIER_ATTACKING = new AttributeModifier(SPEED_MODIFIER_ATTACKING_UUID, "Attacking speed boost", (double)0.15F, AttributeModifier.Operation.ADDITION); private static final int DELAY_BETWEEN_CREEPY_STARE_SOUND = 400; private static final int MIN_DEAGGRESSION_TIME = 600; private static final EntityDataAccessor<Optional<BlockState>> DATA_CARRY_STATE = SynchedEntityData.defineId(EnderMan.class, EntityDataSerializers.OPTIONAL_BLOCK_STATE); private static final EntityDataAccessor<Boolean> DATA_CREEPY = SynchedEntityData.defineId(EnderMan.class, EntityDataSerializers.BOOLEAN); private static final EntityDataAccessor<Boolean> DATA_STARED_AT = SynchedEntityData.defineId(EnderMan.class, EntityDataSerializers.BOOLEAN); private int lastStareSound = Integer.MIN_VALUE; private int targetChangeTime; private static final UniformInt PERSISTENT_ANGER_TIME = TimeUtil.rangeOfSeconds(20, 39); private int remainingPersistentAngerTime; @Nullable private UUID persistentAngerTarget; public EnderMan(EntityType<? extends EnderMan> pEntityType, Level pLevel) { super(pEntityType, pLevel); this.setMaxUpStep(1.0F); this.setPathfindingMalus(BlockPathTypes.WATER, -1.0F); } protected void registerGoals() { this.goalSelector.addGoal(0, new FloatGoal(this)); this.goalSelector.addGoal(1, new EnderMan.EndermanFreezeWhenLookedAt(this)); this.goalSelector.addGoal(2, new MeleeAttackGoal(this, 1.0D, false)); this.goalSelector.addGoal(7, new WaterAvoidingRandomStrollGoal(this, 1.0D, 0.0F)); this.goalSelector.addGoal(8, new LookAtPlayerGoal(this, Player.class, 8.0F)); this.goalSelector.addGoal(8, new RandomLookAroundGoal(this)); this.goalSelector.addGoal(10, new EnderMan.EndermanLeaveBlockGoal(this)); this.goalSelector.addGoal(11, new EnderMan.EndermanTakeBlockGoal(this)); this.targetSelector.addGoal(1, new EnderMan.EndermanLookForPlayerGoal(this, this::isAngryAt)); this.targetSelector.addGoal(2, new HurtByTargetGoal(this)); this.targetSelector.addGoal(3, new NearestAttackableTargetGoal<>(this, Endermite.class, true, false)); this.targetSelector.addGoal(4, new ResetUniversalAngerTargetGoal<>(this, false)); } public static AttributeSupplier.Builder createAttributes() { return Monster.createMonsterAttributes().add(Attributes.MAX_HEALTH, 40.0D).add(Attributes.MOVEMENT_SPEED, (double)0.3F).add(Attributes.ATTACK_DAMAGE, 7.0D).add(Attributes.FOLLOW_RANGE, 64.0D); } /** * Sets the active target the Goal system uses for tracking */ public void setTarget(@Nullable LivingEntity pLivingEntity) { AttributeInstance attributeinstance = this.getAttribute(Attributes.MOVEMENT_SPEED); if (pLivingEntity == null) { this.targetChangeTime = 0; this.entityData.set(DATA_CREEPY, false); this.entityData.set(DATA_STARED_AT, false); attributeinstance.removeModifier(SPEED_MODIFIER_ATTACKING); } else { this.targetChangeTime = this.tickCount; this.entityData.set(DATA_CREEPY, true); if (!attributeinstance.hasModifier(SPEED_MODIFIER_ATTACKING)) { attributeinstance.addTransientModifier(SPEED_MODIFIER_ATTACKING); } } super.setTarget(pLivingEntity); //Forge: Moved down to allow event handlers to write data manager values. } protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_CARRY_STATE, Optional.empty()); this.entityData.define(DATA_CREEPY, false); this.entityData.define(DATA_STARED_AT, false); } public void startPersistentAngerTimer() { this.setRemainingPersistentAngerTime(PERSISTENT_ANGER_TIME.sample(this.random)); } public void setRemainingPersistentAngerTime(int pTime) { this.remainingPersistentAngerTime = pTime; } public int getRemainingPersistentAngerTime() { return this.remainingPersistentAngerTime; } public void setPersistentAngerTarget(@Nullable UUID pTarget) { this.persistentAngerTarget = pTarget; } @Nullable public UUID getPersistentAngerTarget() { return this.persistentAngerTarget; } public void playStareSound() { if (this.tickCount >= this.lastStareSound + 400) { this.lastStareSound = this.tickCount; if (!this.isSilent()) { this.level().playLocalSound(this.getX(), this.getEyeY(), this.getZ(), SoundEvents.ENDERMAN_STARE, this.getSoundSource(), 2.5F, 1.0F, false); } } } public void onSyncedDataUpdated(EntityDataAccessor<?> pKey) { if (DATA_CREEPY.equals(pKey) && this.hasBeenStaredAt() && this.level().isClientSide) { this.playStareSound(); } super.onSyncedDataUpdated(pKey); } public void addAdditionalSaveData(CompoundTag pCompound) { super.addAdditionalSaveData(pCompound); BlockState blockstate = this.getCarriedBlock(); if (blockstate != null) { pCompound.put("carriedBlockState", NbtUtils.writeBlockState(blockstate)); } this.addPersistentAngerSaveData(pCompound); } /** * (abstract) Protected helper method to read subclass entity data from NBT. */ public void readAdditionalSaveData(CompoundTag pCompound) { super.readAdditionalSaveData(pCompound); BlockState blockstate = null; if (pCompound.contains("carriedBlockState", 10)) { blockstate = NbtUtils.readBlockState(this.level().holderLookup(Registries.BLOCK), pCompound.getCompound("carriedBlockState")); if (blockstate.isAir()) { blockstate = null; } } this.setCarriedBlock(blockstate); this.readPersistentAngerSaveData(this.level(), pCompound); } /** * Checks to see if this enderman should be attacking this player */ boolean isLookingAtMe(Player pPlayer) { ItemStack itemstack = pPlayer.getInventory().armor.get(3); if (net.minecraftforge.common.ForgeHooks.shouldSuppressEnderManAnger(this, pPlayer, itemstack)) { return false; } else { Vec3 vec3 = pPlayer.getViewVector(1.0F).normalize(); Vec3 vec31 = new Vec3(this.getX() - pPlayer.getX(), this.getEyeY() - pPlayer.getEyeY(), this.getZ() - pPlayer.getZ()); double d0 = vec31.length(); vec31 = vec31.normalize(); double d1 = vec3.dot(vec31); return d1 > 1.0D - 0.025D / d0 ? pPlayer.hasLineOfSight(this) : false; } } protected float getStandingEyeHeight(Pose pPose, EntityDimensions pSize) { return 2.55F; } /** * Called every tick so the entity can update its state as required. For example, zombies and skeletons use this to * react to sunlight and start to burn. */ public void aiStep() { if (this.level().isClientSide) { for(int i = 0; i < 2; ++i) { this.level().addParticle(ParticleTypes.PORTAL, this.getRandomX(0.5D), this.getRandomY() - 0.25D, this.getRandomZ(0.5D), (this.random.nextDouble() - 0.5D) * 2.0D, -this.random.nextDouble(), (this.random.nextDouble() - 0.5D) * 2.0D); } } this.jumping = false; if (!this.level().isClientSide) { this.updatePersistentAnger((ServerLevel)this.level(), true); } super.aiStep(); } public boolean isSensitiveToWater() { return true; } protected void customServerAiStep() { if (this.level().isDay() && this.tickCount >= this.targetChangeTime + 600) { float f = this.getLightLevelDependentMagicValue(); if (f > 0.5F && this.level().canSeeSky(this.blockPosition()) && this.random.nextFloat() * 30.0F < (f - 0.4F) * 2.0F) { this.setTarget((LivingEntity)null); this.teleport(); } } super.customServerAiStep(); } /** * Teleport the enderman to a random nearby position */ protected boolean teleport() { if (!this.level().isClientSide() && this.isAlive()) { double d0 = this.getX() + (this.random.nextDouble() - 0.5D) * 64.0D; double d1 = this.getY() + (double)(this.random.nextInt(64) - 32); double d2 = this.getZ() + (this.random.nextDouble() - 0.5D) * 64.0D; return this.teleport(d0, d1, d2); } else { return false; } } /** * Teleport the enderman to another entity */ boolean teleportTowards(Entity pTarget) { Vec3 vec3 = new Vec3(this.getX() - pTarget.getX(), this.getY(0.5D) - pTarget.getEyeY(), this.getZ() - pTarget.getZ()); vec3 = vec3.normalize(); double d0 = 16.0D; double d1 = this.getX() + (this.random.nextDouble() - 0.5D) * 8.0D - vec3.x * 16.0D; double d2 = this.getY() + (double)(this.random.nextInt(16) - 8) - vec3.y * 16.0D; double d3 = this.getZ() + (this.random.nextDouble() - 0.5D) * 8.0D - vec3.z * 16.0D; return this.teleport(d1, d2, d3); } /** * Teleport the enderman */ private boolean teleport(double pX, double pY, double pZ) { BlockPos.MutableBlockPos blockpos$mutableblockpos = new BlockPos.MutableBlockPos(pX, pY, pZ); while(blockpos$mutableblockpos.getY() > this.level().getMinBuildHeight() && !this.level().getBlockState(blockpos$mutableblockpos).blocksMotion()) { blockpos$mutableblockpos.move(Direction.DOWN); } BlockState blockstate = this.level().getBlockState(blockpos$mutableblockpos); boolean flag = blockstate.blocksMotion(); boolean flag1 = blockstate.getFluidState().is(FluidTags.WATER); if (flag && !flag1) { net.minecraftforge.event.entity.EntityTeleportEvent.EnderEntity event = net.minecraftforge.event.ForgeEventFactory.onEnderTeleport(this, pX, pY, pZ); if (event.isCanceled()) return false; Vec3 vec3 = this.position(); boolean flag2 = this.randomTeleport(event.getTargetX(), event.getTargetY(), event.getTargetZ(), true); if (flag2) { this.level().gameEvent(GameEvent.TELEPORT, vec3, GameEvent.Context.of(this)); if (!this.isSilent()) { this.level().playSound((Player)null, this.xo, this.yo, this.zo, SoundEvents.ENDERMAN_TELEPORT, this.getSoundSource(), 1.0F, 1.0F); this.playSound(SoundEvents.ENDERMAN_TELEPORT, 1.0F, 1.0F); } } return flag2; } else { return false; } } protected SoundEvent getAmbientSound() { return this.isCreepy() ? SoundEvents.ENDERMAN_SCREAM : SoundEvents.ENDERMAN_AMBIENT; } protected SoundEvent getHurtSound(DamageSource pDamageSource) { return SoundEvents.ENDERMAN_HURT; } protected SoundEvent getDeathSound() { return SoundEvents.ENDERMAN_DEATH; } protected void dropCustomDeathLoot(DamageSource pSource, int pLooting, boolean pRecentlyHit) { super.dropCustomDeathLoot(pSource, pLooting, pRecentlyHit); BlockState blockstate = this.getCarriedBlock(); if (blockstate != null) { ItemStack itemstack = new ItemStack(Items.DIAMOND_AXE); itemstack.enchant(Enchantments.SILK_TOUCH, 1); LootParams.Builder lootparams$builder = (new LootParams.Builder((ServerLevel)this.level())).withParameter(LootContextParams.ORIGIN, this.position()).withParameter(LootContextParams.TOOL, itemstack).withOptionalParameter(LootContextParams.THIS_ENTITY, this); for(ItemStack itemstack1 : blockstate.getDrops(lootparams$builder)) { this.spawnAtLocation(itemstack1); } } } public void setCarriedBlock(@Nullable BlockState pState) { this.entityData.set(DATA_CARRY_STATE, Optional.ofNullable(pState)); } @Nullable public BlockState getCarriedBlock() { return this.entityData.get(DATA_CARRY_STATE).orElse((BlockState)null); } /** * Called when the entity is attacked. */ public boolean hurt(DamageSource pSource, float pAmount) { if (this.isInvulnerableTo(pSource)) { return false; } else { boolean flag = pSource.getDirectEntity() instanceof ThrownPotion; if (!pSource.is(DamageTypeTags.IS_PROJECTILE) && !flag) { boolean flag2 = super.hurt(pSource, pAmount); if (!this.level().isClientSide() && !(pSource.getEntity() instanceof LivingEntity) && this.random.nextInt(10) != 0) { this.teleport(); } return flag2; } else { boolean flag1 = flag && this.hurtWithCleanWater(pSource, (ThrownPotion)pSource.getDirectEntity(), pAmount); for(int i = 0; i < 64; ++i) { if (this.teleport()) { return true; } } return flag1; } } } private boolean hurtWithCleanWater(DamageSource pSource, ThrownPotion pPotion, float pAmount) { ItemStack itemstack = pPotion.getItem(); Potion potion = PotionUtils.getPotion(itemstack); List<MobEffectInstance> list = PotionUtils.getMobEffects(itemstack); boolean flag = potion == Potions.WATER && list.isEmpty(); return flag ? super.hurt(pSource, pAmount) : false; } public boolean isCreepy() { return this.entityData.get(DATA_CREEPY); } public boolean hasBeenStaredAt() { return this.entityData.get(DATA_STARED_AT); } public void setBeingStaredAt() { this.entityData.set(DATA_STARED_AT, true); } public boolean requiresCustomPersistence() { return super.requiresCustomPersistence() || this.getCarriedBlock() != null; } static class EndermanFreezeWhenLookedAt extends Goal { private final EnderMan enderman; @Nullable private LivingEntity target; public EndermanFreezeWhenLookedAt(EnderMan pEnderman) { this.enderman = pEnderman; this.setFlags(EnumSet.of(Goal.Flag.JUMP, Goal.Flag.MOVE)); } /** * Returns whether execution should begin. You can also read and cache any state necessary for execution in this * method as well. */ public boolean canUse() { this.target = this.enderman.getTarget(); if (!(this.target instanceof Player)) { return false; } else { double d0 = this.target.distanceToSqr(this.enderman); return d0 > 256.0D ? false : this.enderman.isLookingAtMe((Player)this.target); } } /** * Execute a one shot task or start executing a continuous task */ public void start() { this.enderman.getNavigation().stop(); } /** * Keep ticking a continuous task that has already been started */ public void tick() { this.enderman.getLookControl().setLookAt(this.target.getX(), this.target.getEyeY(), this.target.getZ()); } } static class EndermanLeaveBlockGoal extends Goal { private final EnderMan enderman; public EndermanLeaveBlockGoal(EnderMan pEnderman) { this.enderman = pEnderman; } /** * Returns whether execution should begin. You can also read and cache any state necessary for execution in this * method as well. */ public boolean canUse() { if (this.enderman.getCarriedBlock() == null) { return false; } else if (!net.minecraftforge.event.ForgeEventFactory.getMobGriefingEvent(this.enderman.level(), this.enderman)) { return false; } else { return this.enderman.getRandom().nextInt(reducedTickDelay(2000)) == 0; } } /** * Keep ticking a continuous task that has already been started */ public void tick() { RandomSource randomsource = this.enderman.getRandom(); Level level = this.enderman.level(); int i = Mth.floor(this.enderman.getX() - 1.0D + randomsource.nextDouble() * 2.0D); int j = Mth.floor(this.enderman.getY() + randomsource.nextDouble() * 2.0D); int k = Mth.floor(this.enderman.getZ() - 1.0D + randomsource.nextDouble() * 2.0D); BlockPos blockpos = new BlockPos(i, j, k); BlockState blockstate = level.getBlockState(blockpos); BlockPos blockpos1 = blockpos.below(); BlockState blockstate1 = level.getBlockState(blockpos1); BlockState blockstate2 = this.enderman.getCarriedBlock(); if (blockstate2 != null) { blockstate2 = Block.updateFromNeighbourShapes(blockstate2, this.enderman.level(), blockpos); if (this.canPlaceBlock(level, blockpos, blockstate2, blockstate, blockstate1, blockpos1) && !net.minecraftforge.event.ForgeEventFactory.onBlockPlace(enderman, net.minecraftforge.common.util.BlockSnapshot.create(level.dimension(), level, blockpos1), net.minecraft.core.Direction.UP)) { level.setBlock(blockpos, blockstate2, 3); level.gameEvent(GameEvent.BLOCK_PLACE, blockpos, GameEvent.Context.of(this.enderman, blockstate2)); this.enderman.setCarriedBlock((BlockState)null); } } } private boolean canPlaceBlock(Level pLevel, BlockPos pDestinationPos, BlockState pCarriedState, BlockState pDestinationState, BlockState pBelowDestinationState, BlockPos pBelowDestinationPos) { return pDestinationState.isAir() && !pBelowDestinationState.isAir() && !pBelowDestinationState.is(Blocks.BEDROCK) && !pBelowDestinationState.is(net.minecraftforge.common.Tags.Blocks.ENDERMAN_PLACE_ON_BLACKLIST) && pBelowDestinationState.isCollisionShapeFullBlock(pLevel, pBelowDestinationPos) && pCarriedState.canSurvive(pLevel, pDestinationPos) && pLevel.getEntities(this.enderman, AABB.unitCubeFromLowerCorner(Vec3.atLowerCornerOf(pDestinationPos))).isEmpty(); } } static class EndermanLookForPlayerGoal extends NearestAttackableTargetGoal<Player> { private final EnderMan enderman; /** The player */ @Nullable private Player pendingTarget; private int aggroTime; private int teleportTime; private final TargetingConditions startAggroTargetConditions; private final TargetingConditions continueAggroTargetConditions = TargetingConditions.forCombat().ignoreLineOfSight(); private final Predicate<LivingEntity> isAngerInducing; public EndermanLookForPlayerGoal(EnderMan pEnderman, @Nullable Predicate<LivingEntity> pSelectionPredicate) { super(pEnderman, Player.class, 10, false, false, pSelectionPredicate); this.enderman = pEnderman; this.isAngerInducing = (p_269940_) -> { return (pEnderman.isLookingAtMe((Player)p_269940_) || pEnderman.isAngryAt(p_269940_)) && !pEnderman.hasIndirectPassenger(p_269940_); }; this.startAggroTargetConditions = TargetingConditions.forCombat().range(this.getFollowDistance()).selector(this.isAngerInducing); } /** * Returns whether execution should begin. You can also read and cache any state necessary for execution in this * method as well. */ public boolean canUse() { this.pendingTarget = this.enderman.level().getNearestPlayer(this.startAggroTargetConditions, this.enderman); return this.pendingTarget != null; } /** * Execute a one shot task or start executing a continuous task */ public void start() { this.aggroTime = this.adjustedTickDelay(5); this.teleportTime = 0; this.enderman.setBeingStaredAt(); } /** * Reset the task's internal state. Called when this task is interrupted by another one */ public void stop() { this.pendingTarget = null; super.stop(); } /** * Returns whether an in-progress EntityAIBase should continue executing */ public boolean canContinueToUse() { if (this.pendingTarget != null) { if (!this.isAngerInducing.test(this.pendingTarget)) { return false; } else { this.enderman.lookAt(this.pendingTarget, 10.0F, 10.0F); return true; } } else { if (this.target != null) { if (this.enderman.hasIndirectPassenger(this.target)) { return false; } if (this.continueAggroTargetConditions.test(this.enderman, this.target)) { return true; } } return super.canContinueToUse(); } } /** * Keep ticking a continuous task that has already been started */ public void tick() { if (this.enderman.getTarget() == null) { super.setTarget((LivingEntity)null); } if (this.pendingTarget != null) { if (--this.aggroTime <= 0) { this.target = this.pendingTarget; this.pendingTarget = null; super.start(); } } else { if (this.target != null && !this.enderman.isPassenger()) { if (this.enderman.isLookingAtMe((Player)this.target)) { if (this.target.distanceToSqr(this.enderman) < 16.0D) { this.enderman.teleport(); } this.teleportTime = 0; } else if (this.target.distanceToSqr(this.enderman) > 256.0D && this.teleportTime++ >= this.adjustedTickDelay(30) && this.enderman.teleportTowards(this.target)) { this.teleportTime = 0; } } super.tick(); } } } static class EndermanTakeBlockGoal extends Goal { private final EnderMan enderman; public EndermanTakeBlockGoal(EnderMan pEnderman) { this.enderman = pEnderman; } /** * Returns whether execution should begin. You can also read and cache any state necessary for execution in this * method as well. */ public boolean canUse() { if (this.enderman.getCarriedBlock() != null) { return false; } else if (!net.minecraftforge.event.ForgeEventFactory.getMobGriefingEvent(this.enderman.level(), this.enderman)) { return false; } else { return this.enderman.getRandom().nextInt(reducedTickDelay(20)) == 0; } } /** * Keep ticking a continuous task that has already been started */ public void tick() { RandomSource randomsource = this.enderman.getRandom(); Level level = this.enderman.level(); int i = Mth.floor(this.enderman.getX() - 2.0D + randomsource.nextDouble() * 4.0D); int j = Mth.floor(this.enderman.getY() + randomsource.nextDouble() * 3.0D); int k = Mth.floor(this.enderman.getZ() - 2.0D + randomsource.nextDouble() * 4.0D); BlockPos blockpos = new BlockPos(i, j, k); BlockState blockstate = level.getBlockState(blockpos); Vec3 vec3 = new Vec3((double)this.enderman.getBlockX() + 0.5D, (double)j + 0.5D, (double)this.enderman.getBlockZ() + 0.5D); Vec3 vec31 = new Vec3((double)i + 0.5D, (double)j + 0.5D, (double)k + 0.5D); BlockHitResult blockhitresult = level.clip(new ClipContext(vec3, vec31, ClipContext.Block.OUTLINE, ClipContext.Fluid.NONE, this.enderman)); boolean flag = blockhitresult.getBlockPos().equals(blockpos); if (blockstate.is(BlockTags.ENDERMAN_HOLDABLE) && flag) { level.removeBlock(blockpos, false); level.gameEvent(GameEvent.BLOCK_DESTROY, blockpos, GameEvent.Context.of(this.enderman, blockstate)); this.enderman.setCarriedBlock(blockstate.getBlock().defaultBlockState()); } } } }  
    • https://spark.lucko.me/uBsACZjZ1t heres the spark profiler!
    • My server crashes out of the blue, it doesnt matter how many people are online or what we are doing, it just "happens". Generally the server doesnt get any lag but sometimes it does when were exploring and stuff like that, i used spark to figure that one out. i changed the max tick time to -1 to see if that works but it doesnt seem to have fixed anything. Here I'll leave you the crashreport and log. https://paste.ee/p/GJTbh
    • Ah, the same issue occurred. https://pastebin.com/TW7LddVM
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.