[SOLVED] Help with NBTs

[TesterTesting135]

Hello, so I'm trying to make a sword that freezes entities on right click, but i cannot get the toggle working. There is probably a very easy solution to this, but I cannot for the life of me figure it out. Here is the right click method:

@Override
public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
    playerIn.setActiveHand(handIn);
    ItemStack stack = playerIn.getActiveItemStack();
    NBTTagCompound nbt;
    if (stack.hasTagCompound()) {
        nbt = stack.getTagCompound();
    } else {
        nbt = new NBTTagCompound();
    }
    if (nbt.hasKey("freeze"))
    {
        nbt.setBoolean("freeze", !nbt.getBoolean("freeze"));
    }
    FreezeTime(playerIn, worldIn, nbt.getBoolean("freeze"), 20);
    stack.setTagCompound(nbt);
    return super.onItemRightClick(worldIn, playerIn, handIn);
}

For some reason, instead of toggling "freeze" between true and false, it just stays at false. This code looks like it should work to me, but it doesn't. Please forgive me if this is a stupid mistake.

Thanks in advance.

Edited July 25, 2019 by TesterTesting135
Solved

[TesterTesting135]

Ok, thanks for the reply. I added this:

@Override
public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {
    playerIn.setActiveHand(handIn);
    ItemStack stack = playerIn.getActiveItemStack();
    NBTTagCompound nbt;
    if (stack.hasTagCompound())
    {
        nbt = stack.getTagCompound();
    }
    else
    {
        nbt = new NBTTagCompound();
    }

    if (nbt.hasKey("tmfreeze"))
    {
        nbt.setBoolean("tmfreeze", !nbt.getBoolean("tmfreeze"));
    }
    else
    {
        nbt.setBoolean("tmfreeze", false);
    }
    FreezeTime(playerIn, worldIn, nbt.getBoolean("freeze"), 20);
    stack.setTagCompound(nbt);
    return super.onItemRightClick(worldIn, playerIn, handIn);
}

(The else statement), but it would always set it to false. Any idea why?

Thanks.

[TesterTesting135]

Ok, i will change the modid. The only problem is, i'm not sure how to use Intellij to refactor it for all my files. Also, where did I forget an instance of my string?

Thanks.

[TesterTesting135]

Oh wow! I did not notice that! Thank you so much!

As for the mod id, i actually do have a constant, but in the recipe json files and blockstate files you can't really use a constant.

[TesterTesting135]

Ok, so i changed the string but for some reason, the hasKey method isn't working. Whenever i right click, it always says it's false. I added a debug line to it, saying "No Key" in chat if there wasn't a key. Here is my code:

public static final String FREEZE_KEY = "tmfreeze";
@Override
public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {

    playerIn.setActiveHand(handIn);
    ItemStack stack = playerIn.getActiveItemStack();
    NBTTagCompound nbt;
    if (stack.hasTagCompound())
    {
        nbt = stack.getTagCompound();
    }
    else
    {
        nbt = new NBTTagCompound();
    }

    if (nbt.hasKey(FREEZE_KEY))
    {
        nbt.setBoolean(FREEZE_KEY, !nbt.getBoolean(FREEZE_KEY));
    }
    else
    {
        nbt.setBoolean(FREEZE_KEY, false);
        playerIn.sendMessage(new TextComponentString("No Key"));
    }
    FreezeTime(playerIn, nbt.getBoolean(FREEZE_KEY), ConfigHandler.SWORD_OF_INEVITIBILITY_FREEZE_RANGE);
    return super.onItemRightClick(worldIn, playerIn, handIn);
}

Why isn't this working? Thanks.

Edited July 25, 2019 by TesterTesting135
Constant

[Draco18s]

36 minutes ago, TesterTesting135 said:

Oh wow! I did not notice that! Thank you so much!

As for the mod id, i actually do have a constant, but in the recipe json files and blockstate files you can't really use a constant.

Notepad++
Find Replace In Files

[Draco18s]

1 hour ago, diesieben07 said:

Or every IDE does this... At least I cannot imagine Eclipse not having it and IntelliJ definitely has it.

 

Also, don't return the result of super. Also, only do this stuff on the server.

Eclipse can too, I've just gotten used to using Notepadd++'s file search for all kinds of things (not just Minecraft/Java).

[TesterTesting135]

Ok, thanks for the tip. Any ideas why it's still not working? Thanks.

[TesterTesting135]

No, what should i return?

[Draco18s]

2 minutes ago, TesterTesting135 said:

No, what should i return?

Look at what super returns, copy it, change it to return a slightly different value.

I'd say "you want it to return SUCCESS" but the actual object is more complicated than that. The super method returns PASS.

[TesterTesting135]

Why shouldn't i just return the super?

[TesterTesting135]

Ok, thank you

[TesterTesting135]

Ok, so here is my code now:

public static final String FREEZE_KEY = "tmfreeze";

@Override
public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn) {

    playerIn.setActiveHand(handIn);
    ItemStack stack = playerIn.getActiveItemStack();
    NBTTagCompound nbt;
    if (!worldIn.isRemote) {
        if (stack.hasTagCompound()) {
            nbt = stack.getTagCompound();
        } else {
            nbt = new NBTTagCompound();
        }
        if (nbt.hasKey(FREEZE_KEY)) {
            nbt.setBoolean(FREEZE_KEY, !nbt.getBoolean(FREEZE_KEY));
        } else {
            nbt.setBoolean(FREEZE_KEY, true);
            playerIn.sendMessage(new TextComponentString("No Key"));
        }
        stack.setTagCompound(nbt);
        FreezeTime(playerIn, nbt.getBoolean(FREEZE_KEY), ConfigHandler.SWORD_OF_INEVITIBILITY_FREEZE_RANGE);
        return new ActionResult<>(EnumActionResult.SUCCESS, playerIn.getHeldItem(handIn));
    }
    return super.onItemRightClick(worldIn, playerIn, handIn);
}

but it's still always true.

 

[TesterTesting135]

Ok, so i fixed that, but I'm still getting "No Key".

[TesterTesting135]

Ok, woops. I didn't remove the first 2 statements. I removed them, and fixed the itemstack now. It works! Thank you so much!