I'm currently working on a method for a custom item that will print information in the chat about what is being looked at by the player.

 I am using the onItemRightClick method, but my game crashes when this code is ran:

	@Override
	public ActionResult<ItemStack> onItemRightClick(World worldIn, PlayerEntity playerIn, Hand handIn) {
		
		RayTraceResult rtr = this.rayTrace(worldIn, playerIn, RayTraceContext.FluidMode.NONE);
		playerIn.sendMessage(ITextComponent.Serializer.fromJson(rtr.hitInfo.toString()));
		return onItemRightClick(worldIn, playerIn, handIn);
	}

There are multiple parts of this snippet that I am very uncertain about, so it wouldn't surprise me if I am doing more than one thing wrong ?.

Any advice would be much appreciated.

 

EDIT: Updated my code as well as added crash log

crash-2019-08-04_12.45.37-client.txt

Edited August 4, 20196 yr by t_h0e
added crash log

1 hour ago, t_h0e said:

return super.onItemRightClick(worldIn, playerIn, handIn);

Change this to return your own ActionResult.

 

1 hour ago, t_h0e said:

but my game crashes when this code is ran:

Unsure of the crash, but perhaps a NullPointerException? Post your crash.

Edited August 4, 20196 yr by Animefan8888

I added my crash log to the original post. You were spot on about the NullPointerException but I'm not sure what is causing it.

Hmm, Ok. What field tell me which object (if any) was hit from a RayTraceResult?

Also I believe I am serializing my string into an ITextComponent wrong. Is my best option to just implement ITextComponent in my own method?

Thanks for the help! I got it working by changing the method to itemInteractionForEntity after a bit of tweaking. I believe onItemRightClick is called too many times for how I am applying it.

	@Override
	public boolean itemInteractionForEntity(ItemStack stackIn, PlayerEntity playerIn, LivingEntity livingIn, Hand handIn) {
		if (m.objectMouseOver.getType() == RayTraceResult.Type.ENTITY) {
			EntityRayTraceResult ertr = (EntityRayTraceResult) m.objectMouseOver;
			playerIn.sendMessage(ertr.getEntity().getName());
			return true;
		}
		else return false;
	}

 

When I use this code, I receive no message at all. I read another post that said RayTraceResult does not return entities because it is the same as World::RayTraceBlocks, however I'm not sure if that's why I'm receiving nothing at all.

	@Override
	public boolean itemInteractionForEntity(ItemStack stackIn, PlayerEntity playerIn, LivingEntity livingIn, Hand handIn) {
		RayTraceResult rtr = this.rayTrace(playerIn.world, playerIn, RayTraceContext.FluidMode.NONE);
		if (rtr.getType() == RayTraceResult.Type.ENTITY) {
			EntityRayTraceResult ertr = (EntityRayTraceResult) m.objectMouseOver;
			playerIn.sendMessage(ertr.getEntity().getName());
			
			return true;
		}
	}

 

GameRenderer.GetMouseOver() returns void. Is there something else I should be using, or do I have to create my own raytracing method?

Well, I believe I need to learn more about how to send network packets between the logical sides, because that is something I am not familiar with at all. It's unfortunate that a solely single player mod needs to be that complicated due to minecraft's design.

Oh, so Minecraft#objectMouseOver is a server side method, so I just need to write a similar method for the client?

So I need to perform the calculation on the server, I think I got it. Thanks