[1.14.2] Loot Tables

[Simon_kungen]

Hi

 

Losing the ability to specify block drops in code was a hard blow, I'm really struggling with Loot Tables.

I got a few blocks I've failed to get working. One (or rather many identical ones) is not that complicated, but one block has multiple Block Properties. I got the blockstate working fine, but Loot Tables is what's giving me the biggest issue. Going to summarise what the two types of blocks are supposed to drop depending on the blockstate:

 

Tin Ore:

Has property; density (0-3)

Should drop 2(density+1) intercraftcore:sn_chunk.

With Silktouch it should drop 1 intercraftcore:sn_ore with NBT density = blockstate density.

Current JSON:

Spoiler

{
  "type": "minecraft:block",
  "pools": [
    {
      "name": "intercraftcore:sn_ore",
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:alternatives",
          "children": [
            {
              "type": "minecraft:item",
              "conditions": [
                {
                  "condition": "minecraft:match_tool",
                  "predicate": {
                    "enchantments": [
                      {
                        "enchantment": "minecraft:silk_touch",
                        "levels": {
                          "min": 1
                        }
                      }
                    ]
                  }
                }
              ],
              "name": "intercraftcore:sn_ore"
            },
            {
              "type": "minecraft:item",
              "functions": [
                {
                  "function": "minecraft:set_count",
                  "count": 4
                },
                {
                  "function": "minecraft:explosion_decay"
                }
              ],
              "name": "intercraftcore:sn_chunk"
            }
          ]
        }
      ]
    }
  ]
}

 

 

 

Tree Tap:

Has property; volume (0-4), bucket (none ,metal_iron, wood_oak)

Should drop intercraftcore:treetap. When it has bucket = metal_iron drops minecraft:bucket as an extra and if volume = 4 drops a minecraft:water_bucket instead.

It should drop something I'm going to call intercraftcore:wood_oak_bucket when bucket = wood_oak, but I haven't added that yet so it would be redundant to add now to it.

Spoiler

{
  "type": "minecraft:block",
  "pools": [
    {
      "name": "intercraftcore:bucket",
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:alternatives",
          "children": [
            {
              "type": "minecraft:item",
              "conditions": [
                {
                  "condition": "minecraft:block_state_property",
                  "block": "intercraftcore:treetap",
                  "properties": {
                    "bucket": "metal_iron"
                  }
                }
              ],
              "name": "minecraft:bucket"
            }
          ]
        }
      ]
    },

    {
      "name": "intercraftcore:treetap",
      "rolls": 1,
      "entries": [
        {
          "type": "minecraft:item",
          "name": "intercraftcore:treetap"
        }
      ],
      "conditions": [
        {
          "condition": "minecraft:survives_explosion"
        }
      ]
    }


  ]
}

 

 

 

This doesn't drop anything at all right, which I can only presume is a syntax error I've missed. But I have no idea how to figure it out as the logs don't say anything: latest.log

[Draco18s]

22 minutes ago, Simon_kungen said:

Tin Ore:

Has property; density (0-3)

Should drop 2(density+1) intercraftcore:sn_chunk.

I've got you bro.
First off, I went the route of keeping density as a block property, but I register unique Item instances for each one:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L107

Which calls:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L56-L65

The lists there are used later in the Registry Events to register everything, but it keeps my main class cleaner and easier to read (though that hasn't stopped me from screwing up a GUI screen, by referencing the wrong bloody container type).

 

I then created my own loot functions to deal with the silt touching and density quantities.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/loot/function/BlockItemFunction.java

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/loot/function/HarderSetCount.java

(I should probably relocate those into the library)

 

Which results in the following loot table:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/loot_tables/blocks/ore_hardiron.json#L29

Line 32 is more or less irrelevant, but its required. It gets replaced with the correct item when the blockitem function gets run. My set_count function is also going to be a little different than yours, you might not need any data parameters (the divisor in mine).

[Simon_kungen]

52 minutes ago, Draco18s said:

I've got you bro.
First off, I went the route of keeping density as a block property, but I register unique Item instances for each one:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/HarderOres.java#L107

Which calls:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/hardlib/EasyRegistry.java#L56-L65

The lists there are used later in the Registry Events to register everything, but it keeps my main class cleaner and easier to read (though that hasn't stopped me from screwing up a GUI screen, by referencing the wrong bloody container type).

 

I then created my own loot functions to deal with the silt touching and density quantities.

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/loot/function/BlockItemFunction.java

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/java/com/draco18s/harderores/loot/function/HarderSetCount.java

(I should probably relocate those into the library)

 

Which results in the following loot table:

https://github.com/Draco18s/ReasonableRealism/blob/1.14.4/src/main/resources/data/harderores/loot_tables/blocks/ore_hardiron.json#L29

Line 32 is more or less irrelevant, but its required. It gets replaced with the correct item when the blockitem function gets run. My set_count function is also going to be a little different than yours, you might not need any data parameters (the divisor in mine).

Oh wow, thanks! This was driving me crazy! I pretty much copied your loot function code and changed the names and did a few adjustments to fit my ores, is that ok with you?

[Draco18s]

I never put a license in my git repos because I never know what to license it as.

I have no qualms with people looking at my code to figure out how I did what I did, or even borrowing sections (enjoy the loot func!). Its the "copy and redistribute large portions" that I don't appreciate.

[Simon_kungen]

13 minutes ago, Draco18s said:

I never put a license in my git repos because I never know what to license it as.

I have no qualms with people looking at my code to figure out how I did what I did, or even borrowing sections (enjoy the loot func!). Its the "copy and redistribute large portions" that I don't appreciate.

Alright, don't think I would ever do that consciously, but just in case I got the repo here where I placed the files. Take a look at them if you want and if you think I copied too much.

[Draco18s]

1 hour ago, Simon_kungen said:

Alright, don't think I would ever do that consciously, but just in case I got the repo here where I placed the files. Take a look at them if you want and if you think I copied too much.

Haha, I meant like my whole project dude, not the one file. You're good.