Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Pass BlockPos as Param to Item

Orion31

By Orion31
in Modder Support

 Share

Recommended Posts

Orion31 Tree Puncher

Orion31

Posted
Posted

Ok, so maybe I'm googling the wrong thing, but I've looked through tons of stuff on NBT and capabilities and I can't seem to figure this out. I have a block that provides the player with 7 "bungee" items that when used will teleport you back to the block you got the item from. However, I can't seem to figure out how to get this to work.

Say my code is this: 

i.insertItem(0, new ItemStack(new WaypointBungee(pos), 7), false);

Not only does the item not appear in the inventory, but when I register the item, I have nothing to put as the constructor parameter.

So if I create a method that adds the BlockPos, then I solve the ladder problem but not the former.

How can I make it so that I can add a custom location to this item?

DavidM World Shaper

DavidM

Posted
Posted

Items are singleton; you cannot just create a new instance of it.

You should create a new ItemStack and save your BlockPos in the NBTTag.

Some tips:

  Reveal hidden contents

 

Orion31 Tree Puncher

Orion31

Posted
  • Author
Posted
  On 8/24/2019 at 3:39 AM, DavidM said:

Items are singleton; you cannot just create a new instance of it.

You should create a new ItemStack and save your BlockPos in the NBTTag.

Expand  

Ok which functions should I use for reading and writing? The docs don't really explain this ?.  Thanks for your help 

Animefan8888 Reality Controller

Animefan8888

Posted
Posted
  On 8/24/2019 at 3:46 PM, Orion31 said:

Ok which functions should I use for reading and writing?

Expand  

ItemStack#getTag() and ItemStack#setTag(). Get the tag and if it is null create a new tag. Then populate the tag with your own value(s). Then set the tag if it was null.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Orion31 Tree Puncher

Orion31

Posted
  • Author
Posted
  On 8/24/2019 at 4:09 PM, Animefan8888 said:

ItemStack#getTag() and ItemStack#setTag(). Get the tag and if it is null create a new tag. Then populate the tag with your own value(s). Then set the tag if it was null.

Expand  

Ok but can I call get tag from onItemRightClick? I'm not at a computer rn but when I checked I don't think I could. 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • TileEntity
      Unable to update native luancher

      By TileEntity · Posted

      Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • Noureldien
      Unable to update native luancher

      By Noureldien · Posted

      can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • GPGPGold9393
      Death screen only shows the "You Died!" part

      By GPGPGold9393 · Posted

      The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 · Posted

      Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept