Jump to content

[1.14.4] Add custom command with server support


Cranky

Recommended Posts

Hi everyone,

 

I am struggling very hard to get my custom command to work on a server.

My Command is already working on the local client with client created map.

But as soon as I want to use it on my server too, the command is simply not recognized.

 

Snippet:

@Mod("crankyfly")
public class FlyMod {
    
    public static final Logger LOGGER = LogManager.getLogger();
    
    public FlyMod() {
        MinecraftForge.EVENT_BUS.addListener(this::serverStarting);
    }

    
    public void serverStarting(FMLServerStartingEvent event) {
        FlyMod.LOGGER.debug("@cranky serverStarting1 in main for crankyfly Mod");
        FlyCommand.register(event.getCommandDispatcher());
        FlyMod.LOGGER.debug("@cranky serverStarting2 in main for crankyfly Mod");
    }
}

 

public final class FlyCommand {



    private FlyCommand() {}


    public static void register(CommandDispatcher<CommandSource> dispatcher) 
    {
        // User types "/fly"
        FlyMod.LOGGER.debug("@Cranky trying to register command");
        dispatcher.register(Commands.literal("fly")
                // Needs permission level 4
                .requires(source -> source.hasPermissionLevel(4))
                .executes(context -> toggleFly(context.getSource())
                )
        );
    }

[...] //what the command does is not important, since that part is working - also its pretty obvious

}

 

 

I would love to debug/test it with "runServer" but somehow I can´t get it to work.

The run simply exits after 15 secs with no no errors.

 

 

Any help is much appreciated, since I cant find anything on the forum or many other examples I looked at...

Link to comment
Share on other sites

You haven't provided any logs but my first guess would be that you're crossing sides

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

Finally got the server to run and I uploaded the debug.log

https://paste.gg/p/anonymous/0ae28fff5be04bb1850e5d7e31a00356

 

But I cant see anything special in there.

 

My log statetemnts with @Cranky show me, that my events should get registered.

But I feel like I am using the wrong BUS or something similiar wrong.

Edited by Cranky
Link to comment
Share on other sites

2 minutes ago, Cranky said:

gradle runServer, the server just stops. No error no nothing.

It seems the command line argument "-Dforge.logging.markers=SCAN,REGISTRIES,REGISTRYDUMP" is causing this problem removed it from my eclipse run configutation for runServer. Started to work.

When DaemonUmbra asked for your logs he probably meant the server log from when you tested the command.

VANILLA MINECRAFT CLASSES ARE THE BEST RESOURCES WHEN MODDING

I will be posting 1.15.2 modding tutorials on this channel. If you want to be notified of it do the normal YouTube stuff like subscribing, ect.

Forge and vanilla BlockState generator.

Link to comment
Share on other sites

1 minute ago, Animefan8888 said:

It seems the command line argument "-Dforge.logging.markers=SCAN,REGISTRIES,REGISTRYDUMP" is causing this problem removed it from my eclipse run configutation for runServer. Started to work.

When DaemonUmbra asked for your logs he probably meant the server log from when you tested the command.

My bad, the post before yours was not meant to be send. I could already fix that issue. But hank you for looking into it!

I added the debug.log as requested by DaemonUmbra.

Link to comment
Share on other sites

Have you put a log statement in the command itself to make sure that code is executing?

This is my Forum Signature, I am currently attempting to transform it into a small guide for fixing easier issues using spoiler blocks to keep things tidy.

 

As the most common issue I feel I should put this outside the main bulk:

The only official source for Forge is https://files.minecraftforge.net, and the only site I trust for getting mods is CurseForge.

If you use any site other than these, please take a look at the StopModReposts project and install their browser extension, I would also advise running a virus scan.

 

For players asking for assistance with Forge please expand the spoiler below and read the appropriate section(s) in its/their entirety.

Spoiler

Logs (Most issues require logs to diagnose):

Spoiler

Please post logs using one of the following sites (Thank you Lumber Wizard for the list):

https://gist.github.com/100MB Requires member (Free)

https://pastebin.com/: 512KB as guest, 10MB as Pro ($$$)

https://hastebin.com/: 400KB

Do NOT use sites like Mediafire, Dropbox, OneDrive, Google Drive, or a site that has a countdown before offering downloads.

 

What to provide:

...for Crashes and Runtime issues:

Minecraft 1.14.4 and newer:

Post debug.log

Older versions:

Please update...

 

...for Installer Issues:

Post your installer log, found in the same place you ran the installer

This log will be called either installer.log or named the same as the installer but with .log on the end

Note for Windows users:

Windows hides file extensions by default so the installer may appear without the .jar extension then when the .log is added the log will appear with the .jar extension

 

Where to get it:

Mojang Launcher: When using the Mojang launcher debug.log is found in .minecraft\logs.

 

Curse/Overwolf: If you are using the Curse Launcher, their configurations break Forge's log settings, fortunately there is an easier workaround than I originally thought, this works even with Curse's installation of the Minecraft launcher as long as it is not launched THROUGH Twitch:

Spoiler
  1. Make sure you have the correct version of Forge installed (some packs are heavily dependent on one specific build of Forge)
  2. Make a launcher profile targeting this version of Forge.
  3. Set the launcher profile's GameDir property to the pack's instance folder (not the instances folder, the folder that has the pack's name on it).
  4. Now launch the pack through that profile and follow the "Mojang Launcher" instructions above.

Video:

Spoiler

 

 

 

or alternately, 

 

Fallback ("No logs are generated"):

If you don't see logs generated in the usual place, provide the launcher_log.txt from .minecraft

 

Server Not Starting:

Spoiler

If your server does not start or a command window appears and immediately goes away, run the jar manually and provide the output.

 

Reporting Illegal/Inappropriate Adfocus Ads:

Spoiler

Get a screenshot of the URL bar or copy/paste the whole URL into a thread on the General Discussion board with a description of the Ad.

Lex will need the Ad ID contained in that URL to report it to Adfocus' support team.

 

Posting your mod as a GitHub Repo:

Spoiler

When you have an issue with your mod the most helpful thing you can do when asking for help is to provide your code to those helping you. The most convenient way to do this is via GitHub or another source control hub.

When setting up a GitHub Repo it might seem easy to just upload everything, however this method has the potential for mistakes that could lead to trouble later on, it is recommended to use a Git client or to get comfortable with the Git command line. The following instructions will use the Git Command Line and as such they assume you already have it installed and that you have created a repository.

 

  1. Open a command prompt (CMD, Powershell, Terminal, etc).
  2. Navigate to the folder you extracted Forge’s MDK to (the one that had all the licenses in).
  3. Run the following commands:
    1. git init
    2. git remote add origin [Your Repository's URL]
      • In the case of GitHub it should look like: https://GitHub.com/[Your Username]/[Repo Name].git
    3. git fetch
    4. git checkout --track origin/master
    5. git stage *
    6. git commit -m "[Your commit message]"
    7. git push
  4. Navigate to GitHub and you should now see most of the files.
    • note that it is intentional that some are not synced with GitHub and this is done with the (hidden) .gitignore file that Forge’s MDK has provided (hence the strictness on which folder git init is run from)
  5. Now you can share your GitHub link with those who you are asking for help.

[Workaround line, please ignore]

 

Link to comment
Share on other sites

13 hours ago, DaemonUmbra said:

Have you put a log statement in the command itself to make sure that code is executing?

Yes, I did that.

 

OK, you guys are gonna hate me, but I finally got everything to work.

It was several very stuipd problems that actually had not much to do with the actual coding.

 

But just for completenes, I am going to list them:

  1. It was years since my last server setup (I made that once and ever only migrated it), so I forgot I had to accept the eula.txt.
  2. Which I didnt notice becaus I couldnt find, where the server and by this logs is located, that is run with gradlew runServer. It is under ./run in the main folder of the project
  3. Somehow I had registered the same event twice in the bus, which must have confused the BUS or simply borke it, because it was ingored
    After making it only on registration, it was actualy working.
  4. I migrated my server from Minecraft 1.12 to 1.14, and somehow the server starting with forge changed.
    I launched the minecraft_server.1.14.4.jar and not the forge-1.14.4-28.0.75.jar
    In 1.12 with forge this was enough to get a modded server, but in 1.14 with forge you have to start the server using the forge jar

Now the server is no longer vanilla but a real forge server

and forge is working just perfect includind my mod.

 

Anyways, sorry for wasting your time, since my actual coding did work from the beginning...

 

Have a good one and thank you very much for your guys help!

 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.