[1.12.2] Trying to render a texture as an overlay to a block in world fails

[nekosune]

I am trying to render a transparent texture over specific in world blocks whenever an item is held. Due to previous work, i can put a box of lines around it, but as soon as I start with textures, and the needed changes, it fails

 

https://github.com/Thaumic-Tinkerer/ThaumicTinkerer/blob/1.12/src/main/java/com/nekokittygames/thaumictinkerer/client/rendering/special/TransvectorRendering.java is the code in question.

I have only started with the first face, to make debugging easier currently.

This is the result I get always:

A plain white square over the face where I should get this texture:

overlayed on the block underneath.

Is there anything obvious I am missing here?

[DavidM]

Not sure if this is the cause, but you enabled texture 2D, then immediately disabled it here.

[nekosune]

10 minutes ago, DavidM said:

Not sure if this is the cause, but you enabled texture 2D, then immediately disabled it here.

Honestly that's leftover code from where I sourced the original line drawing varient, drawOutlineTextured acts the same if I enableTexture2D inside or not

[DavidM]

Have you bind your texture? I am dumb.

Edited September 16, 2019 by DavidM

[Animefan8888]

5 hours ago, DavidM said:

I am dumb.

I don't think so. I also don't see the texture being bound. @nekosune Passes a TextureAtlasSprite(RenderEvents.MARK_SPRITE) to his drawTexturedOutline, but never binds that texture.

[nekosune]

2 hours ago, Animefan8888 said:

I don't think so. I also don't see the texture being bound. @nekosune Passes a TextureAtlasSprite(RenderEvents.MARK_SPRITE) to his drawTexturedOutline, but never binds that texture.

Even with trying to bind any texture , rather then just using the atlas,  like here: https://github.com/Thaumic-Tinkerer/ThaumicTinkerer/blob/e740e94ca431a1dc6d2c04a004e570b1505cceb4/src/main/java/com/nekokittygames/thaumictinkerer/client/rendering/special/TransvectorRendering.java#L77

I still get the exact same error...

[DavidM]

9 hours ago, Animefan8888 said:

I don't think so. I also don't see the texture being bound. @nekosune Passes a TextureAtlasSprite(RenderEvents.MARK_SPRITE) to his drawTexturedOutline, but never binds that texture.

I think that OP stitched the texture during TextureStitchEvent, and then use TextureAtlasSprite#getInterpolatedU and V to obtain the UV of the stitched sprite to be used in the buffer builder.

The texture binded is still the original texture map, but it contains the stitched texture.

[nekosune]

50 minutes ago, DavidM said:

I think that OP stitched the texture during TextureStitchEvent, and then use TextureAtlasSprite#getInterpolatedU and V to obtain the UV of the stitched sprite to be used in the buffer builder.

The texture binded is still the original texture map, but it contains the stitched texture.

That's exactly what I was doing, it turns out disabling and renabling texture 2D was confusing things, removing that helped fix things