[SOLVED] Fluid Textures Not Showing [1.12.2]

[DeathSpawn]

I am not getting any textures for my custom fluids. I think it has to do with StateMappers since the level=10, level=11... are not registered properly but I do not know how to fix this problem.

 

BlockFluidCore

public class BlockFluidCore extends BlockFluidClassic implements IHasFluidModel {

	protected String name;
	
	protected float particleRed = 1.0F;
	protected float particleGreen = 1.0F;
	protected float particleBlue = 1.0F;
	protected boolean shouldDisplaceFluids = false;

	public BlockFluidCore(Fluid fluid, Material material, String unlocalizedName) {
		super(fluid, material);
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, unlocalizedName));
		this.name = unlocalizedName;
	}

	public BlockFluidCore setParticleColor(int c) {

		return setParticleColor(((c >> 16) & 255) / 255f, ((c >> 8) & 255) / 255f, (c & 255) / 255f);
	}

	public BlockFluidCore setParticleColor(float particleRed, float particleGreen, float particleBlue) {

		this.particleRed = particleRed;
		this.particleGreen = particleGreen;
		this.particleBlue = particleBlue;

		return this;
	}

	@Override
	public Boolean isEntityInsideMaterial(IBlockAccess world, BlockPos blockpos, IBlockState iblockstate, Entity entity,
			double yToTest, Material materialIn, boolean testingHead) {
		if (this.density < 0) {
			return false;
		}
		if (testingHead) {
			return true;
		}
		return super.isEntityInsideMaterial(world, blockpos, iblockstate, entity, yToTest, materialIn, testingHead);
	}

	@Override
	public boolean canCreatureSpawn(IBlockState state, IBlockAccess world, BlockPos pos, SpawnPlacementType type) {
		return false;
	}

	@Override
	public boolean canDisplace(IBlockAccess world, BlockPos pos) {

		if (!shouldDisplaceFluids && world.getBlockState(pos).getMaterial().isLiquid()) {
			return false;
		}
		return super.canDisplace(world, pos);
	}

	@Override
	public boolean displaceIfPossible(World world, BlockPos pos) {

		if (!shouldDisplaceFluids && world.getBlockState(pos).getMaterial().isLiquid()) {
			return false;
		}
		return super.displaceIfPossible(world, pos);
	}

	/* ACCESSORS */
	public int getDensitySafe() {

		return density;
	}

	public int getDensityDirSafe() {

		return densityDir;
	}

	public float getParticleRed() {

		return particleRed;
	}

	public float getParticleGreen() {

		return particleGreen;
	}

	public float getParticleBlue() {

		return particleBlue;
	}

	@Override
	@SideOnly (Side.CLIENT)
	public Vec3d getFogColor(World world, BlockPos pos, IBlockState state, Entity entity, Vec3d originalColor, float partialTicks) {

		return new Vec3d(getParticleRed(), getParticleGreen(), getParticleBlue());
	}

	@Override
	@SideOnly(Side.CLIENT)
	public void registerFluidBlockModel() {

		Item item = Item.getItemFromBlock(this);
		StateMapper mapper = new StateMapper("fluid", this.name);

		ModelBakery.registerItemVariants(item);
		ModelLoader.setCustomMeshDefinition(item, mapper);
		ModelLoader.setCustomStateMapper(this, mapper);
	}

}

Thre registerFluidBlockModel() is being called in my ClientProxy.

 

ClientProxy:

@Override
public void registerStateMapper() {
	for(BlockFluidBase bf: ModBlocks.BLOCKFLUIDS) {
		if(bf instanceof IHasFluidModel) {
			((IHasFluidModel)bf).registerFluidBlockModel();
			MagicModLogger.getLogger().info("Register FluidBlock: " + bf.getUnlocalizedName().substring(5));
		}
	}
}

This is later called in my MainMod files' preInit event

 

MainMod event:

@EventHandler
public static void preInit(FMLPreInitializationEvent e) {
	MagicModLogger.getLogger().info("Pre-Initialization");
	ModFluids.registerFluids();
	ModFluids.integrateFluids();
	ModBlocks.registerBlocks();
	proxy.registerStateMapper();
}

 

[DeathSpawn]

The log file says this:

https://pastebin.com/taeQYub2

Edited September 17, 2019 by DeathSpawn
Too long

[DeathSpawn]

Forgot to provide my ModBlocks:

 

public static List<Block> BLOCKS = new ArrayList<Block>();
	public static final List<BlockFluidBase> BLOCKFLUIDS = new ArrayList<BlockFluidBase>();
	
	public static final Block blockIngots = new ModIngotBlocks(Material.IRON, "block");
	public static final Block moltenMythrilBlock = new BlockMoltenMythril(ModFluids.moltenMythrilFluid);
	public static final Block moltenCoal = new BlockLiquifiedCoal(ModFluids.liquifiedCoal);
	
	public static void registerBlocks() {
		registerBlock(moltenMythrilBlock);
		registerBlock(moltenCoal);
	}
	
	public static void registerBlock(Block block) {
		ForgeRegistries.BLOCKS.register(block);
		ItemBlock itemBlock = new ItemBlock(block);
		itemBlock.setRegistryName(block.getRegistryName());
		ForgeRegistries.ITEMS.register(itemBlock);
	}
}

I saw ForgeRegistries.BLOCKS/ITEMS.register() method on CoFH's source code so I used it, could it be causing the problem?

[DeathSpawn]

 

I fixed up my code to register in events. What do you mean by your first point?

 

Code:

public class BlockMoltenMythril extends BlockMoltenFluidCore {

	Fluid fluid;
	public BlockMoltenMythril(Fluid fluid) {
		super(fluid, "molten_mythril", new MaterialLiquid(MapColor.LIGHT_BLUE));
		this.fluid = fluid;
		
		ModBlocks.BLOCKS.add(this);
		ModItems.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
	}

}

public class BlockLiquifiedCoal extends BlockMoltenFluidCore{

	Fluid fluid;
	public BlockLiquifiedCoal(Fluid fluid) {
		super(fluid, "molten_coal", new MaterialLiquid(MapColor.BLACK));
		this.fluid = fluid;
		
		ModBlocks.BLOCKS.add(this);
		ModItems.ITEMS.add(new ItemBlock(this).setRegistryName(this.getRegistryName()));
	}

}

 

[DeathSpawn]

And the rest is the same as any 1.12.2 tutorial found on YouTube:

 

@SubscribeEvent
public static void registerItems(RegistryEvent.Register<Item> event) {
	event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	MagicModLogger.getLogger().info("Register Items!");
	OreDictionaryHandler.registerOreItems();
	OreDictionaryHandler.registerOreBlocks();
}
	
@SubscribeEvent
public static void registerBlocks(RegistryEvent.Register<Block> event) {
	event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	MagicModLogger.getLogger().info("Register Blocks!");
}

 

[Animefan8888]

21 minutes ago, DeathSpawn said:

What do you mean by your first point?

Your Item and Block fields are static and you initialize them when you declare them. This is statically initializing something. Dont do that. Initialize them in their registry event.

[DeathSpawn]

Is this correct?

 

RegistryHandler.java:

@SubscribeEvent
public static void registerItems(RegistryEvent.Register<Item> event) {
	ModItems.init();
	event.getRegistry().registerAll(ModItems.ITEMS.toArray(new Item[0]));
	MagicModLogger.getLogger().info("Register Items!");
	OreDictionaryHandler.registerOreItems();
	OreDictionaryHandler.registerOreBlocks();
}

@SubscribeEvent
public static void registerBlocks(RegistryEvent.Register<Block> event) {
	ModBlocks.init();
	event.getRegistry().registerAll(ModBlocks.BLOCKS.toArray(new Block[0]));
	MagicModLogger.getLogger().info("Register Blocks!");
}

 

ModItems.java:

public static List<Item> ITEMS = new ArrayList<Item>();
	
public static Item modIngots;
public static Item gemFragments;
public static Item corruptFragment;
public static Item featherBunch;
	
//ItemBlocks
public static ItemBlock itemBlockingots;

public static void init() {
	modIngots = new ModIngot("ingot");
	gemFragments = new ItemGemFragment("gem_frag");
	corruptFragment = new ItemCorruptedFragments("corrupt_fragment");
	featherBunch = new ItemFeatherBunch("feather_bunch");
	
	itemBlockingots = new ItemModIngotBlocks();
}

 

ModBlocks.java:

public static List<Block> BLOCKS = new ArrayList<Block>();
public static final List<BlockFluidBase> BLOCKFLUIDS = new ArrayList<BlockFluidBase>();

public static Block blockIngots;
public static Block moltenMythrilBlock;
public static Block moltenCoal;

public static void init() {
	blockIngots = new ModIngotBlocks(Material.IRON, "block");
	moltenMythrilBlock = new BlockMoltenMythril(ModFluids.moltenMythrilFluid);
	moltenCoal = new BlockLiquifiedCoal(ModFluids.liquifiedCoal);
}

 

It still doesn't solve my fluid texture problem though. I am getting the same log...

Edited September 17, 2019 by DeathSpawn
problem

[DeathSpawn]

I realized my fluids were not added to the ModBlocks.FLUIDBLOCKS so I added them. Now, the problem is they come out as water texture.

 

This is the project's Git repository:

https://github.com/SSJDeathSpawn/Gem-Enchantment-Mod

 

It will help (I think) in fixing my problem...

[DeathSpawn]

I found the error...

In my blockstate file, I misspelled "fluids" as "fluid" which caused the error.

I found the same issue on another thread:

Which led me to the answer. Thanks to all those who tried to help.