[1.12.2] Player death not cancelled

[X_Khan_X]

Hello, I'm trying to cancel a death event if player has the item in his inventory however the event is not cancelled even if using

System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());

After "e.setCancelled(true);" gives me true for both I keep dying without have the item removed from the inventory.

Here's my DeathEvent:

@EventBusSubscriber
public class EntityDeath {

	@SubscribeEvent(priority = EventPriority.HIGHEST)
	@Mod.EventHandler
	public void onEntityDeath(LivingDeathEvent e) {
		World world = e.getEntity().getEntityWorld();
		if (world.isRemote) {
			return;
		}
		if (!world.isRemote) {
			if (e.getEntityLiving() instanceof EntityPlayer) {
				EntityPlayerMP mp = (EntityPlayerMP) e.getEntity();
				ItemStack pixie = new ItemStack(InitItems.PIXIE);
				FoodStats food = mp.getFoodStats();
				if (mp.inventory.hasItemStack(pixie)) {
					System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());
					e.setCanceled(true);
					System.out.println(e.isCancelable() + " < cancellabe | cancelled > " + e.isCanceled());
					mp.heal(20F);
					food.setFoodLevel(20);
					food.setFoodSaturationLevel(20);
					world.playSound(mp, mp.getPosition(), SoundEvents.BLOCK_ANVIL_BREAK, SoundCategory.BLOCKS, 1, 1);
					pixie.setCount(pixie.getCount() - 1);
				}
			}
		}
	}
}

[Animefan8888]

7 minutes ago, X_Khan_X said:

After "e.setCancelled(true);" gives me true for both I keep dying without have the item removed from the inventory.

Here's my DeathEvent:

If I understand correctly your problem is that the Item isn't removed from your inventory.

7 minutes ago, X_Khan_X said:

ItemStack pixie = new ItemStack(InitItems.PIXIE);

This ItemStack does not equal the ItemStack in the inventory. SO

10 minutes ago, X_Khan_X said:

pixie.setCount(pixie.getCount() - 1);

This does nothing. You should use one of the removal methods.

[X_Khan_X]

Just now, Animefan8888 said:

If I understand correctly your problem is that the Item isn't removed from your inventory.

This ItemStack does not equal the ItemStack in the inventory. SO

This does nothing. You should use one of the removal methods.

The code above pass the "if player has the item in the inventory" check, I mean after

if (mp.inventory.hasItemStack(pixie)) {

I added a System.out.println with random text and it is printed.

 

[Animefan8888]

Just now, X_Khan_X said:

The code above pass the "if player has the item in the inventory" check, I mean after

if (mp.inventory.hasItemStack(pixie)) {

I added a System.out.println with random text and it is printed.

Yes I understand that. The problem is that it isn't removed from the player's inventory right? The problem is

16 minutes ago, X_Khan_X said:

ItemStack pixie = new ItemStack(InitItems.PIXIE);

This ItemStack does not equal the ItemStack in the inventory. SO 

16 minutes ago, X_Khan_X said:

pixie.setCount(pixie.getCount() - 1);

This does nothing. You should use one of the removal methods in the players inventory.

[X_Khan_X]

 

 

 

 

1 minute ago, Animefan8888 said:

This ItemStack does not equal the ItemStack in the inventory. SO 

How to check it correctly then?

[Animefan8888]

1 minute ago, X_Khan_X said:

How to check it correctly then?

You need to remove the Item from the player's inventory.

[X_Khan_X]

Just now, Animefan8888 said:

You need to remove the Item from the player's inventory.

But I have to check if the player has this item no?

[Animefan8888]

23 minutes ago, X_Khan_X said:

if (mp.inventory.hasItemStack(pixie)) {

This part is fine.

[X_Khan_X]

Then I don't understand the problem... I don't understand what I have to change

[Animefan8888]

Just now, X_Khan_X said:

I don't understand what I have to change

56 minutes ago, X_Khan_X said:

pixie.setCount(pixie.getCount() - 1);

 

That part.

[X_Khan_X]

42 minutes ago, Animefan8888 said:

 

That part.

Done. Still dying

[Animefan8888]

1 hour ago, X_Khan_X said:

mp.heal(20F);

This only heals the Entity if the entities health is greater than 0. Use setHealth

[X_Khan_X]

13 minutes ago, Animefan8888 said:

This only heals the Entity if the entities health is greater than 0. Use setHealth

Thanks