Jump to content

Recommended Posts

Posted

So I have an item that I would like to display in an item frame in a non-standard manner (similar to maps and compasses and not like other items).

 

How would I go about doing this without a base class edit?

 

The first thought is that I could extend ItemMap and then it would count as a map and render as a map, but RenderItemFrame has this:

 

if (entityitem.getEntityItem().getItem() == Item.map)

 

Which precludes that.  It looks to see if an item is exactly a vanilla map or vanilla compass, not any other item which might be a subclass.

 

Writing my own renderer is going to do no good, as then it wouldn't be a renderer for Itemframes.

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

So I have an item that I would like to display in an item frame in a non-standard manner (similar to maps and compasses and not like other items).

 

How would I go about doing this without a base class edit?

 

The first thought is that I could extend ItemMap and then it would count as a map and render as a map, but RenderItemFrame has this:

 

if (entityitem.getEntityItem().getItem() == Item.map)

 

Which precludes that.  It looks to see if an item is exactly a vanilla map or vanilla compass, not any other item which might be a subclass.

 

Writing my own renderer is going to do no good, as then it wouldn't be a renderer for Itemframes.

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 4 months later...
Posted

I noticed that item frames still don't use the handy isMap() method to render maps.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Posted

You should make a custom Item Renderer and then in it check for RenderItem.renderInFrame, which is true if the item being rendered is in an ItemFrame.

 

As opposed to say, making an item that extends ItemMapBase (so isMap -> true) which should be utilized in all ways by other objects in the same way as a vanilla map. :|

 

(isMap is called in one place in the entire Minecraft codebase, which boggles my mind)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 1 year later...
Posted

Apologies for the necro. I make this post so anyone looking for the info isn't misled.  It was brought to my attention and isn't a good thing to let lie, lest folks mess it up. :P

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

No. 0.o

That function is for data sending NOT rendering.

 

You can already do this using a custom item renderer (IItemRenderer) to control how the entity form of the item is rendered or by using the RenderItemInFrameEvent.

Posted

Thanks XCW, but:

 

September 18, 2013

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried do download the essential mod to my mod pack but i didnt work. I paly on 1.21 and it should work. I use neoforge for my modding. The weird things is my friend somehow added the mod to his modpack and many others that I somehow can´t. Is there anything i can do? 
    • Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.