Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

So I have an item that I would like to display in an item frame in a non-standard manner (similar to maps and compasses and not like other items).

 

How would I go about doing this without a base class edit?

 

The first thought is that I could extend ItemMap and then it would count as a map and render as a map, but RenderItemFrame has this:

 

if (entityitem.getEntityItem().getItem() == Item.map)

 

Which precludes that.  It looks to see if an item is exactly a vanilla map or vanilla compass, not any other item which might be a subclass.

 

Writing my own renderer is going to do no good, as then it wouldn't be a renderer for Itemframes.

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

So I have an item that I would like to display in an item frame in a non-standard manner (similar to maps and compasses and not like other items).

 

How would I go about doing this without a base class edit?

 

The first thought is that I could extend ItemMap and then it would count as a map and render as a map, but RenderItemFrame has this:

 

if (entityitem.getEntityItem().getItem() == Item.map)

 

Which precludes that.  It looks to see if an item is exactly a vanilla map or vanilla compass, not any other item which might be a subclass.

 

Writing my own renderer is going to do no good, as then it wouldn't be a renderer for Itemframes.

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 4 months later...
  • Author

I noticed that item frames still don't use the handy isMap() method to render maps.

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • Author

You should make a custom Item Renderer and then in it check for RenderItem.renderInFrame, which is true if the item being rendered is in an ItemFrame.

 

As opposed to say, making an item that extends ItemMapBase (so isMap -> true) which should be utilized in all ways by other objects in the same way as a vanilla map. :|

 

(isMap is called in one place in the entire Minecraft codebase, which boggles my mind)

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

  • 1 year later...

Apologies for the necro. I make this post so anyone looking for the info isn't misled.  It was brought to my attention and isn't a good thing to let lie, lest folks mess it up. :P

 

If anyone who can do Forge pulls / request such, the above line SHOULD be thus:

 

if (entityitem.getEntityItem().getItem().isMap())

No. 0.o

That function is for data sending NOT rendering.

 

You can already do this using a custom item renderer (IItemRenderer) to control how the entity form of the item is rendered or by using the RenderItemInFrameEvent.

  • Author

Thanks XCW, but:

 

September 18, 2013

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable.  If you think this is the case, JUST REPORT ME.  Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

 

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

 

DO NOT PM ME WITH PROBLEMS. No help will be given.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.