I'm building a weapon that on right click gives the item increased damage. The base damage of the sword is 7 damage, and when its right clicked I want it to be 10. I played around with item.addAttributeModifier(SharedMonsterAttributes.ATTACK_DAMAGE.getName(), new AttributeModifier("Weapon modifier",10, AttributeModifier.Operation.ADDITION), EquipmentSlotType.MAINHAND); but I cant figure out how to get rid of the attribute when I add it. Is this the way I should be changing damage on a sword or should I use NBT or is there some other way of doing this?

Edited October 4, 20196 yr by ImperialDragon99

I managed to get it to work with 

    @Override
    public Multimap<String, AttributeModifier> getAttributeModifiers(EquipmentSlotType slot, ItemStack stack) {
        final Multimap<String, AttributeModifier> modifiers = super.getAttributeModifiers(slot, stack);

        if (slot == EquipmentSlotType.MAINHAND) {
            replaceModifier(modifiers, SharedMonsterAttributes.ATTACK_DAMAGE, ATTACK_DAMAGE_MODIFIER, WitherSword.withersworddamage);
            //replaceModifier(modifiers, SharedMonsterAttributes.ATTACK_SPEED, ATTACK_SPEED_MODIFIER, 1.5);
        }

        return modifiers;
    }
    
    private void replaceModifier(Multimap<String, AttributeModifier> modifierMultimap, IAttribute attribute, UUID id, double multiplier) {
        // Get the modifiers for the specified attribute
        final Collection<AttributeModifier> modifiers = modifierMultimap.get(attribute.getName());

        // Find the modifier with the specified ID, if any
        final Optional<AttributeModifier> modifierOptional = modifiers.stream().filter(attributeModifier -> attributeModifier.getID().equals(id)).findFirst();

        if (modifierOptional.isPresent()) { // If it exists,
            final AttributeModifier modifier = modifierOptional.get();
            modifiers.remove(modifier); // Remove it
            modifiers.add(new AttributeModifier(modifier.getID(), modifier.getName(), modifier.getAmount() + multiplier, modifier.getOperation())); // Add the new modifier
        }
    }

but the problem is how could I make it item specific for damage because right now it applys for all the wither swords

 

 

 

1

1 hour ago, ImperialDragon99 said:

but the problem is how could I make it item specific for damage because right now it applys for all the wither swords

Add a capability to keep track of the damage amount

Items are singleton; changing the value in one instance will change every ItemStack containing that item.

Instead, store the damage amount in the ItemStack's NBTTag, preferably via a Capability.