Jump to content

[1.14.4] Set a living entity's max health and defense


Recommended Posts

Posted (edited)

How can I set a living entity max health and a living entity defense? I need that to calculate a health bonus and a defense bonus.

Thank you

Edited by cinsiian
Posted

If you are trying to set the base value for the entity's max health you can use applyEntityAttributes().

Look at EntityZombie.applyEntityAttributes() for reference on both.

 

 

Posted (edited)

I found this method:

entity.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue

but i need to get the entity's default max health.

So i created a HashMap<LivingEntity, Double> to store the values. I would put the entries during the registry event<EntityType>.

Is there a way to cast EntityType to LivingEntity so i can get the attribute when the game loads?

I cant just use entity.getAttribute(SharedMonsterAttributes.MAX_HEALTH).getBaseValue() because im in a LivingUpdateEvent and it will become a loop

Edited by cinsiian
Posted
15 hours ago, diesieben07 said:

I am not sure why you think this would "become a loop". But doing this is the way to get the "base value" for the max health. And it should work fine in LivingUpdateEvent.

Yes it is:

Update 1 ===: 20 + 2(bonus)

Update 2 ===: 22 + 2(bonus)

ec..

 

It gets modified and the health will increase infinitely. I tested it and yea, this is the problem.

Just asking if i can cast EntityType to LivingEntity

Posted
Just now, diesieben07 said:

No, this would not happen, because the base value does not include the attribute modifiers, as indicated by its name.

It does, I just tested it in my world and the health keeps increasing

 

1 minute ago, diesieben07 said:

No. An entity type represents the abstract concept of an entity type (like "all zombies"). LivingEntity is a base class for actual entities ("this specific zombie"). There is no useful way to convert from EntityType to LivingEntity.

So I have the put the values manually?

Posted
1 minute ago, diesieben07 said:

How do you modify the value? Show your code.

@SubscribeEvent
	public static void update(LivingUpdateEvent event) {
		LivingEntity entity = event.getEntityLiving();
		LivingEntityUtils utils = new LivingEntityUtils(entity);
		int bonus = utils.calculateHealthBonus(); //The bonus
		double baseHealth = entity.getAttribute(SharedMonsterAttributes.MAX_HEALTH).getBaseValue();
		
		entity.getAttribute(SharedMonsterAttributes.MAX_HEALTH).setBaseValue(baseHealth + bonus);
	}

 

1 minute ago, diesieben07 said:

No idea what you are talking about.

Save the default max healths

Posted

Ok i actually managed to do it without the capability:

       if(headHealth > 0) { //headHealth is the enchantment level
			String id = "head-health-boost-enchantment";
			boolean isAlreadyApplied = false;
			
			for(AttributeModifier modifer : utils.MAX_HEALTH().getModifiers()) { //utils.MAX_HEALTH() returns the max health attribute
				if(modifer.getName().equals(id)) {
					isAlreadyApplied = true;
				}
			}
			
			if(!isAlreadyApplied) {
				AttributeModifier newModifier = new AttributeModifier(id, headHealth * 2, Operation.ADDITION);
				utils.MAX_HEALTH().applyModifier(newModifier);
			}
		} else {
			for(AttributeModifier modifer : utils.MAX_HEALTH().getModifiers()) {
				if(modifer.getName().equals("head-health-boost-enchantment")) {
					utils.MAX_HEALTH().removeModifier(modifer);
				}
			}
		}

Now modifing the defense seems that theres a 30 limit. Can I avoid that?

Posted

Im not familiar with reflections but i tried to replace the field without success:
 

private void setMaxDefenseValue() throws NoSuchFieldException, SecurityException, IllegalAccessException {
    	Class<SharedMonsterAttributes> attributesArmor = SharedMonsterAttributes.class;
		Field fieldArmor = attributesArmor.getField("ARMOR");
		
		IAttribute attribute = (new RangedAttribute((IAttribute)null, "generic.armor", 0.0D, 0.0D, 1024.0D)).setShouldWatch(true);
		Object armor = fieldArmor.get(attribute);
		
		fieldArmor.set(attribute, armor);
    }

I called this in the constructor of my mod. Totally not sure this is the not correct way

Posted (edited)
	public void overrideMaxDefenceValue(double newValue) throws NoSuchFieldException, SecurityException, IllegalAccessException {
		Field value = SharedMonsterAttributes.ARMOR.getClass().getDeclaredField("maximumValue");
		value.setAccessible(true);
		value.set(value, newValue);
    }

Is this correct?

Edited by cinsiian
Posted
6 minutes ago, diesieben07 said:

Do not lookup the Field every time, do it once and store it in a static final field.

What do you mean every time? Isnt that supposed to just go in the mod's constructor?

 

7 minutes ago, diesieben07 said:

Do not use getClass. Use a class literal (Foo.class).

Isn't getClass the only way to get the class from the object?

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.