[1.14.4] Best way to sync progress in tile entity.

[Legenes]

Hi!

I was thinking about making a machine that generates RF from fuels, and it should display its current progress of burning. My problem is that I don't know the best way to sync up the tile with the GUI. Should I use a custom capability or just a packet of some kind? If I should use one of them, what should I implement? Thanks for the help!

[Draco18s]

You don't need to sync very much or very often. The client, provided that the amount of fuel has been synced as the result of an inventory change, can calculate the RF conversion process all on its own using the exact same code as the server side tile entity. There is no point or need to sync the progress.

[Legenes]

2 minutes ago, Draco18s said:

You don't need to sync very much or very often. The client, provided that the amount of fuel has been synced as the result of an inventory change, can calculate the RF conversion process all on its own using the exact same code as the server side tile entity. There is no point or need to sync the progress.

Sorry, I may have said something incorrectly. This block is like a furnace but without an output. I want to be able to see how much more the item inside is going to last as a fuel, like the little flame in the furnace. That depends on the currently burnt item's burn time (where the exampleItemStack.getBurnTime() always returns -1 for some reason) and how many ticks did I burn it for. I want to sync the the little flame if you get what I mean.

[Legenes]

2 minutes ago, Legenes said:

exampleItemStack.getBurnTime() always returns -1 for some reason

I found this in the IForgeItem class:

    /**
     * @return the fuel burn time for this itemStack in a furnace. Return 0 to make
     *         it not act as a fuel. Return -1 to let the default vanilla logic
     *         decide.
     */
    default int getBurnTime(ItemStack itemStack)
    {
        return -1;
    }

I don't know if the "vanilla" logic is failing, or I need to use something else, but this is weird.

[Legenes]

2 minutes ago, Legenes said:

I found this in the IForgeItem class:

    /**
     * @return the fuel burn time for this itemStack in a furnace. Return 0 to make
     *         it not act as a fuel. Return -1 to let the default vanilla logic
     *         decide.
     */
    default int getBurnTime(ItemStack itemStack)
    {
        return -1;
    }

I don't know if the "vanilla" logic is failing, or I need to use something else, but this is weird.

I found out that it's most likely that I need to use the

net.minecraftforge.common.ForgeHooks.getBurnTime()

instead.

[Legenes]

47 minutes ago, diesieben07 said:

Look at what the vanilla furnace does (AbstractFurnaceContainer).

I tried to pass an IIntArray as the vanilla container does, with the values I need, I save it in a variable and I use this.trackIntArray(), but it only updates when I open the block. Am I missing something?

    private IIntArray fields;

    public MachineBlockContainer(int id, World clientWorld, BlockPos pos, PlayerInventory playerInv, PlayerEntity player, IIntArray Fields) {
        super(MachineBlock_Container, id);
		//* other stuff *//
        fields = Fields;
		//* other stuff *//

        this.trackIntArray(Fields);
    }

 

Edited November 21, 2019 by Legenes

[Draco18s]

41 minutes ago, Legenes said:

I don't know if the "vanilla" logic is failing, or I need to use something else, but this is weird.

Items, in general, by default, are not furnace fuel. If an item is fuel, it will override that method.

[Legenes]

Just now, Draco18s said:

Items, in general, by default, are not furnace fuel. If an item is fuel, it will override that method.

 

39 minutes ago, Legenes said:

I found out that it's most likely that I need to use the

net.minecraftforge.common.ForgeHooks.getBurnTime()

instead.

I figured it out, and now I use the correct method, but thanks anyway ☺️. (It works.)

[Draco18s]

Just now, diesieben07 said:

... unless it is a vanilla fuel item. Which is why you need to call the method in ForgeHooks.

Well, yes. Because vanilla did things in a way that aren't extendable. I'm not debating that. I'm saying that the method is returning a sensible value and that it's the wrong thing to look at.

[Legenes]

6 minutes ago, Legenes said:

I tried to pass an IIntArray as the vanilla container does, with the values I need, I save it in a variable and I use this.trackIntArray(), but it only updates when I open the block. Am I missing something?

    private IIntArray fields;

    public MachineBlockContainer(int id, World clientWorld, BlockPos pos, PlayerInventory playerInv, PlayerEntity player, IIntArray Fields) {
        super(MachineBlock_Container, id);
		//* other stuff *//
        fields = Fields;
		//* other stuff *//

        this.trackIntArray(Fields);
    }

 

It super weird... the values are only updated when the GUI is opened, after that it doesn't track them.

[Legenes]

Just now, diesieben07 said:

Show your implementation of IIntArray.

Well... I have this only:

    private IIntArray fields = new IntArray(2);

This is in my TileEntity's class.

[Legenes]

1 minute ago, Legenes said:

Well... I have this only:

    private IIntArray fields = new IntArray(2);

This is in my TileEntity's class.

Okay, so I need to implement my own IIntArray, I'm so dumb, sry. I didn't look at the AbstractFurnaceTileEntity.

[Legenes]

1 minute ago, diesieben07 said:

IntArray is not a minecraft class...

It is, but I get the point.

import net.minecraft.util.IntArray;

 

[Legenes]

Finally, here's my working implementation:

    private final IIntArray fields = new IIntArray() {
        public int get(int index) {
            switch(index) {
                case 0:
                    return MachineBlockTile.this.counter;
              case 1:
                    return MachineBlockTile.this.burnTime;
                default:
                    return 0;
            }
        }

        public void set(int index, int value) {
            switch(index) {
                case 0:
                    MachineBlockTile.this.counter = value;
                	break;
                case 1:
                    MachineBlockTile.this.burnTime = value;
                    break;
            }

        }

        public int size() {
            return 2;
        }
    };

Thanks for the help!

Edited November 21, 2019 by Legenes