Posted November 26, 20195 yr My custom crop class: package ... import ... public class SoybeanCrops extends CropsBlock implements IGrowable { public SoybeanCrops() { super(Properties.create(Material.PLANTS).sound(SoundType.PLANT).doesNotBlockMovement().tickRandomly()); ... } @Override public void onBlockHarvested(World world, @Nonnull BlockPos pos, @Nonnull BlockState state, @Nonnull PlayerEntity player) { if (!world.isRemote) { if (!player.isCreative()) { if (this.isMaxAge(state)) { spawnAsEntity(world, pos, new ItemStack(ItemList.soybean_seeds, world.rand.nextInt(3) + 1)); spawnAsEntity(world, pos, new ItemStack(ItemList.soybean, 1)); } else { spawnAsEntity(world, pos, new ItemStack(ItemList.soybean_seeds, 1)); } } } } ... } I've successfully made the game play sound minecraft:item.crop.plant when I use the seeds on the farmland. But why minecraft:block.crop.break doesn't play on block break if there's sound(SoundType.PLANT) in the properties? Edited November 27, 20195 yr by Xander402 A few bytes about me: public class Xander402 extends Modder implements IForumMember { int javaExperience, moddingExperience; LearningWay preferredLearningWay; public Xander402() { this.javaExperience = BIG; this.moddingExperience = NOT_SO_BIG; this.preferredLearningWay = LearningWay.through("exampes"); super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay); } @Override public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); } }
November 27, 20195 yr I would assume BreakEvent in BlockEvent would be able to do something for you. If that don't work possibly HarvestEvent. Edited November 27, 20195 yr by Lea9ue
November 27, 20195 yr You do not need to be messing with events at all. Firstly, I'd recommend using SoundType.CROPS rather than SoundType.PLANTS. It's a more appropriate sound type. Secondly, overriding onBlockHarvested is the wrong way to do this, and is the reason why you are hearing nothing. That method is responsible for playing the block-break effect (sound and particles). It's not responsible for dropping items and you shouldn't abuse it in this way. You shouldn't be hard-coding your block drop logic in 1.14.4. It should be done in a JSON loot table for the block now. Look at the vanilla loot tables (e.g. data/minecraft/loot_tables/blocks/beetroots.json) for an example, bearing in mind that modded loot pools also need a "name" field with some unique name for the loot pool.
November 27, 20195 yr Author Quote You do not need to be messing with events at all. Yes, I thought I wouldn't need to as I've seen no block break events for such things in any Minecraft classes nor modding tutorials. Quote Firstly, I'd recommend using SoundType.CROPS rather than SoundType.PLANTS. SoundType.CROP*. But anyway, thanks ? Quote Secondly, overriding onBlockHarvested is the wrong way to do this, and is the reason why you are hearing nothing. That method is responsible for playing the block-break effect (sound and particles). It's not responsible for dropping items and you shouldn't abuse it in this way. I've actually put a World.playsound effect inside the overridden onBlockHarvested method, but it didn't work, so I removed it. Quote You shouldn't be hard-coding your block drop logic in 1.14.4. It should be done in a JSON loot table for the block now. Look at the vanilla loot tables (e.g. data/minecraft/loot_tables/blocks/beetroots.json) for an example, bearing in mind that modded loot pools also need a "name" field with some unique name for the loot pool. I really don't know what to think about the fact that Minecraft extracts more and more game elements into .json files... There will soon be no use of creating mods as you'll be able to add custom items, mobs, and anything else via .json files. Anyways, thank you for help, moving drops into loot tables and removing overridden onBlockHarvested method did the job and everything works fine. Edited November 27, 20195 yr by Xander402 A few bytes about me: public class Xander402 extends Modder implements IForumMember { int javaExperience, moddingExperience; LearningWay preferredLearningWay; public Xander402() { this.javaExperience = BIG; this.moddingExperience = NOT_SO_BIG; this.preferredLearningWay = LearningWay.through("exampes"); super(/*displayName*/"Xander402", /*moddingSince*/"1.9", preferredLearningWay); } @Override public Goal getReasonOfJoining(Forum forum) { return new Goal(() -> { while (true) moddingExperience++; }); } }
November 27, 20195 yr 41 minutes ago, Xander402 said: There will soon be no use of creating mods as you'll be able to add custom items, mobs, and anything else via .json files. This is a good thing. But not everything can be data driven. Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice. Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked. DO NOT PM ME WITH PROBLEMS. No help will be given.
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.