[1.14.4] leaves decaying

[plugsmustard]

I have a custom tree, but the leaves are decaying without the trunk being harvested.

after extensive searching, i have given up on looking. Is there a 1.14.4 method for rectifying this?

[Draco18s]

7 minutes ago, plugsmustard said:

after extensive searching, i have given up on looking

Must not have tried very hard.

https://www.minecraftforge.net/forum/search/?q=leaf decay&type=forums_topic&nodes=70&updated_after=any&sortby=relevancy&search_and_or=and

 

The top result is this one:

While it isn't marked "solved" there's no reply after my own post, so its probably a thing worth looking into.

[plugsmustard]

15 minutes ago, diesieben07 said:

Show your code.

 

public class TreeLeaves extends LeavesBlock{

    public TreeLeaves(Properties properties) {
        super(properties);
    
    }
    public boolean canEntitySpawn(BlockState state, IBlockReader worldIn, BlockPos pos, EntityType<?> type) {
          return type == EntityType.OCELOT || type == EntityType.PARROT;
       }
    

    @Override
    public void beginLeaveDecay(BlockState state, IWorldReader world, BlockPos pos) {
        
        super.beginLeaveDecay(state, world, pos);
    }

}

[Kenneth201998]

33 minutes ago, Draco18s said:

Must not have tried very hard.

https://www.minecraftforge.net/forum/search/?q=leaf decay&type=forums_topic&nodes=70&updated_after=any&sortby=relevancy&search_and_or=and

 

The top result is this one:

While it isn't marked "solved" there's no reply after my own post, so its probably a thing worth looking into.

Sorry for not marking my post solved but the issue here has to do with block tags:

https://minecraft.gamepedia.com/Tag

Your mod has to have a file tagging your leaves block as leaves and another another tagging your log block as a log. Or something to that affect. I will be updating my post soon.

Edited November 27, 2019 by Kenneth201998

[plugsmustard]

15 minutes ago, diesieben07 said:

Do what Draco said.

should i be making my own tags for this? if so, is there an example you can show me aside from a vanilla one

[plugsmustard]

Just now, diesieben07 said:

But... vanilla is the perfect example...

got ya, i just like seeing custom ones so im sure. but thanks

[plugsmustard]

17 hours ago, diesieben07 said:

But... vanilla is the perfect example...

okay, i have a couple questions. do i name the json file after my block? because i've tried both ways and they're still decaying. i have read the docs and used the vanilla model as an example.

second question: do i need to add an existing minecraft tag like "#minecraft:acacia_logs" to it as well?

[Kenneth201998]

5 minutes ago, plugsmustard said:

okay, i have a couple questions. do i name the json file after my block? because i've tried both ways and they're still decaying. i have read the docs and used the vanilla model as an example.

second question: do i need to add an existing minecraft tag like "#minecraft:acacia_logs" to it as well?

Name one file logs, and another to leaves. And when it comes to minecraft tags, no you do not need to add them, just make sure replace is set to false. 

Edited November 28, 2019 by Kenneth201998

[plugsmustard]

1 minute ago, Kenneth201998 said:

Name one file logs, and another to leaves. And when it comes to minecraft tags, no you do not need to add them, just make sure replace is set to false. 

i did that. they still decay

[Kenneth201998]

1 hour ago, plugsmustard said:

i did that. they still decay

Did you set up the folders properly? Remember the data folder does not go in assets. Show me your data folder setup. 

Edited November 28, 2019 by Kenneth201998

[plugsmustard]

6 minutes ago, Kenneth201998 said:

Did you set up the folders properly? Remember the data folder does not go in assets. Show me your data folder setup. 

 

[Kenneth201998]

16 minutes ago, plugsmustard said:

 

Try this:

Create a new package:

 

data.minecraft.tags.blocks

 

Put the tag files in there. I think that is what I did. What this theoretically does is it appends the file to the default minecraft tags. Just try it. 

 

Also make sure you create a new world while testing it. Testing it in an already created world will still make them decay. 

Edited November 28, 2019 by Kenneth201998

[plugsmustard]

41 minutes ago, Kenneth201998 said:

Try this:

Create a new package:

 

data.minecraft.tags.blocks

  

Put the tag files in there. I think that is what I did. What this theoretically does is it appends the file to the default minecraft tags. Just try it. 

 

Also make sure you create a new world while testing it. Testing it in an already created world will still make them decay. 

looks like that did it! thanks so much!

[Draco18s]

Right, because what you just did was add your logs and leaves to the existing tag so that the existing code (that you didn't mess with) can use the existing tag to recognize your blocks.

[plugsmustard]

1 hour ago, Draco18s said:

Right, because what you just did was add your logs and leaves to the existing tag so that the existing code (that you didn't mess with) can use the existing tag to recognize your blocks.

thanks for the help everyone. we can mark this as solved if you so choose.

 

p.s. yer not that much of a dick lol

[Draco18s]

1 hour ago, plugsmustard said:

p.s. yer not that much of a dick lol

You haven't seen some of my posts where I tell people that they're fucking idiots because they keep not-doing the things I (or someone else) has told them to do multiple times.

[plugsmustard]

10 minutes ago, Draco18s said:

You haven't seen some of my posts where I tell people that they're fucking idiots because they keep not-doing the things I (or someone else) has told them to do multiple times.

well i was probably one of those people once lol. 
you havent been banned yet!