Hello,

maybe its a very simple question, but I havent used Forge long.

Iam coding a mod for a server.

But how can I get the player, which is killing the Enderman?

 

@SubscribeEvent
    public void onKill(LivingDeathEvent event) {
        if (event.entityLiving.getName().equalsIgnoreCase(Minecraft.getMinecraft().thePlayer.getName())) {
            Minecraft.getMinecraft().thePlayer.addChatMessage(new ChatComponentText("Test1"));
            Entity e = event.entity;
            if (e instanceof EntityEnderman) {
                i++;
              	Minecraft.getMinecraft().thePlayer.addChatMessage(new ChatComponentText("§7Enderman killed: §e§l" + i));
            }
        }
    }

 

The player will get the message if an Enderman dies, but it doesn't matter who killed the enderman.

But the player should only get the message, if he kills an Enderman.

How can I do this?

 

I am using Forge 1.8.9-11.15.1.2318

 

Thanks.

(Sorry for my bad english)

You cannot call Minecraft.getMinecraft().thePlayer if you are on the server side.

As you're already using the LivingDeathEvent you can call event.getSource().getTrueSource() to get the player who killed the enderman.

1 hour ago, MadeByProxxy said:

if (event.entityLiving.getName().equalsIgnoreCase(Minecraft.getMinecraft().thePlayer.getName())) {

Oh jesus christ on a crutch. Everything about this line is awful.

 

1) Never convert to strings to do comparisons

2) You're reaching across logical sides (this will hard-crash a dedicated server)

3) This is (attempting) to check if the entity that died is the player

5 hours ago, Angercraft said:

You cannot call Minecraft.getMinecraft().thePlayer if you are on the server side.

As you're already using the LivingDeathEvent you can call event.getSource().getTrueSource() to get the player who killed the enderman.

Okay, thank you. How can I use .getSource? It doesnt exists with me.

 

3 hours ago, Draco18s said:

Oh jesus christ on a crutch. Everything about this line is awful.

Yeah I know.. I looked at that line again and its really stupid..

Thanks