Search the Forums BEFORE making a new post.

Increase target's damage via usable item

Posted December 4, 20195 yr

Hello,

I'm trying to create a custom item that increases the damage of the target by 1.

double demidzs = 1.0 + target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).getBaseValue();

if (event.getHand() == EnumHand.MAIN_HAND)
{
if (i.equals(ModItems.DAMAGEINDICATOR) && demidzs > 1.0) {
    System.out.println("DMG indicator branch entered");
    p.inventory.decrStackSize(p.inventory.currentItem, 1);
    target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(demidzs);
}
}

When I'm using it on monsters such as Spider, it works fine.

When I'm using it on mobs that have no attack (I think that's the issue here), the client crashes with a java.lang.NullPointerException.

How do I fix this problem?

(1.12.2)

Thanks!

Edited December 4, 20195 yr by AkosM

Quote

December 4, 20195 yr

1 hour ago, AkosM said:
Hello,

I'm trying to create a custom item that increases the damage of the target by 1.
double demidzs = 1.0 + target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).getBaseValue();
if (event.getHand() == EnumHand.MAIN_HAND)
{
if (i.equals(ModItems.DAMAGEINDICATOR) && demidzs > 1.0) {
    System.out.println("DMG indicator branch entered");
    p.inventory.decrStackSize(p.inventory.currentItem, 1);
    target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(demidzs);
}
}
When I'm using it on monsters such as Spider, it works fine.

When I'm using it on mobs that have no attack (I think that's the issue here), the client crashes with a java.lang.NullPointerException.

How do I fix this problem?

(1.12.2)

Thanks!

It is because they dont have attribute ATTACK_DAMAGE, maybe add some checkings about whether ATTACK_DAMAGE exist for the entity then apply it

Quote

December 5, 20195 yr

Where does it NPE?

Also, use Logger, not System.out

Apparently I'm a complete and utter jerk and come to this forum just like to make fun of people, be confrontational, and make your personal life miserable. If you think this is the case, JUST REPORT ME. Otherwise you're just going to get reported when you reply to my posts and point it out, because odds are, I was trying to be nice.

Exception: If you do not understand Java, I WILL NOT HELP YOU and your thread will get locked.

DO NOT PM ME WITH PROBLEMS. No help will be given.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/78507-increase-targets-damage-via-usable-item/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

tysm

By ilov3gam3z · 3 hours ago3 hr
Orbital strike cannon fishing rod mod

was focused on school so didnt respond u think ur gonna get 1.21+ done by this week? @FoxyWoxy

By Astoxy · 10 hours ago10 hr
How to add my mob to another mod's biome in 1.20.1.

You can add mob spawns using Forge's Biome Modifiers feature. I won't go into details on how to use a data generator for them, but here's a simple example:
{ "type": "forge:add_spawns", // Required "biomes": "#namespace:biome_tag", // Accepts a biome id, [list of biome ids], or #namespace:biome_tag "spawners": { "type": "namespace:entity_type", // Type of mob to spawn "weight": 100, // int, spawn weighting "minCount": 1, // int, minimum pack size "maxCount": 4 // int, maximum pack size } }This JSON file would go somewhere like this: data/modid/forge/biome_modifier/your_biome_modifier.json

By Jonathing · 21 hours ago21 hr
How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted Yesterday at 12:07 AM1 day
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Wednesday at 04:08 PM2 days

Astoxy

Sign In

Increase target's damage via usable item

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

Orbital strike cannon fishing rod mod

How to add my mob to another mod's biome in 1.20.1.

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)