Increase target's damage via usable item

[AkosM]

Hello,

I'm trying to create a custom item that increases the damage of the target by 1.

 

double demidzs = 1.0 + target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).getBaseValue();

if (event.getHand() == EnumHand.MAIN_HAND)
{
if (i.equals(ModItems.DAMAGEINDICATOR) && demidzs > 1.0) {
    System.out.println("DMG indicator branch entered");
    p.inventory.decrStackSize(p.inventory.currentItem, 1);
    target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(demidzs);
}
}

 

 

When I'm using it on monsters such as Spider, it works fine.

When I'm using it on mobs that have no attack (I think that's the issue here), the client crashes with a java.lang.NullPointerException.

 

How do I fix this problem?

(1.12.2)

 

Thanks!

Edited December 4, 2019 by AkosM

[poopoodice]

1 hour ago, AkosM said:

Hello,

I'm trying to create a custom item that increases the damage of the target by 1.

 

double demidzs = 1.0 + target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).getBaseValue();

if (event.getHand() == EnumHand.MAIN_HAND)
{
if (i.equals(ModItems.DAMAGEINDICATOR) && demidzs > 1.0) {
    System.out.println("DMG indicator branch entered");
    p.inventory.decrStackSize(p.inventory.currentItem, 1);
    target.getEntityAttribute(SharedMonsterAttributes.ATTACK_DAMAGE).setBaseValue(demidzs);
}
}

 

 

When I'm using it on monsters such as Spider, it works fine.

When I'm using it on mobs that have no attack (I think that's the issue here), the client crashes with a java.lang.NullPointerException.

 

How do I fix this problem?

(1.12.2)

 

Thanks!

It is because they dont have attribute ATTACK_DAMAGE, maybe add some checkings about whether ATTACK_DAMAGE exist for the entity then apply it

[Draco18s]

Where does it NPE?

Also, use Logger, not System.out