(SOLVED) [1.14.4] Get Biome of targeted Block

[MineModder2000]

I am using the event.getWorld().getBiome() method for RightClickItem Event. It takes a position as a parameter. If I use event.getPos() I get the position the player is standing in, but I want the position of the block being targeted, if possible. 

 

- Thanks. 

Edited January 26, 2020 by MineModder2000

[Alpvax]

If you are trying to get the position of a block outside of the reach distance, you need to perform a raytrace to find that block position.

[MineModder2000]

  On 1/20/2020 at 8:47 AM, diesieben07 said:

RightClickItem is specifically for the case where no block is targeted. Use RightClickBlock for the case where a block is right-clicked.

Expand  

I should've specified, I want this check to happen when the player is holding an item, so the RightClickItem event is what I want cancelled when the block is in the wrong biome. It actually doesn't work that bad the way I have it, it would just be better if it was based on the targeted block rather than the block the player is on. 

[Cadiboo]

You can use Minecraft#objectMouseOver. You can also look at the ray trading that the debug overlay does to show you your targeted block and block (at a surprisingly far range)

[MineModder2000]

Okay so the BlockRayTraceResult constructor takes the following : Vec3d, Direction, BlockPos, Boolean. I think I got the correct Vec3d and Direction, but I am not sure how to get the targeted Block, so I can get it's position. 

 

 @SuppressWarnings("deprecation")
	@SubscribeEvent
    public void rightClickItem(RightClickItem event) {
    	
    	BlockRayTraceResult result;
    	
    	result = new BlockRayTraceResult(event.getEntityPlayer().getLookVec(), event.getFace(), event.getPos(), false);
    	
    	if ((event.getEntityPlayer().getHeldItemMainhand().getItem() == Items.GLASS_BOTTLE ||
    		event.getEntityPlayer().getHeldItemMainhand().getItem() == Items.WATER_BUCKET) &&
    	    (!event.getWorld().getBiome(result.getPos()).toString().contains("River"))) {
    		
    			event.setCanceled(true);
    	}
    }

[Draco18s]

...You have to run a ray trace. Take the existing client side code, copy it, and put it where you need it (common code).

[MineModder2000]

  On 1/21/2020 at 9:02 PM, Draco18s said:

run a ray trace

Expand  

Any examples docs? 

[Draco18s]

I'm not sure what you need docs for to copy-paste a function.

[MineModder2000]

  On 1/21/2020 at 10:16 PM, Draco18s said:

I'm not sure what you need docs for to copy-paste a function.

Expand  

I don't understand what function, what existing client side code? What does running a ray trace mean?

Edited January 21, 2020 by MineModder2000

[Cadiboo]

Some examples of code that do raytracing:

- debug overlay’s targeted block

- throwable entity’s update code (before it calls onImpact)

- Minecraft’s code that’s sets objectMouseOver 

[Draco18s]

  On 1/21/2020 at 10:19 PM, MineModder2000 said:

what existing client side code?

Expand  

 

This:

  On 1/21/2020 at 12:00 PM, Cadiboo said:

Minecraft#objectMouseOver.

Expand  

[MineModder2000]

  On 1/22/2020 at 12:06 AM, Draco18s said:

 

This:

Expand  

 if (this.leftClickCounter <= 0 && !this.player.isHandActive()) {
         if (leftClick && this.objectMouseOver != null && this.objectMouseOver.getType() == RayTraceResult.Type.BLOCK) {
            BlockRayTraceResult blockraytraceresult = (BlockRayTraceResult)this.objectMouseOver;
            BlockPos blockpos = blockraytraceresult.getPos();
            if (!this.world.isAirBlock(blockpos)) {
               Direction direction = blockraytraceresult.getFace();
               if (this.playerController.onPlayerDamageBlock(blockpos, direction)) {
                  this.particles.addBlockHitEffects(blockpos, blockraytraceresult);
                  this.player.swingArm(Hand.MAIN_HAND);

 

I don't understand this code, objectMouseOver is not set anywhere in the class, so how is it being used? 

[MineModder2000]

  On 1/21/2020 at 11:25 PM, Cadiboo said:

Some examples of code that do raytracing:

- debug overlay’s targeted block

- throwable entity’s update code (before it calls onImpact)

- Minecraft’s code that’s sets objectMouseOver 

Expand  

 

I tried to implement the code from debug overlay :

 

RayTraceResult result;
    	BlockPos blockpos = null;
    	
    	result = event.getPlayer().func_213324_a(20.0D, 0.0F, true);
    	
    	if (result.getType() == RayTraceResult.Type.BLOCK) {
    		
            blockpos = ((BlockRayTraceResult)result).getPos();
    	}
    	
    	if ((event.getPlayer().getHeldItemMainhand().getItem() == Items.GLASS_BOTTLE ||
    		event.getPlayer().getHeldItemMainhand().getItem() == Items.WATER_BUCKET) &&
    	    (!event.getWorld().getBiome(blockpos).toString().contains("River"))) {
    		
    			event.setCanceled(true);
    	}

 

But its still going by the block that the player is standing on, not looking at. 

[MineModder2000]

Anyone?

[Alpvax]

  On 1/22/2020 at 1:19 AM, MineModder2000 said:

its still going by the block that the player is standing on

Expand  

Are you sure that you are getting the correct BlockPos? You are searching with up to a 20 block range. What happens if the BlockPos is null?

[MineModder2000]

  On 1/24/2020 at 2:39 PM, Alpvax said:

Are you sure that you are getting the correct BlockPos? You are searching with up to a 20 block range. What happens if the BlockPos is null?

Expand  

As stated it's fetching the position of the block that the player is standing on. If it's null the game crashes. 

[Draco18s]

  On 1/25/2020 at 2:37 AM, MineModder2000 said:

If it's null the game crashes. 

Expand  

You should fix that.

[MineModder2000]

  On 1/25/2020 at 3:43 AM, Draco18s said:

You should fix that.

Expand  

Well it's never naturally null, that's only if I comment out the code that sets it. The bigger problem is getting the blockPos of the block the player is looking at. 

[Cadiboo]

  On 1/25/2020 at 4:33 AM, MineModder2000 said:

Well it's never naturally null

Expand  

What if you’re not looking at a block...

[MineModder2000]

  On 1/25/2020 at 6:00 AM, Cadiboo said:

What if you’re not looking at a block...

Expand  

The code isn't working as intended, it's going by the block the player is standing on not looking at. 

[MineModder2000]

  On 1/25/2020 at 5:38 AM, herasswideopen said:

I suggest going to the DrawBlockHighlightEvent class, seeing where it is triggered, and checking if the blockpos is there

Expand  

I love you, didn't know this event existed, but it's definitely the right one, thanks. 

 

PS : Interesting username....