(SOLVED) [1.14.4] Check if it's raining on a Block

[MineModder2000]

I need to check if it's raining on a particular block. The isRaining() method checks if it's raining globally, the isRainingAt() method just doesn't seem to work, it always returns false. 

 

    @SubscribeEvent
    public void EntityPlaceEvent(EntityPlaceEvent event) {
    	
    	World world = event.getEntity().world;
    	BlockPos blockpos = event.getPos();
    	BlockState blockstate = world.getBlockState(blockpos);
    	
    	if (event.getState().getBlock() == Blocks.CAMPFIRE && world.isRainingAt(blockpos)) {
    		
    		world.setBlockState(blockpos, blockstate.with(CampfireBlock.LIT, false));
    	}
    }

 

Edited January 26, 2020 by MineModder2000

[unassigned]

 I went to look at the isRainingAt() method, and it does some other checks which is why its returning false. However, if you check what biome you are in and if it can rain in the first place, then you can get the expected result:

 

world.getBiome(position).getPrecipitation() == Biome.RainType.RAIN && world.isRaining()

 

This just checks the biome the positions in, and see if it can actually rain. If so, then check if its raining. If both are true, it must be raining at that position. If the biome doesn't allow to rain, and it is raining (as rain happens everywhere), then it'll return false (ex. in a desert).

Edited January 26, 2020 by unassigned
quoted post.

[Draco18s]

Don't forget that blocks that are underground still need to check to see if they can see the sky.

[MineModder2000]

  On 1/26/2020 at 3:12 AM, unassigned said:

 I went to look at the isRainingAt() method, and it does some other checks which is why its returning false. However, if you check what biome you are in and if it can rain in the first place, then you can get the expected result:

 

world.getBiome(position).getPrecipitation() == Biome.RainType.RAIN && world.isRaining()

 

This just checks the biome the positions in, and see if it can actually rain. If so, then check if its raining. If both are true, it must be raining at that position. If the biome doesn't allow to rain, and it is raining (as rain happens everywhere), then it'll return false (ex. in a desert).

Expand  

 

Actually not so unassigned, this doesn't account for covering. If a block is a under a tree for example, it won't get rain on it, but according to these checks it is raining. 

[MineModder2000]

  On 1/26/2020 at 3:41 AM, Draco18s said:

Don't forget that blocks that are underground still need to check to see if they can see the sky.

Expand  

Oh I just realized that there is a canBlockSeeSky(pos) method inside of world, that's what I needed to check in addition. All working now ?