[1.15.2] Entites Spawn as pigs

[plugsmustard]

I am unable to find where the problem lies as I have followed MCJTY's GitHub for changes, alas, I am unsure.

 

my registry: https://github.com/drmdgg/mcraft1.15.1/blob/master/src/main/java/drmdgg/marijuanacraft/util/Registries.java

models: https://github.com/drmdgg/mcraft1.15.1/tree/master/src/main/java/drmdgg/marijuanacraft/client/models

renders: https://github.com/drmdgg/mcraft1.15.1/tree/master/src/main/java/drmdgg/marijuanacraft/client/renders

where I register renders: https://github.com/drmdgg/mcraft1.15.1/blob/6c2c2bddb53379668a72dddc6387a9435739427b/src/main/java/drmdgg/marijuanacraft/client/ClientModEventSubscriber.java#L44-L50

where I register my Registries: https://github.com/drmdgg/mcraft1.15.1/blob/6c2c2bddb53379668a72dddc6387a9435739427b/src/main/java/drmdgg/marijuanacraft/MarijuanaCraft.java#L76

Edited January 29, 2020 by plugsmustard

[plugsmustard]

On 1/27/2020 at 3:21 AM, diesieben07 said:

Your repository is unusable because it's missing the build.gradle, etc.

the build.gradle is all there now!

[plugsmustard]

17 hours ago, diesieben07 said:

You create EntityType instances for all your entities in drmdgg.marijuanacraft.init.Entities. You do so in a static initializer, which is not correct, registry entries must be created in their appropriate registry event. Apart from that, you never register these EntityType instances, so they are not valid. Regardless you use them to create your spawn egg items, which means they point to invalid entities.

 

You then register your entities using DeferredRegister in drmdgg.marijuanacraft.util.Registries. You never use these to create spawn eggs.

so I should be deleting that entire class? and just work with deferredRegister?

 

how do I do this with spawn eggs?

[plugsmustard]

3 hours ago, diesieben07 said:

DeferredRegister and vanilla spawn eggs are a bit problematic currently, because items are registered before entities.

so how should i be doing it?

 

and should i bother using the "Entities" class, which has all the world spawn and spawn eggs(that dont work)

[Cadiboo]

These two topics also describe this issue

 

[Cadiboo]

7 minutes ago, diesieben07 said:

You either have to write your own spawn egg code which uses suppliers or use the traditional registry events.

Either write your own better code or use the same hack that’s been used for ages of creating your entity type in the item event that is incompatible with dynamically reloading registries. I would definitely go with the former.

[plugsmustard]

Just now, diesieben07 said:

Yeah, this is actually pretty easy to do by extending SpawnEggItem. Pass null to the constuctor and overide getType to use a supplier instead of the typeIn field.

ill get working on that asap! thanks

 

[Cadiboo]

4 minutes ago, diesieben07 said:

Yeah, this is actually pretty easy to do by extending SpawnEggItem. Pass null to the constuctor and overide getType to use a supplier instead of the typeIn field.

Any reason why Forge doesn’t patch in another constructor the way it does for fluids (or maybe it’s buckets?)

[DragonITA]

4 hours ago, diesieben07 said:

DeferredRegister and vanilla spawn eggs are a bit problematic currently, because items are registered before entities.

Will this be fixed with the next updates?

[Cadiboo]

16 minutes ago, diesieben07 said:

Probably because nobody has made  PR yet.

That sounds like it needs to be done then.

[Choonster]

tterrag did create a PR for that here, but it went stale.

Edited January 30, 2020 by Choonster

[DragonITA]

I have the same problem right now, but I use the traditional method and not the DeferredRegister, because I noticed that the DeferredRegister is not yet stable enough with the registration of the entities.

[plugsmustard]

2 minutes ago, DragonITA said:

I have the same problem right now, but I use the traditional method and not the DeferredRegister, because I noticed that the DeferredRegister is not yet stable enough with the registration of the entities.

is your github up to date so i can look? 

[DragonITA]

@plugsmustard Yes, here is the Link: https://github.com/DragonGamerDevelopers/NewFantasyMod-1.15.1

[plugsmustard]

well i got the deferred register spawn egg working (almost)

 

is this my model doing this?

[plugsmustard]

17 minutes ago, diesieben07 said:

It looks like a rendering problem, yes.

what program do you use for models? blockbench doesn't include everything for 1.15 that supposed to be there

[DragonITA]

I don't think it will help you, but if you have no other choice, I would recommend Blender and import the model as OBJ Model or JSON Model. For this you can simply use the addon that used Lycanite (you have to import it manually, so go into scripts and paste there the code you copied). The link: https://gitlab.com/Lycanite/LycanitesMobs/blob/master/src/main/resources/io_export_lycanitesmobs.py

[Cadiboo]

13 hours ago, DragonITA said:

I noticed that the DeferredRegister is not yet stable enough with the registration of the entities.

This is not at all true. There is a small (easily fixable on your end) issue with SpawnEggItems. Not Entities.

Edited January 31, 2020 by Cadiboo