(SOLVED) [1.14.4] BlockState Json

[MineModder2000]

I'm confused on what the exact syntax should be :

 

{
    "variants": {
    	"lit=true": {"model": "mymod:block/green_torch"}
		"lit=false": {"model": "mymod:block/burnt_torch"}
    }
}

 

GreenTorch extends TorchBlock, and uses BlockStateProperties.LIT. I know how to set properties, and have confirmed that is all working. But with the above, and the model files correctly pointing to textures, I get the magenta / black box. 

 

Oh I forgot the comma after the bracket.......... ?‍♂️

Edited January 31, 2020 by MineModder2000

[MineModder2000]

New question, how do I use the same model for all states, but change only the texture? I've tried this : 

 

{
	"defaults": {
		"model": {"block/torch"}
	},
    "variants": {
    	"lit=true": {"texture": "mymod:block/green_torch"},
		"lit=false": {"texture": "mymod:block/burnt_torch"}
    }
}

 

Edited January 31, 2020 by MineModder2000

[Cadiboo]

1 hour ago, MineModder2000 said:

New question, how do I use the same model for all states, but change only the texture?

You still need a separate model for each, but sub models can override textures from their parent.

[Draco18s]

By the way, format your damn json files. Christ.

This should be a straight line:

[MineModder2000]

16 minutes ago, Draco18s said:

By the way, format your damn json files. Christ.

This should be a straight line:

? This is just the copy paste I swear, I don't know why it does that. My json files are neat, I have OCD so I wouldn't tolerate that. 

[Draco18s]

1 hour ago, MineModder2000 said:

? This is just the copy paste I swear, I don't know why it does that. My json files are neat, I have OCD so I wouldn't tolerate that. 

Probably spaces vs. tabs

Yeah, the lit-false line has two tabs, the lit-true is one tab and several spaces.

[MineModder2000]

1 minute ago, Draco18s said:

Probably spaces vs. tabs

Yeah, the lit-false line has two tabs, the lit-true is one tab and several spaces.

Ah, it was such. 

[Cadiboo]

16 hours ago, Draco18s said:

Probably spaces vs. tabs

Choose one style (tabs) and have your editor replace all occurrences of the other style with your preferred style. Also be sure to tell everyone that your style is superior at every opportunity.

[Draco18s]

4 hours ago, Cadiboo said:

Choose one style (tabs) and have your editor replace all occurrences of the other style with your preferred style. Also be sure to tell everyone that your style is superior at every opportunity.

Tabs are superior because when you backspace it removed the entire tab. Ergo it is the only correct way (also tabs are exactly 4 spaces wide and every other width is wrong).

[Draco18s]

1 hour ago, diesieben07 said:

If your IDE does not remove 4 spaces using one backspace press it is time to get a new IDE.

I have other issues (such as trying to highlight multiple lines so that when I do a delete, the "head" of the line ends up in the right spot), but the backspace thing is common to nearly all IDEs I've ever used.